Skip to content

Commit 27babbe

Browse files
seismanweiji14
andauthored
Do not skip xarray shading tests on all platforms (#669)
xarray grid shading is known to fail with GMT 6.1.1. That's why we want to mark the test xfail. The xfail marker works well for Linux and Windows, but not for macOS, due to segmentation faults. So ideally what we should do is: - GMT 6.1.1 + Linux/Windows: xfail - GMT 6.1.1 + macOS: skip - GMT master + Linux/Windows/macOS: no marker Co-authored-by: Wei Ji <[email protected]>
1 parent 2291371 commit 27babbe

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

pygmt/tests/test_grdimage.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,9 +74,13 @@ def test_grdimage_file():
7474
return fig
7575

7676

77-
@pytest.mark.skip(
78-
reason="Upstream bug in GMT 6.1.1",
79-
condition=gmt_version <= Version("6.1.1") and sys.platform == "darwin",
77+
@pytest.mark.skipif(
78+
gmt_version <= Version("6.1.1") and sys.platform == "darwin",
79+
reason="Upstream bug in GMT 6.1.1 that causes segfault on macOS",
80+
)
81+
@pytest.mark.xfail(
82+
condition=gmt_version <= Version("6.1.1") and sys.platform != "darwin",
83+
reason="Upstream bug in GMT 6.1.1 that causes this test to fail on Linux/Windows",
8084
)
8185
@check_figures_equal()
8286
@pytest.mark.parametrize(

0 commit comments

Comments
 (0)