Skip to content

Commit 4fbf32f

Browse files
clib: Improve Session.get_default docstring to clarify that GMT configuration parameters are supported (#3232)
Co-authored-by: Michael Grund <[email protected]>
1 parent 118a873 commit 4fbf32f

File tree

2 files changed

+13
-14
lines changed

2 files changed

+13
-14
lines changed

pygmt/clib/session.py

Lines changed: 12 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -453,11 +453,12 @@ def destroy(self):
453453

454454
self.session_pointer = None
455455

456-
def get_default(self, name):
456+
def get_default(self, name: str) -> str:
457457
"""
458-
Get the value of a GMT default parameter (library version, paths, etc).
458+
Get the value of a GMT configuration parameter or a GMT API parameter.
459459
460-
Possible default parameter names include:
460+
In addition to the long list of GMT configuration parameters, the following API
461+
parameter names are also supported:
461462
462463
* ``"API_VERSION"``: The GMT API version
463464
* ``"API_PAD"``: The grid padding setting
@@ -473,13 +474,14 @@ def get_default(self, name):
473474
474475
Parameters
475476
----------
476-
name : str
477-
The name of the default parameter (e.g., ``"API_VERSION"``)
477+
name
478+
The name of the GMT configuration parameter (e.g., ``"PROJ_LENGTH_UNIT"``)
479+
or a GMT API parameter (e.g., ``"API_VERSION"``).
478480
479481
Returns
480482
-------
481-
value : str
482-
The default value for the parameter.
483+
value
484+
The current value for the parameter.
483485
484486
Raises
485487
------
@@ -493,15 +495,11 @@ def get_default(self, name):
493495
)
494496

495497
# Make a string buffer to get a return value
496-
value = ctp.create_string_buffer(10000)
497-
498+
value = ctp.create_string_buffer(4096)
498499
status = c_get_default(self.session_pointer, name.encode(), value)
499-
500500
if status != 0:
501-
raise GMTCLibError(
502-
f"Error getting default value for '{name}' (error code {status})."
503-
)
504-
501+
msg = f"Error getting value for '{name}' (error code {status})."
502+
raise GMTCLibError(msg)
505503
return value.value.decode()
506504

507505
def get_common(self, option):

pygmt/tests/test_clib.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -534,6 +534,7 @@ def test_get_default():
534534
assert lib.get_default("API_GRID_LAYOUT") in ["rows", "columns"]
535535
assert int(lib.get_default("API_CORES")) >= 1
536536
assert Version(lib.get_default("API_VERSION")) >= Version("6.3.0")
537+
assert lib.get_default("PROJ_LENGTH_UNIT") == "cm"
537538

538539

539540
def test_get_default_fails():

0 commit comments

Comments
 (0)