pygmt.surface: Remove parameter 'outfile', use 'outgrid' instead (#1976)

Author: seisman

pygmt/src/surface.py

@@ -7,7 +7,6 @@
     GMTTempFile,
     build_arg_string,
     check_data_input_order,
-    deprecate_parameter,
     fmt_docstring,
     kwargs_to_strings,
     use_alias,
@@ -18,7 +17,6 @@
 
 
 @fmt_docstring
-@deprecate_parameter("outfile", "outgrid", "v0.5.0", remove_version="v0.7.0")
 @check_data_input_order("v0.5.0", remove_version="v0.7.0")
 @use_alias(
     I="spacing",

pygmt/tests/test_surface.py

@@ -145,25 +145,3 @@ def test_surface_with_outgrid_param(data, region, spacing, expected_grid):
         assert os.path.exists(path=tmpfile.name)  # check that outgrid exists at path
         with xr.open_dataarray(tmpfile.name) as grid:
             check_values(grid, expected_grid)
-
-
-def test_surface_deprecate_outfile_to_outgrid(data, region, spacing, expected_grid):
-    """
-    Make sure that the old parameter "outfile" is supported and it reports a
-    warning.
-    """
-    with pytest.warns(expected_warning=FutureWarning) as record:
-        data = data.values  # convert pandas.DataFrame to numpy.ndarray
-        with GMTTempFile(suffix=".nc") as tmpfile:
-            output = surface(
-                data=data,
-                spacing=spacing,
-                region=region,
-                outfile=tmpfile.name,
-                verbose="e",  # Suppress warnings for IEEE 754 rounding
-            )
-            assert output is None  # check that output is None since outfile is set
-            assert os.path.exists(path=tmpfile.name)  # check that file exists at path
-            with xr.open_dataarray(tmpfile.name) as grid:
-                check_values(grid, expected_grid)
-        assert len(record) == 1  # check that only one warning was raised