Merge branch 'main' into api/virtualfile-from-stringio

Author: seisman

pygmt/figure.py

@@ -354,41 +354,38 @@ def savefig(  # noqa: PLR0912
         prefix, suffix = fname.with_suffix("").as_posix(), fname.suffix
         ext = suffix[1:].lower()  # Remove the . and normalize to lowercase
 
-        if ext == "jpeg":  # Alias jpeg to jpg
-            ext = "jpg"
-        elif ext == "tiff":  # GeoTIFF
-            kwargs["W"] = "+g"
-        elif ext == "kml":  # KML
-            kwargs["W"] = "+k"
-
-        if ext not in fmts:
-            if ext == "ps":
-                raise GMTInvalidInput(
-                    "Extension '.ps' is not supported. "
-                    "Please use '.eps' or '.pdf' instead."
-                )
-            raise GMTInvalidInput(f"Unknown extension '.{ext}'.")
+        match ext:
+            case "jpeg":  # Alias jpeg to jpg
+                ext = "jpg"
+            case "tiff":  # GeoTIFF
+                kwargs["W"] = "+g"
+            case "kml":  # KML
+                kwargs["W"] = "+k"
+            case "ps":
+                msg = "Extension '.ps' is not supported. Use '.eps' or '.pdf' instead."
+                raise GMTInvalidInput(msg)
+            case ext if ext not in fmts:
+                raise GMTInvalidInput(f"Unknown extension '.{ext}'.")
+
         fmt = fmts[ext]
         if transparent:
             if fmt != "g":
-                raise GMTInvalidInput(
-                    f"Transparency unavailable for '{ext}', only for png."
-                )
+                msg = f"Transparency unavailable for '{ext}', only for png."
+                raise GMTInvalidInput(msg)
             fmt = fmt.upper()
         if anti_alias:
             kwargs["Qt"] = 2
             kwargs["Qg"] = 2
 
         if worldfile:
             if ext in {"eps", "kml", "pdf", "tiff"}:
-                raise GMTInvalidInput(
-                    f"Saving a world file is not supported for '{ext}' format."
-                )
+                msg = f"Saving a world file is not supported for '{ext}' format."
+                raise GMTInvalidInput(msg)
             kwargs["W"] = True
 
         self.psconvert(prefix=prefix, fmt=fmt, crop=crop, **kwargs)
 
-        # Remove the .pgw world file if exists
+        # Remove the .pgw world file if exists.
         # Not necessary after GMT 6.5.0.
         # See upstream fix https://github.com/GenericMappingTools/gmt/pull/7865
         if ext == "tiff":

pygmt/helpers/testing.py

@@ -89,6 +89,8 @@ def wrapper(*args, ext="png", request=None, **kwargs):
                 file_name = "".join(c for c in request.node.name if c in allowed_chars)
             except AttributeError:  # 'NoneType' object has no attribute 'node'
                 file_name = func.__name__
+
+            fig_ref, fig_test = None, None
             try:
                 fig_ref, fig_test = func(*args, **kwargs)
                 ref_image_path = Path(result_dir) / f"{file_name}-expected.{ext}"

pygmt/tests/test_show_versions.py

@@ -5,16 +5,43 @@
 import io
 
 import pygmt
+import pytest
 
 
 def test_show_versions():
     """
-    Check that pygmt.show_versions() reports version information from PyGMT, the
-    operating system, dependencies and the GMT library.
+    Check that pygmt.show_versions reports version information of PyGMT, the operating
+    system, dependencies and the GMT library.
     """
     buf = io.StringIO()
     pygmt.show_versions(file=buf)
-    assert "PyGMT information:" in buf.getvalue()
-    assert "System information:" in buf.getvalue()
-    assert "Dependency information:" in buf.getvalue()
-    assert "GMT library information:" in buf.getvalue()
+    output = buf.getvalue()
+
+    assert "PyGMT information:" in output
+    assert "System information:" in output
+    assert "Dependency information:" in output
+    assert "GMT library information:" in output
+    assert "WARNING:" not in output  # No GMT-Ghostscript incompatibility warnings.
+
+
+@pytest.mark.parametrize(
+    ("gs_version", "gmt_version"),
+    [
+        ("9.52", "6.4.0"),
+        ("10.01", "6.4.0"),
+        ("10.02", "6.4.0"),
+        (None, "6.5.0"),
+    ],
+)
+def test_show_versions_ghostscript_warnings(gs_version, gmt_version, monkeypatch):
+    """
+    Check that pygmt.show_versions reports warnings for GMT-Ghostscript incompatibility.
+    """
+    monkeypatch.setattr("pygmt._show_versions.__gmt_version__", gmt_version)
+    monkeypatch.setattr(
+        "pygmt._show_versions._get_ghostscript_version", lambda: gs_version
+    )
+
+    buf = io.StringIO()
+    pygmt.show_versions(file=buf)
+    assert "WARNING:" in buf.getvalue()