Refactor all wrappers to pass an argument list to Session.call_module (#3132)

Author: seisman

pygmt/figure.py

@@ -18,7 +18,7 @@
 from pygmt.clib import Session
 from pygmt.exceptions import GMTError, GMTInvalidInput
 from pygmt.helpers import (
-    build_arg_string,
+    build_arg_list,
     fmt_docstring,
     kwargs_to_strings,
     launch_external_viewer,
@@ -108,7 +108,7 @@ def _activate_figure(self):
         # Passing format '-' tells pygmt.end to not produce any files.
         fmt = "-"
         with Session() as lib:
-            lib.call_module(module="figure", args=f"{self._name} {fmt}")
+            lib.call_module(module="figure", args=[self._name, fmt])
 
     def _preprocess(self, **kwargs):
         """
@@ -234,15 +234,12 @@ def psconvert(self, **kwargs):
         # Default cropping the figure to True
         if kwargs.get("A") is None:
             kwargs["A"] = ""
-        # Manually handle prefix -F argument so spaces aren't converted to \040
-        # by build_arg_string function. For more information, see
-        # https://github.com/GenericMappingTools/pygmt/pull/1487
-        prefix = kwargs.pop("F", None)
+
+        prefix = kwargs.get("F")
         if prefix in ["", None, False, True]:
             raise GMTInvalidInput(
                 "The 'prefix' parameter must be specified with a valid value."
             )
-        prefix_arg = f'-F"{prefix}"'
 
         # check if the parent directory exists
         prefix_path = Path(prefix).parent
@@ -252,9 +249,7 @@ def psconvert(self, **kwargs):
             )
 
         with Session() as lib:
-            lib.call_module(
-                module="psconvert", args=f"{prefix_arg} {build_arg_string(kwargs)}"
-            )
+            lib.call_module(module="psconvert", args=build_arg_list(kwargs))
 
     def savefig(  # noqa: PLR0912
         self,

pygmt/helpers/utils.py

@@ -174,7 +174,11 @@ def data_kind(data=None, x=None, y=None, z=None, required_z=False, required_data
     'image'
     """
     # determine the data kind
-    if isinstance(data, str | pathlib.PurePath):
+    if isinstance(data, str | pathlib.PurePath) or (
+        isinstance(data, list | tuple)
+        and all(isinstance(_file, str | pathlib.PurePath) for _file in data)
+    ):
+        # One or more files
         kind = "file"
     elif isinstance(data, bool | int | float) or (data is None and not required_data):
         kind = "arg"

pygmt/session_management.py

@@ -23,9 +23,9 @@ def begin():
 
     prefix = "pygmt-session"
     with Session() as lib:
-        lib.call_module(module="begin", args=prefix)
+        lib.call_module(module="begin", args=[prefix])
         # pygmt relies on GMT modern mode with GMT_COMPATIBILITY at version 6
-        lib.call_module(module="set", args="GMT_COMPATIBILITY 6")
+        lib.call_module(module="set", args=["GMT_COMPATIBILITY=6"])
 
 
 def end():
@@ -38,4 +38,4 @@ def end():
     ``pygmt.begin``), and bring the figures to the working directory.
     """
     with Session() as lib:
-        lib.call_module(module="end", args="")
+        lib.call_module(module="end", args=[])

pygmt/src/basemap.py

@@ -3,7 +3,7 @@
 """
 
 from pygmt.clib import Session
-from pygmt.helpers import build_arg_string, fmt_docstring, kwargs_to_strings, use_alias
+from pygmt.helpers import build_arg_list, fmt_docstring, kwargs_to_strings, use_alias
 
 
 @fmt_docstring
@@ -84,4 +84,4 @@ def basemap(self, **kwargs):
     """
     kwargs = self._preprocess(**kwargs)
     with Session() as lib:
-        lib.call_module(module="basemap", args=build_arg_string(kwargs))
+        lib.call_module(module="basemap", args=build_arg_list(kwargs))

pygmt/src/binstats.py

@@ -3,7 +3,7 @@
 """
 
 from pygmt.clib import Session
-from pygmt.helpers import build_arg_string, fmt_docstring, kwargs_to_strings, use_alias
+from pygmt.helpers import build_arg_list, fmt_docstring, kwargs_to_strings, use_alias
 
 
 @fmt_docstring
@@ -109,6 +109,6 @@ def binstats(data, outgrid: str | None = None, **kwargs):
         ):
             kwargs["G"] = voutgrd
             lib.call_module(
-                module="binstats", args=build_arg_string(kwargs, infile=vintbl)
+                module="binstats", args=build_arg_list(kwargs, infile=vintbl)
             )
             return lib.virtualfile_to_raster(vfname=voutgrd, outgrid=outgrid)

pygmt/src/blockm.py

@@ -8,7 +8,7 @@
 import pandas as pd
 from pygmt.clib import Session
 from pygmt.helpers import (
-    build_arg_string,
+    build_arg_list,
     fmt_docstring,
     kwargs_to_strings,
     use_alias,
@@ -61,7 +61,7 @@ def _blockm(
         ):
             lib.call_module(
                 module=block_method,
-                args=build_arg_string(kwargs, infile=vintbl, outfile=vouttbl),
+                args=build_arg_list(kwargs, infile=vintbl, outfile=vouttbl),
             )
             return lib.virtualfile_to_dataset(
                 vfname=vouttbl, output_type=output_type, column_names=column_names

pygmt/src/coast.py

@@ -6,7 +6,7 @@
 from pygmt.exceptions import GMTInvalidInput
 from pygmt.helpers import (
     args_in_kwargs,
-    build_arg_string,
+    build_arg_list,
     fmt_docstring,
     kwargs_to_strings,
     use_alias,
@@ -227,4 +227,4 @@ def coast(self, **kwargs):
             lakes, land, water, rivers, borders, dcw, Q, or shorelines"""
         )
     with Session() as lib:
-        lib.call_module(module="coast", args=build_arg_string(kwargs))
+        lib.call_module(module="coast", args=build_arg_list(kwargs))

pygmt/src/colorbar.py

@@ -3,7 +3,7 @@
 """
 
 from pygmt.clib import Session
-from pygmt.helpers import build_arg_string, fmt_docstring, kwargs_to_strings, use_alias
+from pygmt.helpers import build_arg_list, fmt_docstring, kwargs_to_strings, use_alias
 
 __doctest_skip__ = ["colorbar"]
 
@@ -146,4 +146,4 @@ def colorbar(self, **kwargs):
     """
     kwargs = self._preprocess(**kwargs)
     with Session() as lib:
-        lib.call_module(module="colorbar", args=build_arg_string(kwargs))
+        lib.call_module(module="colorbar", args=build_arg_list(kwargs))

pygmt/src/config.py

@@ -199,9 +199,10 @@ def __init__(self, **kwargs):
                     self.old_defaults[key] = lib.get_default(key)
 
         # call gmt set to change GMT defaults
-        arg_str = " ".join([f'{key}="{value}"' for key, value in kwargs.items()])
         with Session() as lib:
-            lib.call_module(module="set", args=arg_str)
+            lib.call_module(
+                module="set", args=[f"{key}={value}" for key, value in kwargs.items()]
+            )
 
     def __enter__(self):
         """
@@ -213,8 +214,8 @@ def __exit__(self, exc_type, exc_value, traceback):
         """
         Revert GMT configurations to initial values.
         """
-        arg_str = " ".join(
-            [f'{key}="{value}"' for key, value in self.old_defaults.items()]
-        )
         with Session() as lib:
-            lib.call_module(module="set", args=arg_str)
+            lib.call_module(
+                module="set",
+                args=[f"{key}={value}" for key, value in self.old_defaults.items()],
+            )

pygmt/src/contour.py

@@ -3,7 +3,7 @@
 """
 
 from pygmt.clib import Session
-from pygmt.helpers import build_arg_string, fmt_docstring, kwargs_to_strings, use_alias
+from pygmt.helpers import build_arg_list, fmt_docstring, kwargs_to_strings, use_alias
 
 
 @fmt_docstring
@@ -119,5 +119,5 @@ def contour(self, data=None, x=None, y=None, z=None, **kwargs):
             check_kind="vector", data=data, x=x, y=y, z=z, required_z=True
         ) as vintbl:
             lib.call_module(
-                module="contour", args=build_arg_string(kwargs, infile=vintbl)
+                module="contour", args=build_arg_list(kwargs, infile=vintbl)
             )