More Pythonic interface for the x2sys package

[seisman]

Description of the desired feature

The x2sys package contains the following modules for cross-over analysis:

• x2sys_binlist
• x2sys_cross
• x2sys_datalist
• x2sys_get
• x2sys_init
• x2sys_list
• x2sys_merge
• x2sys_put
• x2sys_report
• x2sys_solve

Currently, PyGMT provides wrappers for x2sys_init and x2sys_cross as separate functions under the pygmt namespace.

Perhaps it's more Pythonic to wrap all the modules in a class instead. The syntax would be same thing like:

from pygmt import X2SYS

x2sys = X2SYS(...)   # Class __init__ function that wraps `x2sys_init`
x2sys.cross()  # Wraps `x2sys_cross`
x2sys.solve()  # Wraps `x2sys_solve`
...

Disclaimer: I've never used x2sys.

Are you willing to help implement and maintain this feature?

No

[weiji14]

It's been a while since I used x2sys, and I've only used x2sys_init and x2sys_cross really (so unsure of the other ones), but I don't think X2SYS holds much of an internal state (nor does it even support virtual files - GenericMappingTools/gmt#3717) to warrant using a class. x2sys_init will write a format definition file (*.fmt), and once that is in place, you could run x2sys_cross without calling x2sys_init again, as long as you set the X2SYS_HOME environment variable correctly. So at most, the class would store the X2SYS_HOME environment variable I suppose 🤷

[seisman]

So at most, the class would store the X2SYS_HOME environment variable I suppose 🤷

I see that most x2sys modules need the TAG setting. Perhaps the class can also store the TAG setting? Anyway, we need inputs from heave x2sys users before taking any actions.

[kshitijaucharmal]

Not a heavy x2sys user, but if it only needs to hold at the max 2 settings, then I agree with @weiji14 that it does not warrant having a class. Nevertheless, x2sys_datalist and x2sys_solve are useful and required in some cases, so I would like to see them implemented, as separate functions or within a class.
I would be willing to implement either if required.