Update package versions and simplify code

GioemaNocco · GioemaNocco · commit 430a6f8b7b26 · 2025-04-17T21:42:32.000+02:00
- Updated various NuGet package versions across multiple projects, including `Roslynator.Analyzers`, `Microsoft.AspNetCore.Authorization`, `MassTransit.RabbitMQ`, and others.
- Made properties nullable in several classes to allow for optional values.
- Simplified method signatures and variable declarations in the codebase.
- Added a new release note for version `7.2.4` in `README_NUGET.md`.
- Removed the `Polly` package from `Orders.WebApi.csproj`.
diff --git a/Directory.Build.props b/Directory.Build.props
@@ -26,7 +26,7 @@
     </PropertyGroup>
 
     <ItemGroup>
-        <PackageReference Include="Roslynator.Analyzers" Version="4.12.10">
+        <PackageReference Include="Roslynator.Analyzers" Version="4.13.1">
             <PrivateAssets>all</PrivateAssets>
             <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
         </PackageReference>
diff --git a/src/Genocs.Auth/Genocs.Auth.csproj b/src/Genocs.Auth/Genocs.Auth.csproj
@@ -26,7 +26,7 @@
     </ItemGroup>
 
     <ItemGroup Condition="'$(TargetFramework)' == 'net9.0'">
-        <PackageReference Include="Microsoft.AspNetCore.Authorization" Version="9.0.*" />
+        <PackageReference Include="Microsoft.AspNetCore.Authorization" Version="9.0.4" />
     </ItemGroup>
 
     <ItemGroup Condition="'$(TargetFramework)' == 'net8.0'">
diff --git a/src/Genocs.Core.Demo.HelloWorld/Genocs.Core.Demo.HelloWorld.csproj b/src/Genocs.Core.Demo.HelloWorld/Genocs.Core.Demo.HelloWorld.csproj
@@ -8,7 +8,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.AspNetCore.OpenApi" Version="9.0.0" />
+    <PackageReference Include="Microsoft.AspNetCore.OpenApi" Version="9.0.4" />
   </ItemGroup>
 
   <ItemGroup>
diff --git a/src/Genocs.Core.Demo.Infrastructure/Genocs.Core.Demo.Infrastructure.csproj b/src/Genocs.Core.Demo.Infrastructure/Genocs.Core.Demo.Infrastructure.csproj
@@ -7,8 +7,8 @@
     </PropertyGroup>
 
     <ItemGroup>
-      <PackageReference Include="Microsoft.Extensions.Configuration.Abstractions" Version="9.0.0" />
-      <PackageReference Include="System.IdentityModel.Tokens.Jwt" Version="8.0.1" />
+        <PackageReference Include="Microsoft.Extensions.Configuration.Abstractions" Version="9.0.4" />
+        <PackageReference Include="System.IdentityModel.Tokens.Jwt" Version="8.0.1" />
     </ItemGroup>
 
 </Project>
diff --git a/src/Genocs.Core.Demo.WebApi/Genocs.Core.Demo.WebApi.csproj b/src/Genocs.Core.Demo.WebApi/Genocs.Core.Demo.WebApi.csproj
@@ -32,7 +32,7 @@
     </ItemGroup>
 
     <ItemGroup>
-        <PackageReference Include="MassTransit.RabbitMQ" Version="8.3.4" />
+        <PackageReference Include="MassTransit.RabbitMQ" Version="8.4.0" />
         <PackageReference Include="Swashbuckle.AspNetCore" Version="7.2.0" />
     </ItemGroup>
 
diff --git a/src/Genocs.Core.Demo.Worker/Genocs.Core.Demo.Worker.csproj b/src/Genocs.Core.Demo.Worker/Genocs.Core.Demo.Worker.csproj
@@ -21,8 +21,8 @@
 
     <ItemGroup>
         <PackageReference Include="MassTransit.Extensions.DependencyInjection" Version="7.3.1" />
-        <PackageReference Include="MassTransit.RabbitMQ" Version="8.3.4" />
-        <PackageReference Include="Microsoft.VisualStudio.Azure.Containers.Tools.Targets" Version="1.21.0" />
+        <PackageReference Include="MassTransit.RabbitMQ" Version="8.4.0" />
+        <PackageReference Include="Microsoft.VisualStudio.Azure.Containers.Tools.Targets" Version="1.21.2" />
         <PackageReference Include="Serilog.Sinks.ApplicationInsights" Version="4.0.0" />
     </ItemGroup>
 
diff --git a/src/Genocs.Core.UnitTests/Genocs.Core.UnitTests.csproj b/src/Genocs.Core.UnitTests/Genocs.Core.UnitTests.csproj
@@ -9,11 +9,11 @@
     <ItemGroup>
         <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.12.0" />
         <PackageReference Include="xunit" Version="2.9.3" />
-        <PackageReference Include="xunit.runner.visualstudio" Version="3.0.1">
+        <PackageReference Include="xunit.runner.visualstudio" Version="3.0.2">
             <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
             <PrivateAssets>all</PrivateAssets>
         </PackageReference>
-        <PackageReference Include="coverlet.collector" Version="6.0.2">
+        <PackageReference Include="coverlet.collector" Version="6.0.4">
             <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
             <PrivateAssets>all</PrivateAssets>
         </PackageReference>
diff --git a/src/Genocs.Discovery.Consul/Extensions.cs b/src/Genocs.Discovery.Consul/Extensions.cs
@@ -129,7 +129,7 @@ public static void AddConsulHttpClient(this IGenocsBuilder builder, string clien
             return registration;
         }
 
-        var pingEndpoint = string.IsNullOrWhiteSpace(options.PingEndpoint) ? string.Empty :
+        string pingEndpoint = string.IsNullOrWhiteSpace(options.PingEndpoint) ? string.Empty :
             options.PingEndpoint.StartsWith("/") ? options.PingEndpoint : $"/{options.PingEndpoint}";
         if (pingEndpoint.EndsWith("/"))
         {
diff --git a/src/Genocs.Discovery.Consul/MessageHandlers/ConsulServiceDiscoveryMessageHandler.cs b/src/Genocs.Discovery.Consul/MessageHandlers/ConsulServiceDiscoveryMessageHandler.cs
@@ -31,9 +31,7 @@ public ConsulServiceDiscoveryMessageHandler(
         }
     }
 
-    protected override async Task<HttpResponseMessage> SendAsync(
-                                                                    HttpRequestMessage request,
-                                                                    CancellationToken cancellationToken)
+    protected override async Task<HttpResponseMessage> SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
     {
         var uri = GetUri(request);
         string serviceName = string.IsNullOrWhiteSpace(_serviceName) ? uri.Host : _serviceName;
diff --git a/src/Genocs.Discovery.Consul/Models/Connect.cs b/src/Genocs.Discovery.Consul/Models/Connect.cs
@@ -5,5 +5,5 @@ namespace Genocs.Discovery.Consul.Models;
 public class Connect
 {
     [JsonPropertyName("sidecar_service")]
-    public SidecarService SidecarService { get; set; }
+    public SidecarService? SidecarService { get; set; }
 }
diff --git a/src/Genocs.Discovery.Consul/Models/ServiceAgent.cs b/src/Genocs.Discovery.Consul/Models/ServiceAgent.cs
@@ -5,12 +5,12 @@ namespace Genocs.Discovery.Consul.Models;
 public class ServiceAgent
 {
     [JsonPropertyName("ID")]
-    public string Id { get; set; }
-    public string Service { get; set; }
-    public List<string> Tags { get; set; }
-    public IDictionary<string, string> Meta { get; set; }
+    public string? Id { get; set; }
+    public string? Service { get; set; }
+    public List<string>? Tags { get; set; }
+    public IDictionary<string, string>? Meta { get; set; }
     public int Port { get; set; }
-    public string Address { get; set; }
+    public string? Address { get; set; }
     public bool EnableTagOverride { get; set; }
-    public Weights Weights { get; set; }
+    public Weights? Weights { get; set; }
 }
diff --git a/src/Genocs.Discovery.Consul/Models/ServiceCheck.cs b/src/Genocs.Discovery.Consul/Models/ServiceCheck.cs
@@ -2,9 +2,9 @@ namespace Genocs.Discovery.Consul.Models;
 
 public class ServiceCheck
 {
-    public string DeregisterCriticalServiceAfter { get; set; }
-    public List<string> Args { get; set; }
-    public string Http { get; set; }
-    public string Interval { get; set; }
-    public string Ttl { get; set; }
+    public string? DeregisterCriticalServiceAfter { get; set; }
+    public List<string>? Args { get; set; }
+    public string? Http { get; set; }
+    public string? Interval { get; set; }
+    public string? Ttl { get; set; }
 }
diff --git a/src/Genocs.Discovery.Consul/Models/SidecarService.cs b/src/Genocs.Discovery.Consul/Models/SidecarService.cs
@@ -2,5 +2,5 @@ namespace Genocs.Discovery.Consul.Models;
 
 public class SidecarService
 {
-    public Proxy Proxy { get; set; }
+    public Proxy? Proxy { get; set; }
 }
diff --git a/src/Genocs.HTTP/Genocs.HTTP.csproj b/src/Genocs.HTTP/Genocs.HTTP.csproj
@@ -27,7 +27,7 @@
 
     <ItemGroup>
         <PackageReference Include="Microsoft.Extensions.Http" Version="9.0.*" />
-        <PackageReference Include="Polly" Version="8.5.0" />
+        <PackageReference Include="Polly" Version="8.5.2" />
     </ItemGroup>
 
 </Project>
diff --git a/src/Genocs.Logging/Genocs.Logging.csproj b/src/Genocs.Logging/Genocs.Logging.csproj
@@ -26,7 +26,7 @@
     </ItemGroup>
 
     <ItemGroup>
-        <PackageReference Include="Microsoft.ApplicationInsights" Version="2.22.0" />
+        <PackageReference Include="Microsoft.ApplicationInsights" Version="2.23.0" />
         <PackageReference Include="Serilog.AspNetCore" Version="8.0.3" />
         <PackageReference Include="Serilog.Enrichers.Environment" Version="3.0.1" />
         <PackageReference Include="Serilog.Enrichers.Process" Version="3.0.0" />
@@ -43,7 +43,7 @@
     </ItemGroup>
 
     <ItemGroup>
-        <PackageReference Include="SmartFormat.NET" Version="3.5.3" />
+        <PackageReference Include="SmartFormat.NET" Version="3.6.0" />
     </ItemGroup>
 
 </Project>
diff --git a/src/Genocs.MessageBrokers.RabbitMQ/Genocs.MessageBrokers.RabbitMQ.csproj b/src/Genocs.MessageBrokers.RabbitMQ/Genocs.MessageBrokers.RabbitMQ.csproj
@@ -27,7 +27,7 @@
 
     <ItemGroup>
         <PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
-        <PackageReference Include="Polly" Version="8.5.0" />
+        <PackageReference Include="Polly" Version="8.5.2" />
         <PackageReference Include="RabbitMQ.Client" Version="7.0.0" />
     </ItemGroup>
 
diff --git a/src/Genocs.Persistence.MongoDb.UnitTests/Genocs.Persistence.MongoDB.UnitTests.csproj b/src/Genocs.Persistence.MongoDb.UnitTests/Genocs.Persistence.MongoDB.UnitTests.csproj
@@ -13,11 +13,11 @@
         <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.12.0" />
         <PackageReference Include="Moq" Version="4.20.72" />
         <PackageReference Include="xunit" Version="2.9.3" />
-        <PackageReference Include="xunit.runner.visualstudio" Version="3.0.1">
+        <PackageReference Include="xunit.runner.visualstudio" Version="3.0.2">
             <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
             <PrivateAssets>all</PrivateAssets>
         </PackageReference>
-        <PackageReference Include="coverlet.collector" Version="6.0.2">
+        <PackageReference Include="coverlet.collector" Version="6.0.4">
             <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
             <PrivateAssets>all</PrivateAssets>
         </PackageReference>
diff --git a/src/Genocs.Persistence.MongoDb/Genocs.Persistence.MongoDb.csproj b/src/Genocs.Persistence.MongoDb/Genocs.Persistence.MongoDb.csproj
@@ -26,7 +26,7 @@
     </ItemGroup>
 
     <ItemGroup>
-        <PackageReference Include="MongoDB.Driver" Version="3.1.0" />
+        <PackageReference Include="MongoDB.Driver" Version="3.3.0" />
         <PackageReference Include="MongoDB.Driver.Core.Extensions.DiagnosticSources" Version="2.0.0" />
     </ItemGroup>
 
diff --git a/src/Genocs.QueryBuilder.UnitTests/Genocs.QueryBuilder.UnitTests.csproj b/src/Genocs.QueryBuilder.UnitTests/Genocs.QueryBuilder.UnitTests.csproj
@@ -15,11 +15,11 @@
         <PackageReference Include="Moq" Version="4.20.72" />
         <PackageReference Include="System.Linq.Dynamic.Core" Version="1.4.9" />
         <PackageReference Include="xunit" Version="2.9.3" />
-        <PackageReference Include="xunit.runner.visualstudio" Version="3.0.1">
+        <PackageReference Include="xunit.runner.visualstudio" Version="3.0.2">
             <PrivateAssets>all</PrivateAssets>
             <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
         </PackageReference>
-        <PackageReference Include="coverlet.collector" Version="6.0.2">
+        <PackageReference Include="coverlet.collector" Version="6.0.4">
             <PrivateAssets>all</PrivateAssets>
             <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
         </PackageReference>
diff --git a/src/Genocs.Secrets.AzureKeyVault/Extensions.cs b/src/Genocs.Secrets.AzureKeyVault/Extensions.cs
@@ -30,6 +30,7 @@ public static IHostBuilder UseAzureKeyVault(
                 {
                     sectionName = AzureKeyVaultOptions.Position;
                 }
+
                 var config = cfg.Build();
                 var settings = config.GetOptions<AzureKeyVaultOptions>(sectionName);
                 if (!settings.Enabled)
diff --git a/src/Genocs.Secrets.AzureKeyVault/Genocs.Secrets.AzureKeyVault.csproj b/src/Genocs.Secrets.AzureKeyVault/Genocs.Secrets.AzureKeyVault.csproj
@@ -26,8 +26,8 @@
     </ItemGroup>
 
     <ItemGroup>
-        <PackageReference Include="Azure.Extensions.AspNetCore.Configuration.Secrets" Version="1.3.2" />
-        <PackageReference Include="Azure.Identity" Version="1.13.1" />
+        <PackageReference Include="Azure.Extensions.AspNetCore.Configuration.Secrets" Version="1.4.0" />
+        <PackageReference Include="Azure.Identity" Version="1.13.2" />
     </ItemGroup>
 
 </Project>
diff --git a/src/Genocs.Secrets.AzureKeyVault/README_NUGET.md b/src/Genocs.Secrets.AzureKeyVault/README_NUGET.md
@@ -15,4 +15,4 @@ Please check the GitHub repository getting more info.
 
 ## Release notes
 
-### [2024-06-12] 5.0.6
+### [2025-04-17] 7.2.4 Fix Key Vault Setup
diff --git a/src/Genocs.ServiceBusAzure.UnitTests/Genocs.ServiceBusAzure.UnitTests.csproj b/src/Genocs.ServiceBusAzure.UnitTests/Genocs.ServiceBusAzure.UnitTests.csproj
@@ -9,11 +9,11 @@
     <ItemGroup>
         <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.12.0" />
         <PackageReference Include="xunit" Version="2.9.3" />
-        <PackageReference Include="xunit.runner.visualstudio" Version="3.0.1">
+        <PackageReference Include="xunit.runner.visualstudio" Version="3.0.2">
             <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
             <PrivateAssets>all</PrivateAssets>
         </PackageReference>
-        <PackageReference Include="coverlet.collector" Version="6.0.2">
+        <PackageReference Include="coverlet.collector" Version="6.0.4">
             <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
             <PrivateAssets>all</PrivateAssets>
         </PackageReference>
diff --git a/src/apps/orders/Orders.WebApi/Orders.WebApi.csproj b/src/apps/orders/Orders.WebApi/Orders.WebApi.csproj
@@ -49,10 +49,6 @@
         <PackageReference Include="Genocs.WebApi" Version="7.2.3" />
     </ItemGroup>
 
-    <ItemGroup>
-        <PackageReference Include="Polly" Version="8.5.0" />
-    </ItemGroup>
-
     <ItemGroup>
         <Folder Include="logs\" />
     </ItemGroup>

Original file line number	Diff line number	Diff line change
`@@ -129,7 +129,7 @@ public static void AddConsulHttpClient(this IGenocsBuilder builder, string clien`
`129`	`129`	`return registration;`
`130`	`130`	`}`
`131`	`131`
`132`		`- var pingEndpoint = string.IsNullOrWhiteSpace(options.PingEndpoint) ? string.Empty :`
	`132`	`+ string pingEndpoint = string.IsNullOrWhiteSpace(options.PingEndpoint) ? string.Empty :`
`133`	`133`	`options.PingEndpoint.StartsWith("/") ? options.PingEndpoint : $"/{options.PingEndpoint}";`
`134`	`134`	`if (pingEndpoint.EndsWith("/"))`
`135`	`135`	`{`
Original file line number	Diff line number	Diff line change
`@@ -31,9 +31,7 @@ public ConsulServiceDiscoveryMessageHandler(`
`31`	`31`	`}`
`32`	`32`	`}`
`33`	`33`
`34`		`- protected override async Task<HttpResponseMessage> SendAsync(`
`35`		`- HttpRequestMessage request,`
`36`		`- CancellationToken cancellationToken)`
	`34`	`+ protected override async Task<HttpResponseMessage> SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)`
`37`	`35`	`{`
`38`	`36`	`var uri = GetUri(request);`
`39`	`37`	`string serviceName = string.IsNullOrWhiteSpace(_serviceName) ? uri.Host : _serviceName;`
Original file line number	Diff line number	Diff line change
`@@ -5,5 +5,5 @@ namespace Genocs.Discovery.Consul.Models;`
`5`	`5`	`public class Connect`
`6`	`6`	`{`
`7`	`7`	`[JsonPropertyName("sidecar_service")]`
`8`		`- public SidecarService SidecarService { get; set; }`
	`8`	`+ public SidecarService? SidecarService { get; set; }`
`9`	`9`	`}`