Make properties nullable and improve code readability

- JwtOptions: Remove default values from ValidateAudience and ValidateIssuer, making them nullable.
- AuthorizedController: Include Authorization header in PostSubmitDemoCommand response.
- VaultOptions: Make Templates and nested PkiOptions properties nullable.
- Extensions: Reformat method signatures, make string variables nullable, rename tuple elements in SetSecrets, and use PascalCase for tuple elements in GetClientAndSettings.
- Documentation: Add period in ServiceCollectionExtensions comment and clarify return value in AddOpenTelemetry method.

Author: giovanninocco

src/Genocs.Auth/Configurations/JwtOptions.cs

@@ -38,8 +38,8 @@ public class JwtOptions
     public string? ValidIssuer { get; set; }
     public IEnumerable<string>? ValidIssuers { get; set; }
     public bool ValidateActor { get; set; }
-    public bool ValidateAudience { get; set; } = true;
-    public bool ValidateIssuer { get; set; } = true;
+    public bool ValidateAudience { get; set; }
+    public bool ValidateIssuer { get; set; }
     public bool ValidateLifetime { get; set; } = true;
     public bool ValidateTokenReplay { get; set; }
     public bool ValidateIssuerSigningKey { get; set; }

src/Genocs.Core.Demo.WebApi/Controllers/AuthorizedController.cs

@@ -21,6 +21,6 @@ public AuthorizedController(ILogger<AuthorizedController> logger)
     [ProducesResponseType(typeof(string), StatusCodes.Status200OK)]
     public async Task<IActionResult> PostSubmitDemoCommand()
     {
-        return await Task.Run(() => Ok("Done"));
+        return await Task.Run(() => Ok($"Done! Authorization is: {HttpContext.Request.Headers["Authorization"]}"));
     }
 }

src/Genocs.Persistence.MongoDb/Extensions/ServiceCollectionExtensions.cs

@@ -6,7 +6,7 @@
 namespace Genocs.Persistence.MongoDb.Extensions;
 
 /// <summary>
-/// Service Collection Extension for MongoDb Repository setup
+/// Service Collection Extension for MongoDb Repository setup.
 /// </summary>
 public static class ServiceCollectionExtensions
 {

src/Genocs.Secrets.Vault/Configurations/VaultSettings.cs

@@ -34,23 +34,23 @@ public class LeaseOptions
         public string? RoleName { get; set; }
         public string? MountPoint { get; set; }
         public bool AutoRenewal { get; set; }
-        public IDictionary<string, string> Templates { get; set; }
+        public IDictionary<string, string>? Templates { get; set; }
     }
 
     public class PkiOptions
     {
         public bool Enabled { get; set; }
-        public string RoleName { get; set; }
-        public string MountPoint { get; set; }
-        public string CertificateFormat { get; set; }
-        public string PrivateKeyFormat { get; set; }
-        public string CommonName { get; set; }
-        public string TTL { get; set; }
-        public string SubjectAlternativeNames { get; set; }
-        public string OtherSubjectAlternativeNames { get; set; }
+        public string? RoleName { get; set; }
+        public string? MountPoint { get; set; }
+        public string? CertificateFormat { get; set; }
+        public string? PrivateKeyFormat { get; set; }
+        public string? CommonName { get; set; }
+        public string? TTL { get; set; }
+        public string? SubjectAlternativeNames { get; set; }
+        public string? OtherSubjectAlternativeNames { get; set; }
         public bool ExcludeCommonNameFromSubjectAlternativeNames { get; set; }
-        public string IPSubjectAlternativeNames { get; set; }
-        public string URISubjectAlternativeNames { get; set; }
+        public string? IPSubjectAlternativeNames { get; set; }
+        public string? URISubjectAlternativeNames { get; set; }
         public bool ImportPrivateKey { get; set; }
     }
 }

src/Genocs.Secrets.Vault/Extensions.cs

@@ -222,43 +222,50 @@ private static async Task SetActiveDirectorySecretsAsync(
         }, credentials.LeaseId, credentials.LeaseDurationSeconds, credentials.Renewable));
     }
 
-    private static async Task SetAzureSecretsAsync(string key, IVaultClient client,
-        VaultOptions.LeaseOptions options,
-        IDictionary<string, string> configuration)
+    private static async Task SetAzureSecretsAsync(
+                                                    string key,
+                                                    IVaultClient client,
+                                                    VaultOptions.LeaseOptions options,
+                                                    IDictionary<string, string> configuration)
     {
         const string name = SecretsEngineMountPoints.Defaults.Azure;
-        var mountPoint = string.IsNullOrWhiteSpace(options.MountPoint) ? name : options.MountPoint;
-        var credentials =
-            await client.V1.Secrets.Azure.GetCredentialsAsync(options.RoleName, mountPoint);
+        string? mountPoint = string.IsNullOrWhiteSpace(options.MountPoint) ? name : options.MountPoint;
+
+        var credentials = await client.V1.Secrets.Azure.GetCredentialsAsync(options.RoleName, mountPoint);
+
         SetSecrets(key, options, configuration, name, () => (credentials, new Dictionary<string, string>
         {
             ["clientId"] = credentials.Data.ClientId,
             ["clientSecret"] = credentials.Data.ClientSecret
         }, credentials.LeaseId, credentials.LeaseDurationSeconds, credentials.Renewable));
     }
 
-    private static async Task SetConsulSecretsAsync(string key, IVaultClient client,
-        VaultOptions.LeaseOptions options,
-        IDictionary<string, string> configuration)
+    private static async Task SetConsulSecretsAsync(
+                                                    string key,
+                                                    IVaultClient client,
+                                                    VaultOptions.LeaseOptions options,
+                                                    IDictionary<string, string> configuration)
     {
         const string name = SecretsEngineMountPoints.Defaults.Consul;
-        var mountPoint = string.IsNullOrWhiteSpace(options.MountPoint) ? name : options.MountPoint;
-        var credentials =
-            await client.V1.Secrets.Consul.GetCredentialsAsync(options.RoleName, mountPoint);
+        string? mountPoint = string.IsNullOrWhiteSpace(options.MountPoint) ? name : options.MountPoint;
+        var credentials = await client.V1.Secrets.Consul.GetCredentialsAsync(options.RoleName, mountPoint);
+
         SetSecrets(key, options, configuration, name, () => (credentials, new Dictionary<string, string>
         {
             ["token"] = credentials.Data.Token
         }, credentials.LeaseId, credentials.LeaseDurationSeconds, credentials.Renewable));
     }
 
-    private static async Task SetDatabaseSecretsAsync(string key, IVaultClient client,
-        VaultOptions.LeaseOptions options,
-        IDictionary<string, string> configuration)
+    private static async Task SetDatabaseSecretsAsync(
+                                                        string key,
+                                                        IVaultClient client,
+                                                        VaultOptions.LeaseOptions options,
+                                                        IDictionary<string, string> configuration)
     {
         const string name = SecretsEngineMountPoints.Defaults.Database;
-        var mountPoint = string.IsNullOrWhiteSpace(options.MountPoint) ? name : options.MountPoint;
-        var credentials =
-            await client.V1.Secrets.Database.GetCredentialsAsync(options.RoleName, mountPoint);
+        string? mountPoint = string.IsNullOrWhiteSpace(options.MountPoint) ? name : options.MountPoint;
+        var credentials = await client.V1.Secrets.Database.GetCredentialsAsync(options.RoleName, mountPoint);
+
         SetSecrets(key, options, configuration, name, () => (credentials, new Dictionary<string, string>
         {
             ["username"] = credentials.Data.Username,
@@ -273,24 +280,29 @@ private static async Task SetPkiSecretsAsync(IVaultClient client, VaultOptions o
         CertificatesService.Set(options.Pki.RoleName, certificate);
     }
 
-    private static async Task SetRabbitMqSecretsAsync(string key, IVaultClient client,
-        VaultOptions.LeaseOptions options,
-        IDictionary<string, string> configuration)
+    private static async Task SetRabbitMqSecretsAsync(
+                                                        string key,
+                                                        IVaultClient client,
+                                                        VaultOptions.LeaseOptions options,
+                                                        IDictionary<string, string> configuration)
     {
         const string name = SecretsEngineMountPoints.Defaults.RabbitMQ;
-        var mountPoint = string.IsNullOrWhiteSpace(options.MountPoint) ? name : options.MountPoint;
-        var credentials =
-            await client.V1.Secrets.RabbitMQ.GetCredentialsAsync(options.RoleName, mountPoint);
+        string? mountPoint = string.IsNullOrWhiteSpace(options.MountPoint) ? name : options.MountPoint;
+        var credentials = await client.V1.Secrets.RabbitMQ.GetCredentialsAsync(options.RoleName, mountPoint);
+
         SetSecrets(key, options, configuration, name, () => (credentials, new Dictionary<string, string>
         {
             ["username"] = credentials.Data.Username,
             ["password"] = credentials.Data.Password
         }, credentials.LeaseId, credentials.LeaseDurationSeconds, credentials.Renewable));
     }
 
-    private static void SetSecrets(string key, VaultOptions.LeaseOptions options,
-        IDictionary<string, string> configuration, string name,
-        Func<(object, Dictionary<string, string>, string, int, bool)> lease)
+    private static void SetSecrets(
+                                    string key,
+                                    VaultOptions.LeaseOptions options,
+                                    IDictionary<string, string> configuration,
+                                    string name,
+                                    Func<(object Credentials, Dictionary<string, string> Values, string LeaseId, int Duration, bool Renewable)> lease)
     {
         var createdAt = DateTime.UtcNow;
         var (credentials, values, leaseId, duration, renewable) = lease();
@@ -299,7 +311,7 @@ private static void SetSecrets(string key, VaultOptions.LeaseOptions options,
         LeaseService.Set(key, leaseData);
     }
 
-    private static (IVaultClient client, VaultClientSettings settings) GetClientAndSettings(VaultOptions options)
+    private static (IVaultClient Client, VaultClientSettings Settings) GetClientAndSettings(VaultOptions options)
     {
         var settings = new VaultClientSettings(options.Url, GetAuthMethod(options));
         var client = new VaultClient(settings);

src/Genocs.Tracing/Extensions.cs

@@ -24,7 +24,7 @@ public static class Extensions
     /// Custom settings for OpenTelemetry.
     /// </summary>
     /// <param name="builder">The Genocs builder.</param>
-    /// <returns>The builder.</returns>
+    /// <returns>The Genocs builder you can use for chain.</returns>
     public static IGenocsBuilder AddOpenTelemetry(this IGenocsBuilder builder)
     {