Refactor interfaces, update Azure Key Vault options, and improve code readability

Author: giovanninocco

README.md

@@ -82,6 +82,13 @@ docker compose -f ./infrastructure-security.yml --env-file ./.env --project-name
 # Use this file only in case you want to setup sqlserver database (no need if you use postgres)
 docker compose -f ./infrastructure-sqlserver.yml --env-file ./.env --project-name genocs up -d
 
+# Use this file only in case you want to setup mySql database (no need if you use postgres)
+docker compose -f ./infrastructure-mysql.yml --env-file ./.env --project-name genocs up -d
+
+# Use this file only in case you want to setup oracle database (no need if you use postgres)
+# docker compose -f ./infrastructure-oracle.yml --env-file ./.env --project-name genocs up -d
+
+
 # Use this file only in case you want to setup elk stack
 docker compose -f ./infrastructure-elk.yml --env-file ./.env --project-name genocs up -d
 

containers/infrastructure-mysql.yml

@@ -0,0 +1,23 @@
+services:
+  mysqldb:
+    image: mysql
+    hostname: mysqldb
+    container_name: mysqldb
+    ports:
+      - 3306:3306
+
+    environment:
+      MYSQL_ROOT_PASSWORD: example
+    volumes:
+      - mysqlsystem:/var/lib/mysql
+    networks:
+      - genocs
+
+networks:
+  genocs:
+    name: genocs-network
+    external: true
+
+volumes:
+  mysqlsystem:
+    driver: local

src/Genocs.Auth/Genocs.Auth.csproj

@@ -53,8 +53,8 @@
     </ItemGroup>
 
     <ItemGroup Condition="'$(TargetFramework)' == 'net8.0'">
-        <PackageReference Include="Microsoft.AspNetCore.Authentication.JwtBearer" Version="8.0.*" />
-        <PackageReference Include="Microsoft.AspNetCore.Authorization" Version="8.0.*" />
+        <PackageReference Include="Microsoft.AspNetCore.Authentication.JwtBearer" Version="8.0.8" />
+        <PackageReference Include="Microsoft.AspNetCore.Authorization" Version="8.0.8" />
     </ItemGroup>
 
     <ItemGroup Condition="'$(TargetFramework)' == 'net7.0'">

src/Genocs.Core.Demo.WebApi/Controllers/ExternalApiController.cs

@@ -11,7 +11,9 @@ public class ExternalApiController : ControllerBase
     private readonly ILogger<DemoController> _logger;
     private readonly IExternalServiceClient _externalServiceClient;
 
-    public ExternalApiController(ILogger<DemoController> logger, IExternalServiceClient externalServiceClient)
+    public ExternalApiController(
+                                    ILogger<DemoController> logger,
+                                    IExternalServiceClient externalServiceClient)
     {
         _logger = logger ?? throw new ArgumentNullException(nameof(logger));
         _externalServiceClient = externalServiceClient ?? throw new ArgumentNullException(nameof(externalServiceClient));
@@ -24,6 +26,7 @@ public async Task<IActionResult> HomeAsync()
         => await Task.Run(() => Ok("done"));
 
     [HttpPost("")]
+    [Produces("application/json")]
     [ProducesResponseType(typeof(IssuingResponse), StatusCodes.Status200OK)]
     [Consumes(MediaTypeNames.Application.Json)]
     public async Task<IActionResult> PostIssueAsync(IssuingRequest request)

src/Genocs.Secrets.AzureKeyVault/Configurations/AzureKeyVaultOptions.cs

@@ -1,5 +1,3 @@
-using Azure.Core;
-
 namespace Genocs.Secrets.AzureKeyVault.Configurations;
 
 /// <summary>
@@ -26,7 +24,19 @@ public class AzureKeyVaultOptions
     /// The managed identity id.
     /// </summary>
     public string? ManagedIdentityId { get; set; }
+
+    /// <summary>
+    /// The client id. To be used with Certificate authentication.
+    /// </summary>
     public object? AzureADCertThumbprint { get; internal set; }
+
+    /// <summary>
+    /// The client id. To be used with Certificate authentication.
+    /// </summary>
     public string? AzureADApplicationId { get; internal set; }
+
+    /// <summary>
+    /// The Azure EntraID tenant Id. To be used with Certificate authentication.
+    /// </summary>
     public string? AzureADDirectoryId { get; internal set; }
 }

src/Genocs.Security/Genocs.Security.csproj

@@ -51,7 +51,7 @@
 
 
     <ItemGroup Condition="'$(TargetFramework)' == 'net8.0'">
-        <PackageReference Include="Microsoft.AspNetCore.Authentication.JwtBearer" Version="8.0.*" />
+        <PackageReference Include="Microsoft.AspNetCore.Authentication.JwtBearer" Version="8.0.8" />
     </ItemGroup>
 
     <ItemGroup Condition="'$(TargetFramework)' == 'net7.0'">

src/Genocs.WebApi.Security/Genocs.WebApi.Security.csproj

@@ -49,16 +49,16 @@
         <PackageReference Include="Genocs.Core" Version="6.0.*" />
     </ItemGroup>
 
-    <ItemGroup Condition="'$(TargetFramework)' == 'net6.0'">
-        <PackageReference Include="Microsoft.AspNetCore.Authentication.Certificate" Version="6.0.*" />
+    <ItemGroup Condition="'$(TargetFramework)' == 'net8.0'">
+        <PackageReference Include="Microsoft.AspNetCore.Authentication.Certificate" Version="8.0.8" />
     </ItemGroup>
 
     <ItemGroup Condition="'$(TargetFramework)' == 'net7.0'">
-        <PackageReference Include="Microsoft.AspNetCore.Authentication.Certificate" Version="7.0.*" />
+        <PackageReference Include="Microsoft.AspNetCore.Authentication.Certificate" Version="7.0.20" />
     </ItemGroup>
-
-    <ItemGroup Condition="'$(TargetFramework)' == 'net8.0'">
-        <PackageReference Include="Microsoft.AspNetCore.Authentication.Certificate" Version="8.0.*" />
+    
+    <ItemGroup Condition="'$(TargetFramework)' == 'net6.0'">
+        <PackageReference Include="Microsoft.AspNetCore.Authentication.Certificate" Version="6.0.33" />
     </ItemGroup>
 
 </Project>