Skip to content

Commit 211a8f8

Browse files
resolve merge conflict
2 parents f1b851e + 1032e78 commit 211a8f8

File tree

4 files changed

+17
-11
lines changed

4 files changed

+17
-11
lines changed

src/anyvlm/functions/get_caf.py

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,21 @@
33
from ga4gh.va_spec.base.core import CohortAlleleFrequencyStudyResult
44

55
from anyvlm.anyvar.base_client import BaseAnyVarClient
6+
from anyvlm.utils.types import (
7+
ChromosomeName,
8+
GenomicSequence,
9+
GrcAssemblyId,
10+
UscsAssemblyBuild,
11+
)
612

713

814
def get_caf(
915
anyvar_client: BaseAnyVarClient,
10-
assembly_id: str,
11-
reference_name: str,
16+
assembly_id: GrcAssemblyId | UscsAssemblyBuild,
17+
reference_name: ChromosomeName,
1218
start: int,
13-
reference_bases: str,
14-
alternate_bases: str,
19+
reference_bases: GenomicSequence,
20+
alternate_bases: GenomicSequence,
1521
) -> list[CohortAlleleFrequencyStudyResult]:
1622
"""Retrieve Cohort Allele Frequency data for all known variants matching provided search params
1723

src/anyvlm/restapi/vlm.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,12 +31,12 @@ def ingest_vcf(vcf_path: Path) -> None:
3131

3232

3333
@app.get(
34-
"/vlm-query",
35-
summary="Provides counts of occurrences of a single sequence variant, broken down by zygosity",
36-
description="Search for a single sequence variant and receive a count of its observed occurrences broken down by zygosity, in accordance with the Variant-Level Matching protocol",
34+
"/variant_counts",
35+
summary="Provides allele counts of a single sequence variant, broken down by zygosity",
36+
description="Search for a single sequence variant and receive allele counts by zygosity, in accordance with the Variant-Level Matching protocol",
3737
tags=[EndpointTag.SEARCH],
3838
)
39-
def vlm_query(
39+
def variant_counts(
4040
request: Request,
4141
assemblyId: Annotated[ # noqa: N803
4242
GrcAssemblyId | UscsAssemblyBuild,
@@ -53,7 +53,7 @@ def vlm_query(
5353
GenomicSequence, Query(..., description="Genomic bases ('T', 'AC', etc.)")
5454
],
5555
) -> VlmResponse:
56-
"""Accept a Variant-Level Matching network request and return a count of occurrences of a single sequence variant, broken down by zygosity.
56+
"""Accept a Variant-Level Matching network request and return allele counts by zygosity.
5757
5858
:param request: FastAPI `Request` object
5959
:param assemblyId: The genome reference assembly. Must be a GRC assembly identifier (e.g., "GRCh38) or a USCS assembly build (e.g., "hg38")

src/anyvlm/schemas/vlm.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ class ResponseField(BaseModel):
8585

8686

8787
class VlmResponse(BaseModel):
88-
"""Defines response structure for the vlm-query endpoint."""
88+
"""Define response structure for the variant_counts endpoint."""
8989

9090
beaconHandovers: list[BeaconHandover] = [BeaconHandover()]
9191
meta: Meta = Meta()

src/anyvlm/utils/types.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ def _normalize_chromosome_name(chromosome_name: str) -> str:
6868
if is_valid_chromosome_name(chromosome_name):
6969
return chromosome_name
7070
error_message = (
71-
"Invalid chromosome. Must be 1-22, 'X,' or 'Y,' with optional 'chr' prefix."
71+
"Invalid chromosome. Must be 1-22, 'X', or 'Y'; with optional 'chr' prefix."
7272
)
7373
raise ValueError(error_message)
7474

0 commit comments

Comments
 (0)