Skip to content

Commit 351de80

Browse files
committed
add comments for future changes
1 parent 13cc05f commit 351de80

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

src/biocommons/gks_conversion_tool/converter.py

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -92,14 +92,13 @@ def convert_gks_to_hl7_v2(statement: Statement) -> dict[str, Any]:
9292
raise ValueError(err)
9393

9494
# Get hgvs.g expression from the allele (e.g., 'NC_000007.13:g.140453136A>T')
95-
# use seqrepo here instead
9695
genomic_expression = _find_expression(allele, syntax="hgvs.g")
9796
hgvs_g = genomic_expression.value if genomic_expression else None
97+
# 524 - Genomic Reference Sequence ID
9898
chromosome_ref_seq, g_dot = _parse_hgvs_dot(hgvs_g)
9999

100100
# 511 - Allele start/end
101-
# to get genomic allele,
102-
# get the seqRef Id, give to seqrepo, convert to different namespace, check prefix
101+
# to get genomic allele, get the seqRef Id, give to seqrepo, convert to ncbi namespace, check prefix for NC or NG
103102
allele_start, allele_end = _get_location_interval(location)
104103

105104
# 513 - DNA Region
@@ -119,11 +118,10 @@ def convert_gks_to_hl7_v2(statement: Statement) -> dict[str, Any]:
119118
hgvs_p = protein_expression.value if protein_expression else None
120119
p_dot = _parse_hgvs_dot(hgvs_p)[1]
121120

122-
# 521 - Molecular Consequence - on hold until approved
121+
# 521 - Molecular Consequence - on hold until approved in va-spec
123122

124123
# 522 - Protein Reference Sequence
125-
126-
# 524 - Genomic Reference Sequence ID
124+
# get protein allele, get refGetAccession, use seqrepo to convert to ncbi namespace
127125

128126
# 526 - Reference Allele
129127

0 commit comments

Comments
 (0)