fix memory leaks in generated bindings (bytecodealliance#153)

* fix memory leaks in generated bindings

This addresses a couple of issues:

- We weren't freeing canonical ABI results after calling imports and then
  converting the results to Python values.

- We were using the PyO3 `Bound` APIs incorrectly in a few places, resulting in
  refcounts being incremented too many times.

While debugging the latter issue, I took the opportunity to update to the latest
PyO3 release, which required addressing the usual API breakage.  It also
required temporarily forking the repo to add a patch to disable `extern
"C-unwind"` in `pyo3_ffi` on `wasm32`.  We should be able to drop that fork once
we upgrade everything to Python 3.14.

Finally, I discovered
https://pyo3.rs/v0.25.0/features.html#pyo3_disable_reference_pool which
supposedly optimizes Rust<->Python transitions by disabling a feature we don't
rely on anyway, so I went ahead and enabled it.

Fixes bytecodealliance#152

Signed-off-by: Joel Dice <[email protected]>

* bump version to 0.17.1

Signed-off-by: Joel Dice <[email protected]>

* update python.rs to use new PyO3 API

Signed-off-by: Joel Dice <[email protected]>

---------

Signed-off-by: Joel Dice <[email protected]>

Author: dicej

Cargo.lock

@@ -1,6 +1,6 @@
 [package]
 name = "componentize-py"
-version = "0.17.0"
+version = "0.17.1"
 edition = "2021"
 exclude = ["cpython"]
 
@@ -22,7 +22,9 @@ wasmparser = "0.227.0"
 indexmap = "2.6.0"
 bincode = "1.3.3"
 heck = "0.5.0"
-pyo3 = { version = "0.22.5", features = [
+# TODO: switch back to upstream once we've updated to Python 3.14, at which
+# point the following patch will no longer be needed:
+pyo3 = { git = "https://github.com/dicej/pyo3", branch = "v0.25.0-no-wasm32-unwind", features = [
     "abi3-py39",
     "extension-module",
 ], optional = true }

Cargo.toml

@@ -124,9 +124,12 @@ fn package_all_the_things(out_dir: &Path) -> Result<()> {
         }
     }
 
-    cmd.env("RUSTFLAGS", "-C relocation-model=pic")
-        .env("CARGO_TARGET_DIR", out_dir)
-        .env("PYO3_CONFIG_FILE", out_dir.join("pyo3-config.txt"));
+    cmd.env(
+        "RUSTFLAGS",
+        "-C relocation-model=pic --cfg pyo3_disable_reference_pool",
+    )
+    .env("CARGO_TARGET_DIR", out_dir)
+    .env("PYO3_CONFIG_FILE", out_dir.join("pyo3-config.txt"));
 
     let status = cmd.status()?;
     assert!(status.success());

build.rs

@@ -10,15 +10,15 @@ run a Python-based component targetting the [wasi-cli] `command` world.
 ## Prerequisites
 
 * `Wasmtime` 26.0.0 or later
-* `componentize-py` 0.17.0
+* `componentize-py` 0.17.1
 
 Below, we use [Rust](https://rustup.rs/)'s `cargo` to install `Wasmtime`.  If
 you don't have `cargo`, you can download and install from
 https://github.com/bytecodealliance/wasmtime/releases/tag/v26.0.0.
 
 ```
 cargo install --version 26.0.0 wasmtime-cli
-pip install componentize-py==0.17.0
+pip install componentize-py==0.17.1
 ```
 
 ## Running the demo

examples/cli/README.md

@@ -10,15 +10,15 @@ run a Python-based component targetting the [wasi-http] `proxy` world.
 ## Prerequisites
 
 * `Wasmtime` 26.0.0 or later
-* `componentize-py` 0.17.0
+* `componentize-py` 0.17.1
 
 Below, we use [Rust](https://rustup.rs/)'s `cargo` to install `Wasmtime`.  If
 you don't have `cargo`, you can download and install from
 https://github.com/bytecodealliance/wasmtime/releases/tag/v26.0.0.
 
 ```
 cargo install --version 26.0.0 wasmtime-cli
-pip install componentize-py==0.17.0
+pip install componentize-py==0.17.1
 ```
 
 ## Running the demo

examples/http/README.md

@@ -11,7 +11,7 @@ within a guest component.
 ## Prerequisites
 
 * `wasmtime` 26.0.0 or later
-* `componentize-py` 0.17.0
+* `componentize-py` 0.17.1
 * `NumPy`, built for WASI
 
 Note that we use an unofficial build of NumPy since the upstream project does
@@ -23,7 +23,7 @@ https://github.com/bytecodealliance/wasmtime/releases/tag/v26.0.0.
 
 ```
 cargo install --version 26.0.0 wasmtime-cli
-pip install componentize-py==0.17.0
+pip install componentize-py==0.17.1
 curl -OL https://github.com/dicej/wasi-wheels/releases/download/v0.0.1/numpy-wasi.tar.gz
 tar xf numpy-wasi.tar.gz
 ```

examples/matrix-math/README.md

@@ -8,10 +8,10 @@ sandboxed Python code snippets from within a Python app.
 ## Prerequisites
 
 * `wasmtime-py` 25.0.0 or later
-* `componentize-py` 0.17.0
+* `componentize-py` 0.17.1
 
 ```
-pip install componentize-py==0.17.0 wasmtime==25.0.0
+pip install componentize-py==0.17.1 wasmtime==25.0.0
 ```
 
 ## Running the demo

examples/sandbox/README.md

@@ -11,15 +11,15 @@ making an outbound TCP request using `wasi-sockets`.
 ## Prerequisites
 
 * `Wasmtime` 26.0.0 or later
-* `componentize-py` 0.17.0
+* `componentize-py` 0.17.1
 
 Below, we use [Rust](https://rustup.rs/)'s `cargo` to install `Wasmtime`.  If
 you don't have `cargo`, you can download and install from
 https://github.com/bytecodealliance/wasmtime/releases/tag/v26.0.0.
 
 ```
 cargo install --version 26.0.0 wasmtime-cli
-pip install componentize-py==0.17.0
+pip install componentize-py==0.17.1
 ```
 
 ## Running the demo

examples/tcp/README.md

@@ -7,7 +7,7 @@ features = ["pyo3/extension-module"]
 
 [project]
 name = "componentize-py"
-version = "0.17.0"
+version = "0.17.1"
 description = "Tool to package Python applications as WebAssembly components"
 readme = "README.md"
 license = { file = "LICENSE" }

pyproject.toml

@@ -9,7 +9,9 @@ crate-type = ["staticlib"]
 [dependencies]
 anyhow = "1.0.91"
 once_cell = "1.20.2"
-pyo3 = { version = "0.22.5", features = ["abi3-py312", "num-bigint"] }
+# TODO: switch back to upstream once we've updated to Python 3.14, at which
+# point the following patch will no longer be needed:
+pyo3 = { git = "https://github.com/dicej/pyo3", branch = "v0.25.0-no-wasm32-unwind", features = ["abi3-py312", "num-bigint"] }
 componentize-py-shared = { path = "../shared" }
 num-bigint = "0.4.6"
 wit-bindgen = { version = "0.40.0", default-features = false, features = ["macros", "realloc"] }