Skip to content
This repository was archived by the owner on Apr 22, 2022. It is now read-only.

Commit c79c578

Browse files
committed
merged refactored config
2 parents b32fc5c + f589e03 commit c79c578

File tree

3 files changed

+156
-147
lines changed

3 files changed

+156
-147
lines changed

src/main/webapp/js/app.js

Lines changed: 40 additions & 74 deletions
Original file line numberDiff line numberDiff line change
@@ -58,52 +58,37 @@ app.config(function($routeSegmentProvider, $routeProvider)
5858
.segment('popup-limes', {
5959
templateUrl: 'js/workbench/linking-and-fusing/limes-result.html',
6060
resolve: {
61-
settings: function (Config) {
62-
return Config.read();
61+
settings: function (ConfigurationService) {
62+
return ConfigurationService.getSettings();
6363
}
6464
}
6565
})
6666

6767
.segment('popup-triplegeo', {
6868
templateUrl: 'js/workbench/extraction-and-loading/triplegeo-result.html',
6969
resolve: {
70-
settings: function (Config) {
71-
return Config.read();
70+
settings: function (ConfigurationService) {
71+
return ConfigurationService.getSettings();
7272
}
7373
}
7474
})
7575

7676
.segment('popup-geolift', {
7777
templateUrl: 'js/workbench/classification-and-enrichment/geolift-result.html',
7878
resolve: {
79-
settings: function (Config) {
80-
return Config.read();
79+
settings: function (ConfigurationService) {
80+
return ConfigurationService.getSettings();
8181
}
8282
}
8383
})
8484

8585
.segment('default', {
8686
templateUrl :'js/workbench/default.html',
8787
resolve: {
88-
init: function($q, Config, UsersService){
89-
console.log("init default");
90-
var defer = $q.defer();
91-
Config.initialize(defer);
92-
var promise = defer.promise;
93-
promise
94-
.then(function(){
95-
Config.read().then(function(){
96-
//why this function is required at this level?
97-
UsersService.readUserNamesEmails();
98-
//UsersService.readRoles();
99-
});
100-
});
101-
return promise;
88+
settings : function (ConfigurationService){
89+
return ConfigurationService.getSettings();
10290
}
103-
// },
104-
// settings: function (Config) {
105-
// return Config.read();
106-
// },
91+
// }
10792
// userInfo : function(UsersService) {
10893
// return UsersService.readUserNamesEmails();
10994
// }
@@ -140,22 +125,25 @@ app.config(function($routeSegmentProvider, $routeProvider)
140125
{
141126
templateUrl: 'js/settings/settings.html',
142127
resolve: {
143-
init: function($q, Config, UsersService){
144-
console.log("init settings");
145-
var defer = $q.defer();
146-
var promise = defer.promise;
147-
Config.initialize(defer);
148-
promise
149-
.then(function(){
150-
Config.read().then(function(){
151-
//why this function is required at this level?
152-
// UsersService.readRoles();
153-
// UsersService.readUserNamesEmails();
154-
});
155-
});
156-
157-
return promise;
128+
settings: function (ConfigurationService) {
129+
return ConfigurationService.getSettings();
158130
}
131+
// init: function($q, Config, UsersService){
132+
// console.log("init settings");
133+
// var defer = $q.defer();
134+
// var promise = defer.promise;
135+
// Config.initialize(defer);
136+
// promise
137+
// .then(function(){
138+
// Config.read().then(function(){
139+
// //why this function is required at this level?
140+
// // UsersService.readRoles();
141+
// // UsersService.readUserNamesEmails();
142+
// });
143+
// });
144+
145+
// return promise;
146+
// }
159147
}
160148
})
161149
.within()
@@ -172,30 +160,15 @@ app.config(function($routeSegmentProvider, $routeProvider)
172160
.segment('roles', {
173161
templateUrl: 'js/admin/roles.html',
174162
resolve: {
175-
init: function($q, Config, UsersService){
176-
console.log("init roles");
177-
var defer = $q.defer();
178-
var promise = defer.promise;
179-
Config.initialize(defer);
180-
promise
181-
.then(function(){
182-
Config.read().then(function(){
183-
UsersService.readRoles();
184-
UsersService.readUsers();
185-
});
186-
});
187-
return promise;
188-
}
189-
190-
// users: function(UsersService) {
191-
// return UsersService.readUsers();
192-
// },
193-
// roles: function(UsersService) {
194-
// return UsersService.readRoles();
195-
// },
196-
// settings: function (Config) {
197-
// return Config.read();
198-
// }
163+
settings: function (ConfigurationService) {
164+
return ConfigurationService.getSettings();
165+
},
166+
users: function(UsersService) {
167+
return UsersService.readUsers();
168+
},
169+
roles: function(UsersService) {
170+
return UsersService.readRoles();
171+
}
199172
}
200173
})
201174
.up()
@@ -209,17 +182,10 @@ app.config(function($routeSegmentProvider, $routeProvider)
209182
.segment('system-setup', {
210183
templateUrl: 'system-setup.html',
211184
resolve: {
212-
init: function($q, Config){
213-
console.log("init system-setup");
214-
var defer = $q.defer();
215-
var promise = defer.promise;
216-
Config.initialize(defer);
217-
promise
218-
.then(function(){
219-
console.log("config system-setup");
220-
Config.read();
221-
});
222-
return promise;
185+
roles: function (ConfigurationService, UsersService) {
186+
ConfigurationService.getSettings().then(function(settings){
187+
return UsersService.readRoles();
188+
});
223189
}
224190
}
225191
})

0 commit comments

Comments
 (0)