Skip to content
This repository was archived by the owner on Apr 22, 2022. It is now read-only.

Commit ef6f13c

Browse files
committed
add TODO in Jobs and cosmetics in dashboard
1 parent 98a4301 commit ef6f13c

File tree

3 files changed

+14
-8
lines changed

3 files changed

+14
-8
lines changed

src/main/java/workflow/rest/Jobs.java

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,11 +55,16 @@
5555
*
5656
* @author alejandragarciarojas
5757
*
58+
* Jobs that are registered in the Store but not in spring-batch-admin,
59+
* are automatically registered in the GET method
60+
*
5861
* TODO: add pagination to responses
5962
*
60-
* TODO: jobs are deleted each time the spring-batch-admin is
61-
* reinitialized, we need to register them again if the jobGraph has
62-
* them
63+
* TODO: use the ResourceNotFoundException to return more meaningful
64+
* errors
65+
*
66+
* TODO: define a job access control (the user may decide who can
67+
* read/write/execute jobs he has created)
6368
*
6469
*/
6570

src/main/resources/log4j.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,5 +9,5 @@ log4j.appender.stdout.layout.ConversionPattern=%d{yyyy-MM-dd HH:mm:ss} %-5p %c{1
99

1010
#log4j.logger.rdf=DEBUG
1111
#log4j.logger.rest=DEBUG
12-
log4j.logger.workflow=DEBUG
12+
#log4j.logger.workflow=DEBUG
1313
#log4j.logger.authentication.web=DEBUG

src/main/webapp/js/workbench/dashboard.html

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,10 @@ <h3 class="green bold">{{component.label}} </h3>
3838
<tr>
3939
<th>Name</th>
4040
<th>Description</th>
41+
<th>Created</th>
4142
<th>Execution Count</th>
42-
<th>Launchable</th>
43-
<th>Incrementable</th>
43+
<!-- <th>Launchable</th>
44+
<th>Incrementable</th> -->
4445
</tr>
4546
</thead>
4647
<tbody ng-repeat="job in jobs" ng-init="jobIndex = $index">
@@ -49,8 +50,8 @@ <h3 class="green bold">{{component.label}} </h3>
4950
<td>{{job.description}}</td>
5051
<td>{{job.cereated}}</td>
5152
<td>{{job.executionCount}}</td>
52-
<td>{{job.launchable}}</td>
53-
<td>{{job.incrementable}}</td>
53+
<!-- <td>{{job.launchable}}</td>
54+
<td>{{job.incrementable}}</td> -->
5455
</tr>
5556
<tr>
5657
<td colspan="6" class="hiddenRow" >

0 commit comments

Comments
 (0)