code refactor

Author: dsuren1

geonode_mapstore_client/client/js/plugins/ResourceDetails/ResourceDetails.jsx

@@ -252,7 +252,7 @@ function ResourceDetailsPanel({
             "type": "settings",
             "id": "settings",
             "labelId": "gnviewer.settings",
-            "disableIf": "{!context.canManageResourceSettings(state('gnResourceData')) && !context.canAccessPermissions(state('gnResourceData'))}",
+            "disableIf": "{!context.canManageResourceSettings(state('gnResourceData'))}",
             "items": [true]
         }
     ],

geonode_mapstore_client/client/js/utils/ResourceUtils.js

@@ -891,7 +891,7 @@ export const canManageResourceOptions = (resource) => {
 };
 
 export const canManageResourceSettings = (resource) => {
-    return canManageResourcePublishing(resource) && canManageResourceOptions(resource);
+    return !!(canManageResourcePublishing(resource) || canManageResourceOptions(resource));
 };
 
 export const canAccessPermissions = (resource) => {

geonode_mapstore_client/client/js/utils/__tests__/ResourceUtils-test.js

@@ -1055,23 +1055,16 @@ describe('Test Resource Utils', () => {
     });
     it('canManageResourceSettings', () => {
         expect(canManageResourceSettings({ perms: ['change_resourcebase'] })).toBeTruthy();
-
+        expect(canManageResourceSettings({ perms: ['change_resourcebase', 'view_resourcebase'] })).toBeTruthy();
         expect(canManageResourceSettings({ perms: ['approve_resourcebase', 'publish_resourcebase'] })).toBeTruthy();
         expect(canManageResourceSettings({ perms: ['approve_resourcebase', 'feature_resourcebase'] })).toBeTruthy();
-
-        expect(canManageResourceSettings({ perms: ['approve_resourcebase'] })).toBeFalsy();
-
-        expect(canManageResourceSettings({ perms: ['publish_resourcebase'] })).toBeFalsy();
-        expect(canManageResourceSettings({ perms: ['feature_resourcebase'] })).toBeFalsy();
+        expect(canManageResourceSettings({ perms: ['approve_resourcebase', 'change_resourcebase'] })).toBeTruthy();
+        expect(canManageResourceSettings({ perms: ['publish_resourcebase', 'change_resourcebase'] })).toBeTruthy();
 
         expect(canManageResourceSettings({ perms: ['view_resourcebase'] })).toBeFalsy();
-
         expect(canManageResourceSettings({ perms: [] })).toBeFalsy();
-
         expect(canManageResourceSettings({})).toBeFalsy();
-
         expect(canManageResourceSettings(undefined)).toBeFalsy();
-
         expect(canManageResourceSettings(null)).toBeFalsy();
     });
     it('canAccessPermissions', () => {