[Fixes #12996] Allow changing ownership of a single resource

Author: mattiagiupponi

geonode/people/api/views.py

@@ -148,8 +148,9 @@ def remove_from_group_manager(self, request, pk=None):
     def transfer_resources(self, request, pk=None):
         user = self.get_object()
         admin = get_user_model().objects.filter(is_superuser=True, is_staff=True).first()
-        target_user = request.data.get("owner")  # 1002
-        transfer_resource_subset = request.POST.getlist("resources", None)
+        target_user = request.data.get("newOwner")  # the new owner
+        previous_owner = request.data.get("currentOwner")  # the previous owner, usually it match the user
+        transfer_resource_subset = request.data.get("resources", None)
         target = None
         if target_user == "DEFAULT":
             if not admin:
@@ -161,25 +162,19 @@ def transfer_resources(self, request, pk=None):
         if target == user:
             return Response("Cannot reassign to self", status=400)
 
-        filter_payload = {}
+        # we need to filter by the previous owner id
+        filter_payload = dict(owner=previous_owner or user)
 
         if transfer_resource_subset:
             # transfer_resources
             filter_payload["pk__in"] = transfer_resource_subset
 
-        if not user.is_superuser:
-            """
-            if the request user is not admin, we will filter for the resources
-            thats owns
-            """
-            filter_payload["owner"] = user
-
         for instance in ResourceBase.objects.filter(**filter_payload).iterator():
             """
             We should reassing all the permissions to the new resource owner
             we can use the resource manager because inside it will automatically update
             the owner
             """
-            resource_manager.set_permissions(instance.uuid, instance, owner=target or user)
+            resource_manager.set_permissions(instance.uuid, instance, owner=target or user, permissions=None)
 
         return Response("Resources transfered successfully", status=200)