[Fixes #13625] Improved Validation error message on upsert (#13626)

Author: sijandh35

geonode/upload/handlers/common/vector.py

@@ -1205,7 +1205,9 @@ def _create_error_log(self, exec_obj, layers, errors):
                 asset_name=log_name,
             )
 
-        raise UpsertException("Some errors found, please check the error log attached")
+        raise UpsertException(
+            "Some validations failed. Errors are reported inside a CSV file that can be found inside the assets panel."
+        )
 
     def _validate_feature(self, data_chunk, model_instance, upsert_key, errors):
         # looping over the chunk data

geonode/upload/tests/unit/test_task.py

@@ -128,7 +128,7 @@ def test_import_resource_should_rase_exp_if_is_invalid(
                 action=ExecutionRequestAction.UPLOAD.value,
                 handler_module_path="geonode.upload.handlers.gpkg.handler.GPKGFileHandler",
             )
-        expected_msg = f"Invalid format type. Request: {str(exec_id)}"
+        expected_msg = "Invalid format type"
         self.assertEqual(expected_msg, str(_exc.exception.detail))
         ExecutionRequest.objects.filter(exec_id=str(exec_id)).delete()
 

geonode/upload/utils.py

@@ -118,9 +118,7 @@ class ImporterRequestAction(enum.Enum):
 
 def error_handler(exc, exec_id=None):
     err = f'{str(exc.detail if hasattr(exc, "detail") else exc.args[0])}'
-    if "Request:" in err:
-        return err
-    return f'{str(exc.detail if hasattr(exc, "detail") else exc.args[0])}. Request: {exec_id}'
+    return err
 
 
 class ImporterConcreteManager(GeoServerResourceManager):