[Fixes #12924] Cleanup legacy metadata editor and unused function

Author: mattiagiupponi

geonode/layers/views.py

@@ -47,7 +47,6 @@
 from geonode.base import register_event
 from geonode.utils import check_ogc_backend, resolve_object
 from geonode.geoserver.helpers import ogc_server_settings
-from geonode.security.registry import permissions_registry
 
 if check_ogc_backend(geoserver.BACKEND_PACKAGE):
     from geonode.geoserver.helpers import gs_catalog

geonode/security/tests.py

@@ -2439,30 +2439,6 @@ def setUp(self):
         self.assertSetEqual(set(resource_perm_specs["groups"][self.owner_group.group]), set(self.safe_perms))
         self.assertSetEqual(set(resource_perm_specs["groups"][self.resource_group.group]), set(self.safe_perms))
 
-    def test_permissions_on_approve_and_publish_changes(self):
-        # Group manager approves a resource
-        self.group_manager.set_password("group_manager")
-        self.group_manager.save()
-        self.assertTrue(self.client.login(username="group_manager", password="group_manager"))
-        response = self.client.post(self.url, data=self.data)
-        self.assertEqual(response.status_code, 200)
-        self.assertions_for_approved_or_published_is_true()
-
-        # Un approve resource
-        self.data.pop("resource-is_approved")
-        response = self.client.post(self.url, data=self.data)
-        self.assertEqual(response.status_code, 200)
-        self.assertions_for_approved_and_published_is_false()
-
-        # Admin publishes and approves resource
-        self.admin_approve_and_publish_resource()
-        self.assertions_for_approved_or_published_is_true()
-
-        # Admin Un approves and un publishes resource
-        self.admin_unapprove_and_unpublish_resource()
-        self.resource.refresh_from_db()
-        self.assertions_for_approved_and_published_is_false()
-
     def test_owner_is_group_manager(self):
         try:
             GroupMember.objects.get(group=self.owner_group, user=self.author).promote()