[Fixes #12713] Usage of permissions registry, fix tests

Author: mattiagiupponi

geonode/security/tests.py

@@ -2427,7 +2427,7 @@ def setUp(self):
             assign_perm(perm, self.member_with_perms, self.resource.get_self_resource())
 
         # Assert inital assignment of permissions to groups and users
-        resource_perm_specs = self.permissions_registry.get_perms(instance=self.resource, include_virtual=True)
+        resource_perm_specs = permissions_registry.get_perms(instance=self.resource, include_virtual=True)
         self.assertSetEqual(
             set(resource_perm_specs["users"][self.author]), set(self.owner_perms + self.edit_perms + self.dataset_perms)
         )
@@ -2476,7 +2476,7 @@ def test_owner_is_group_manager(self):
             # Admin publishes and approves the resource
             response = self.admin_approve_and_publish_resource()
             self.assertEqual(response.status_code, 200)
-            resource_perm_specs = self.permissions_registry.get_perms(instance=self.resource, include_virtual=True)
+            resource_perm_specs = permissions_registry.get_perms(instance=self.resource, include_virtual=True)
 
             # Once a resource has been published, the 'publish_resourcebase' permission should be removed anyway
             self.assertSetEqual(
@@ -2487,7 +2487,7 @@ def test_owner_is_group_manager(self):
             # Admin un-approves and un-publishes the resource
             response = self.admin_unapprove_and_unpublish_resource()
             self.assertEqual(response.status_code, 200)
-            resource_perm_specs = self.permissions_registry.get_perms(instance=self.resource, include_virtual=True)
+            resource_perm_specs = permissions_registry.get_perms(instance=self.resource, include_virtual=True)
 
             self.assertSetEqual(
                 set(resource_perm_specs["users"][self.author]),
@@ -2497,7 +2497,7 @@ def test_owner_is_group_manager(self):
             GroupMember.objects.get(group=self.owner_group, user=self.author).demote()
 
     def assertions_for_approved_or_published_is_true(self):
-        resource_perm_specs = self.permissions_registry.get_perms(instance=self.resource, include_virtual=True)
+        resource_perm_specs = permissions_registry.get_perms(instance=self.resource, include_virtual=True)
         self.assertSetEqual(set(resource_perm_specs["users"][self.author]), set(self.owner_perms))
         self.assertSetEqual(
             set(resource_perm_specs["users"][self.member_with_perms]), set(self.owner_perms + self.dataset_perms)
@@ -2514,7 +2514,7 @@ def assertions_for_approved_or_published_is_true(self):
         self.assertSetEqual(set(resource_perm_specs["groups"][self.resource_group.group]), set(self.safe_perms))
 
     def assertions_for_approved_and_published_is_false(self):
-        resource_perm_specs = self.permissions_registry.get_perms(instance=self.resource, include_virtual=True)
+        resource_perm_specs = permissions_registry.get_perms(instance=self.resource, include_virtual=True)
         self.assertSetEqual(
             set(resource_perm_specs["users"][self.author]), set(self.owner_perms + self.edit_perms + self.dataset_perms)
         )

geonode/security/utils.py

@@ -693,6 +693,7 @@ def set_group_member_permissions(user, group, role):
             to the resource
             """
             from geonode.security.registry import permissions_registry
+
             # Fetching all the resources belonging to Group "group"; i.e. assgined to "group" metadata
             queryset = get_objects_for_user(
                 user, ["base.view_resourcebase", "base.change_resourcebase"], any_perm=True