Improve GeoNode modularization

Author: mattiagiupponi

geonode/base/models.py

@@ -957,9 +957,18 @@ def raw_abstract(self):
     def can_be_downloaded(self):
         return self.subtype in ["vector", "raster", "vector_time"]
 
+    @property
     def can_have_wfs_links(self):
         return self.subtype == "vector"
-    
+
+    @property
+    def can_have_wps_links(self):
+        return self.subtype in {"vector", "tileStore", "remote", "wmsStore", "vector_time"}
+
+    @property
+    def can_have_style(self):
+        return self.subtype not in ["tileStore", "remote"]
+
     @property
     def raw_purpose(self):
         return self._remove_html_tags(self.purpose)
@@ -1517,7 +1526,7 @@ def get_legend_url(self, style_name=None):
     def get_ows_url(self):
         """Return URL for OGC WMS server None if it does not exist."""
         try:
-            ows_link = self.link_set.get(name="OGC:WMS")
+            ows_link = self.link_set.get(name="OGC:WMS") or self.link_set.get(name="OGC:WFS")
         except Link.DoesNotExist:
             return None
         else:
@@ -1921,7 +1930,7 @@ def get_linked_resources(self, as_target: bool = False):
             if as_target
             else LinkedResource.get_linked_resources(source=self)
         )
-    
+
     def prepare_wms_links(self, wms_url, identifier, bbox, srid, height, width):
         types = [
             ("jpg", _("JPEG"), "image/jpeg"),
@@ -1935,7 +1944,6 @@ def prepare_wms_links(self, wms_url, identifier, bbox, srid, height, width):
         return output
 
 
-
 class LinkManager(models.Manager):
     """Helper class to access links grouped by type"""
 

geonode/geoserver/helpers.py

@@ -1012,7 +1012,7 @@ def set_attributes_from_geoserver(layer, overwrite=False):
                 f"Error while retrieving info for {layer.subtype} '{layer.alternate or layer.typename}'", exc_info=True
             )
             attribute_map = []
-    elif layer.subtype in WPS_ACCEPTABLE_FORMATS.values():
+    elif layer.can_have_wps_links:
         typename = layer.alternate if layer.alternate else layer.typename
         logger.info(f"Getting WFS info for {layer.subtype} '{typename}'")
         dft_url_path = re.sub(r"\/wms\/?$", "/", server_url)

geonode/utils.py

@@ -1293,7 +1293,7 @@ def set_resource_default_links(instance, layer, prune=False, **kwargs):
                     resource=instance.resourcebase_ptr, name=gettext_lazy(name), link_type="image"
                 ).update(**_d)
 
-        if instance.subtype == "vector":
+        if instance.can_have_wfs_links:
             links = wfs_links(
                 instance_ows_url,
                 instance.alternate,
@@ -1372,7 +1372,7 @@ def set_resource_default_links(instance, layer, prune=False, **kwargs):
         # Legend link
         logger.debug(" -- Resource Links[Legend link]...")
         try:
-            if instance.subtype not in ["tileStore", "remote"]:
+            if instance.can_have_style:
                 for style in set(
                     list(instance.styles.all())
                     + [