[Fixes #12951] CSV file preview fails (#12999)

* [Fixes #12951] CSV file preview fails

* [Fixes #12951] CSV file preview fails

Author: mattiagiupponi

geonode/documents/forms.py

@@ -163,7 +163,7 @@ def clean(self):
             raise forms.ValidationError(_("A document cannot have both a file and a url."))
 
         if extension:
-            cleaned_data["extension"] = extension.replace(".", "")
+            cleaned_data["extension"] = extension.replace(".", "").lower()
 
         return cleaned_data
 

geonode/documents/tests.py

@@ -32,6 +32,7 @@
 
 from unittest.mock import patch
 from urllib.parse import urlparse
+from pathlib import Path
 
 from django.urls import reverse
 from django.conf import settings
@@ -42,7 +43,7 @@
 
 from guardian.shortcuts import get_anonymous_user
 
-from geonode.assets.utils import create_asset_and_link
+from geonode.assets.utils import create_asset_and_link, get_default_asset
 from geonode.base.forms import LinkedResourceForm
 from geonode.maps.models import Map
 from geonode.layers.models import Dataset
@@ -194,6 +195,25 @@ def test_create_document_url_view(self):
         d = Document.objects.get(title="GeoNode Map")
         self.assertEqual(d.doc_url, "http://www.geonode.org/map.pdf")
 
+    def test_uploaded_csv_with_uppercase_extension(self):
+        """
+        The extension of the file should always be lowercase
+        """
+
+        self.client.login(username="admin", password="admin")
+        try:
+            with open(os.path.join(os.path.dirname(__file__), "tests/data/test.CSV"), "rb") as f:
+                data = {"title": "CSV with uppercase extension", "doc_file": f, "extension": "CSV"}
+                self.client.post(reverse("document_upload"), data=data)
+            d = Document.objects.get(title="CSV with uppercase extension")
+            # verify that the extension is not lowercase
+            self.assertEqual(d.extension, "csv")
+            # be sure that also the file extension is not lowercase
+            asset = get_default_asset(d)
+            self.assertEqual(Path(asset.location[0]).suffix, ".csv")
+        finally:
+            Document.objects.filter(title="CSV with uppercase extension").delete()
+
     def test_upload_document_form(self):
         """
         Tests the Upload form.

geonode/documents/tests/data/test.CSV

@@ -0,0 +1,6 @@
+Username; Identifier;First name;Last name
+booker12;9012;Rachel;Booker
+grey07;2070;Laura;Grey
+johnson81;4081;Craig;Johnson
+jenkins46;9346;Mary;Jenkins
+smith79;5079;Jamie;Smith

geonode/documents/views.py

@@ -53,6 +53,8 @@
 from geonode.base.models import Thesaurus, TopicCategory
 from geonode.base import enumerations
 
+from pathlib import Path
+
 from .utils import get_download_response
 
 from .models import Document
@@ -162,7 +164,8 @@ def form_valid(self, form):
         if file:
             tempdir = mkdtemp()
             dirname = os.path.basename(tempdir)
-            filepath = storage_manager.save(f"{dirname}/{file.name}", file)
+            name = Path(file.name)
+            filepath = storage_manager.save(f"{dirname}/{name.stem}{name.suffix.lower()}", file)
             storage_path = storage_manager.path(filepath)
             self.object = resource_manager.create(
                 None,

geonode/resource/utils.py

@@ -333,7 +333,7 @@ def document_post_save(instance, *args, **kwargs):
     asset = get_default_asset(instance)
     if asset:
         _, extension = os.path.splitext(os.path.basename(asset.location[0]))
-        instance.extension = extension[1:]
+        instance.extension = extension[1:].lower()
         doc_type_map = DOCUMENT_TYPE_MAP
         doc_type_map.update(getattr(settings, "DOCUMENT_TYPE_MAP", {}))
         if doc_type_map is None: