[Fixes #13826] updated older test cases and formated the code

Author: sijandh35

geonode/thumbs/tests/test_unit.py

@@ -201,7 +201,7 @@ def test_datasets_locations_dataset(self):
         locations, bbox = thumbnails._datasets_locations(dataset)
 
         self.assertFalse(bbox, "Expected BBOX not to be calculated")
-        self.assertEqual(locations, [[settings.OGC_SERVER["default"]["LOCATION"], [dataset.alternate], []]])
+        self.assertEqual(locations, [[settings.OGC_SERVER["default"]["LOCATION"], [dataset.alternate], [], {}]])
 
     def test_datasets_locations_dataset_default_bbox(self):
         expected_bbox = [-8238681.374829309, -8220320.783295829, 4969844.0930337105, 4984363.884452854, "EPSG:3857"]
@@ -211,7 +211,7 @@ def test_datasets_locations_dataset_default_bbox(self):
 
         self.assertEqual(bbox[-1].upper(), "EPSG:3857", "Expected calculated BBOX CRS to be EPSG:3857")
         self.assertEqual(bbox, expected_bbox, "Expected calculated BBOX to match pre-converted one.")
-        self.assertEqual(locations, [[settings.OGC_SERVER["default"]["LOCATION"], [dataset.alternate], []]])
+        self.assertEqual(locations, [[settings.OGC_SERVER["default"]["LOCATION"], [dataset.alternate], [], {}]])
 
     def test_datasets_locations_dataset_bbox(self):
         dataset = Dataset.objects.get(title="theaters_nyc")
@@ -222,7 +222,7 @@ def test_datasets_locations_dataset_bbox(self):
         self.assertEqual(
             bbox[-1].lower(), dataset.bbox[-1].lower(), "Expected calculated BBOX's CRS to match dataset's"
         )
-        self.assertEqual(locations, [[settings.OGC_SERVER["default"]["LOCATION"], [dataset.alternate], []]])
+        self.assertEqual(locations, [[settings.OGC_SERVER["default"]["LOCATION"], [dataset.alternate], [], {}]])
 
     def test_datasets_locations_simple_map(self):
         dataset = Dataset.objects.get(title="theaters_nyc")
@@ -243,6 +243,7 @@ def test_datasets_locations_simple_map(self):
                     settings.OGC_SERVER["default"]["LOCATION"],
                     [dataset.alternate, "geonode:Meteorite_Landings_from_NASA_Open_Data_Portal1"],
                     ["theaters_nyc", "test_style"],
+                    {},
                 ]
             ],
         )
@@ -258,7 +259,7 @@ def test_datasets_locations_simple_map_default_bbox(self):
         self.assertEqual(bbox[-1].upper(), "EPSG:3857", "Expected calculated BBOX CRS to be EPSG:3857")
         self.assertEqual(bbox, expected_bbox, "Expected calculated BBOX to match pre-converted one.")
         self.assertEqual(
-            locations, [[settings.OGC_SERVER["default"]["LOCATION"], [dataset.alternate], ["theaters_nyc"]]]
+            locations, [[settings.OGC_SERVER["default"]["LOCATION"], [dataset.alternate], ["theaters_nyc"], {}]]
         )
 
     def test_datasets_locations_composition_map_default_bbox(self):
@@ -271,6 +272,7 @@ def test_datasets_locations_composition_map_default_bbox(self):
                     "rt_geologia.dbg_risorse_minerarie",
                 ],
                 [],
+                {},
             ]
         ]
 

geonode/thumbs/thumbnails.py

@@ -275,8 +275,8 @@ def _datasets_locations(
         auth_info = {}
         if instance.remote_service and instance.remote_service.needs_authentication:
             auth_info = {
-                'username': instance.remote_service.username,
-                'password': instance.remote_service.get_password()
+                "username": instance.remote_service.username,
+                "password": instance.remote_service.get_password(),
             }
         locations.append([instance.ows_url or ogc_server_settings.LOCATION, [instance.alternate], [], auth_info])
         if compute_bbox:
@@ -320,8 +320,8 @@ def _datasets_locations(
                 auth_info = {}
                 if dataset.remote_service and dataset.remote_service.needs_authentication:
                     auth_info = {
-                        'username': dataset.remote_service.username,
-                        'password': dataset.remote_service.get_password()
+                        "username": dataset.remote_service.username,
+                        "password": dataset.remote_service.get_password(),
                     }
                 # limit number of locations, ensuring dataset order
                 if len(locations) and locations[-1][0] == dataset.remote_service.service_url:

geonode/thumbs/utils.py

@@ -204,7 +204,7 @@ def get_map(
             headers["Authorization"] = f"Bearer {additional_kwargs['access_token']}"
 
     # Check if auth_info is provided (for remote services with authentication)
-    if auth_info and auth_info.get('username') and auth_info.get('password'):
+    if auth_info and auth_info.get("username") and auth_info.get("password"):
         # Use provided authentication credentials for remote service
         encoded_credentials = base64.b64encode(
             f"{auth_info['username']}:{auth_info['password']}".encode("UTF-8")