Fix new PMD errors introduced by the OpenRewrite recipe

Author: groldan

geowebcache/core/src/main/java/org/geowebcache/config/XMLConfiguration.java

@@ -791,7 +791,7 @@ private static Node applyTransform(Node oldRootNode, String xslFilename) {
     public void afterPropertiesSet() throws GeoWebCacheException {
         if (!resourceProvider.hasInput()) {
             throw new ConfigurationException(
-                    "The configuration resource provider is unable to provide a configuration file".formatted());
+                    "The configuration resource provider is unable to provide a configuration file");
         }
         if (gridSetBroker == null) {
             throw new IllegalStateException("GridSetBroker has not been set");

geowebcache/core/src/main/java/org/geowebcache/io/ByteArrayResource.java

@@ -103,7 +103,7 @@ public long transferTo(WritableByteChannel channel) throws IOException {
 
     /** @see org.geowebcache.io.Resource#transferFrom(java.nio.channels.ReadableByteChannel) */
     @Override
-    @SuppressWarnings("PMD.EmptyControlStatement")
+    @SuppressWarnings({"PMD.EmptyControlStatement", "PMD.CloseResource"})
     public long transferFrom(ReadableByteChannel channel) throws IOException {
         if (channel instanceof FileChannel fc) {
             offset = 0;

geowebcache/core/src/main/java/org/geowebcache/layer/MetaTile.java

@@ -493,6 +493,7 @@ public void dispose() {
         disposableImages = null;
     }
 
+    @SuppressWarnings("PMD.CloseResource")
     protected static void disposePlanarImageChain(PlanarImage pi, HashSet<PlanarImage> visited) {
         List sinks = pi.getSinks();
         // check all the sinks (the image might be in the middle of a chain)

geowebcache/diskquota/jdbc/src/main/java/org/geowebcache/diskquota/jdbc/JDBCQuotaStore.java

@@ -680,6 +680,7 @@ public PageStats setTruncated(final TilePage page) throws InterruptedException {
     }
 
     @Override
+    @SuppressWarnings("PMD.CloseResource") // we're closing dataSource, not sure why PMD complains
     public void close() throws Exception {
         log.info("Closing up the JDBC quota store ");
 

geowebcache/wms/src/main/java/org/geowebcache/io/codec/ImageDecoderImpl.java

@@ -109,6 +109,7 @@ public ImageDecoderImpl(
      * @param aggressiveInputStreamOptimization Parameter used if aggressive outputStream optimization must be used.
      */
     @Override
+    @SuppressWarnings("PMD.CloseResource") // the caller is in charge of source's life cycle if its a stream
     public BufferedImage decode(Object source, boolean aggressiveInputStreamOptimization, Map<String, Object> map)
             throws Exception {
 

geowebcache/wms/src/main/java/org/geowebcache/io/codec/ImageEncoderImpl.java

@@ -225,6 +225,7 @@ public static WriteHelper getWriteHelperForName(String formatName) {
      * @param aggressiveOutputStreamOptimization Parameter used if aggressive outputStream optimization must be used.
      */
     @Override
+    @SuppressWarnings("PMD.CloseResource") // the caller is in charge of destination's life cycle if its a stream
     public void encode(
             RenderedImage image,
             Object destination,

geowebcache/wms/src/main/java/org/geowebcache/io/codec/PNGImageEncoder.java

@@ -81,6 +81,7 @@ public boolean isAggressiveOutputStreamSupported() {
     }
 
     @Override
+    @SuppressWarnings("PMD.CloseResource") // the caller is in charge of destination's life cycle if its a stream
     public void encode(
             RenderedImage image,
             Object destination,