Removing unecessary compiler suppressions

Author: aaime

geowebcache/core/src/main/java/org/geowebcache/util/ServletUtils.java

@@ -103,7 +103,6 @@ public static String[][] selectedStringArraysFromMap(Map<String, String[]> map,
      *
      * @return map subset containing (URL decoded) values for {@code keys}, with keys normalized to upper case
      */
-    @SuppressWarnings("unchecked")
     public static Map<String, String> selectedStringsFromMap(Map<String, ?> map, String encoding, String... keys) {
 
         map = new CaseInsensitiveMap<>(map);

geowebcache/core/src/test/java/org/geowebcache/MockExtensionRuleTest.java

@@ -172,7 +172,6 @@ public void testAddsTypedExtensions() throws Throwable {
         rule.apply(
                         new Statement() {
 
-                            @SuppressWarnings("unchecked")
                             @Override
                             public void evaluate() throws Throwable {
                                 String bean1 = "THISISTHEBEAN";

geowebcache/core/src/test/java/org/geowebcache/config/BlobStoreConfigurationTest.java

@@ -477,7 +477,6 @@ public void testExceptionInAddListenerDoesntBlockOtherListeners() throws Excepti
         EasyMock.verify(listener2);
     }
 
-    @SuppressWarnings("unchecked")
     @Test
     public void testExceptionInAddListenerRecordsSuppressedExceptions() throws Exception {
         BlobStoreConfigurationListener listener1 =
@@ -578,7 +577,6 @@ public void testExceptionInModifyListenerDoesntBlockOtherListeners() throws Exce
         EasyMock.verify(listener2);
     }
 
-    @SuppressWarnings("unchecked")
     @Test
     public void testExceptionInModifyListenerRecordsSuppressedExceptions() throws Exception {
         BlobStoreConfigurationListener listener1 =
@@ -683,7 +681,6 @@ public void testExceptionInRenameListenerDoesntBlockOtherListeners() throws Exce
         EasyMock.verify(listener2);
     }
 
-    @SuppressWarnings("unchecked")
     @Test
     public void testExceptionInRenameListenerRecordsSuppressedExceptions() throws Exception {
         BlobStoreConfigurationListener listener1 =
@@ -788,7 +785,6 @@ public void testExceptionInRemoveListenerDoesntBlockOtherListeners() throws Exce
         EasyMock.verify(listener2);
     }
 
-    @SuppressWarnings("unchecked")
     @Test
     public void testExceptionInRemoveListenerRecordsSuppressedExceptions() throws Exception {
         BlobStoreConfigurationListener listener1 =

geowebcache/core/src/test/java/org/geowebcache/config/ListenerCollectionTest.java

@@ -143,7 +143,6 @@ public void testExceptionDoesntPreventOthers() throws Exception {
         control.verify();
     }
 
-    @SuppressWarnings("unchecked")
     @Test
     public void testSuppressedExceptionsRecorded() throws Exception {
         ListenerCollection<Runnable> collection = new ListenerCollection<>();

geowebcache/core/src/test/java/org/geowebcache/seed/SeedTaskTest.java

@@ -74,7 +74,6 @@ public void tearDown() throws Exception {}
 
     /** For a metatiled seed request over a given zoom level, make sure the correct wms calls are issued */
     @Test
-    @SuppressWarnings("serial")
     public void testSeedWMSRequests() throws Exception {
         WMSLayer tl = createWMSLayer("image/png");
 
@@ -243,7 +242,6 @@ protected void makeRequest(
 
     /** Make sure when seeding a given zoom level, the correct tiles are sent to the {@link StorageBroker} */
     @Test
-    @SuppressWarnings("serial")
     public void testSeedStoredTiles() throws Exception {
 
         WMSLayer tl = createWMSLayer("image/png");

geowebcache/core/src/test/java/org/geowebcache/seed/TruncateBboxRequestTest.java

@@ -39,7 +39,6 @@
 
 public class TruncateBboxRequestTest {
 
-    @SuppressWarnings("unchecked")
     protected SeedRequest seedRequest(
             String layerName,
             String gridSet,

geowebcache/core/src/test/java/org/geowebcache/storage/AbstractBlobStoreTest.java

@@ -664,7 +664,6 @@ public void testMetadataWithPercentInValue() throws Exception {
         assertThat(store.getLayerMetadata("testLayer", "testKey"), equalTo("test%Value"));
     }
 
-    @SuppressWarnings("unchecked")
     @Test
     public void testParameterList() throws Exception {
         Map<String, String> params1 = Collections.singletonMap("testKey", "testValue1");

geowebcache/sqlite/src/test/java/org/geowebcache/sqlite/MbtilesBlobStoreTest.java

@@ -270,7 +270,7 @@ public void testRenameOperation() throws Exception {
     }
 
     @Test
-    @SuppressWarnings("unchecked") // TODO: remove when upgrading to Hamcrest 2
+    // TODO: remove when upgrading to Hamcrest 2
     public void testOpeningDatabaseFileWithMbtilesMetadata() throws Exception {
         // create and instantiate mbtiles metadata
         File mbtilesMetadataDirectory = buildRootFile("mbtiles-metadata");

geowebcache/wms/src/test/java/org/geowebcache/config/wms/GetCapabilitiesConfigurationTest.java

@@ -171,7 +171,7 @@ WebMapServer getWMS() {
     }
 
     @Test
-    @SuppressWarnings("unchecked") // to be removed once we upgrade to Hamcrest 2, @SafeVarArgs
+    // to be removed once we upgrade to Hamcrest 2, @SafeVarArgs
     public void testDelegateInitializingLayers() throws Exception {
         GridSetBroker broker = new GridSetBroker(Collections.singletonList(new DefaultGridsets(false, false)));
         String url = "http://test/wms";

geowebcache/wmts/src/test/java/org/geowebcache/service/wmts/WMTSServiceTest.java

@@ -295,7 +295,6 @@ public void testGetCap() throws Exception {
 
         service = new WMTSService(sb, tld, null, mock(RuntimeStats.class));
 
-        @SuppressWarnings("unchecked")
         Map<String, String[]> kvp = new CaseInsensitiveMap<>();
         kvp.put("service", new String[] {"WMTS"});
         kvp.put("version", new String[] {"1.0.0"});
@@ -553,7 +552,6 @@ public ServiceInformation getServiceInformation() {
         when(gwcd.getServletPrefix()).thenReturn(null);
         service = new WMTSService(sb, tld, null, mock(RuntimeStats.class));
         extensions.forEach(service::addExtension);
-        @SuppressWarnings("unchecked")
         Map<String, String[]> kvp = new CaseInsensitiveMap<>();
         kvp.put("service", new String[] {"WMTS"});
         kvp.put("version", new String[] {"1.0.0"});
@@ -625,7 +623,6 @@ public void testGetCapServiceInfo() throws Exception {
 
         service = new WMTSService(sb, tldx, null, mock(RuntimeStats.class));
 
-        @SuppressWarnings("unchecked")
         Map<String, String[]> kvp = new CaseInsensitiveMap<>();
         kvp.put("service", new String[] {"WMTS"});
         kvp.put("version", new String[] {"1.0.0"});
@@ -690,7 +687,6 @@ public void testGetCapOneWGS84BBox() throws Exception {
 
         service = new WMTSService(sb, tld, null, mock(RuntimeStats.class));
 
-        @SuppressWarnings("unchecked")
         Map<String, String[]> kvp = new CaseInsensitiveMap<>();
         kvp.put("service", new String[] {"WMTS"});
         kvp.put("version", new String[] {"1.0.0"});
@@ -758,7 +754,6 @@ public void testGetCapUnboundedStyleFilter() throws Exception {
 
         service = new WMTSService(sb, tld, null, mock(RuntimeStats.class));
 
-        @SuppressWarnings("unchecked")
         Map<String, String[]> kvp = new CaseInsensitiveMap<>();
         kvp.put("service", new String[] {"WMTS"});
         kvp.put("version", new String[] {"1.0.0"});
@@ -820,7 +815,6 @@ public void testGetCapEmptyStyleFilter() throws Exception {
 
         service = new WMTSService(sb, tld, null, mock(RuntimeStats.class));
 
-        @SuppressWarnings("unchecked")
         Map<String, String[]> kvp = new CaseInsensitiveMap<>();
         kvp.put("service", new String[] {"WMTS"});
         kvp.put("version", new String[] {"1.0.0"});
@@ -882,7 +876,6 @@ public void testGetCapMultipleStyles() throws Exception {
 
         service = new WMTSService(sb, tld, null, mock(RuntimeStats.class));
 
-        @SuppressWarnings("unchecked")
         Map<String, String[]> kvp = new CaseInsensitiveMap<>();
         kvp.put("service", new String[] {"WMTS"});
         kvp.put("version", new String[] {"1.0.0"});
@@ -979,7 +972,6 @@ private static XpathEngine buildWMTSXPath() {
      * , "text/html" , "application/vnd.ogc.gml" then checks if in the capabilities documents each <ResourceURL>
      * elements contains both the dimensions components.
      */
-    @SuppressWarnings("unchecked")
     @Test
     public void testGetCapWithMultipleDimensions() throws Exception {
 
@@ -1053,7 +1045,6 @@ public void testGetCapWithMultipleDimensions() throws Exception {
         assertEquals("2", xpath.evaluate("count(//wmts:Contents/wmts:Layer/wmts:Dimension/ows:Identifier)", doc));
     }
 
-    @SuppressWarnings("unchecked")
     @Test
     public void testGetTileWithStyle() throws Exception {
 
@@ -1124,7 +1115,6 @@ public void testDispatchCustomOperations() throws Exception {
         GeoWebCacheDispatcher gwcd = mock(GeoWebCacheDispatcher.class);
         when(gwcd.getServletPrefix()).thenReturn(null);
         service = new WMTSService(sb, tld, null, mock(RuntimeStats.class));
-        @SuppressWarnings("unchecked")
         Map<String, String[]> kvp = new CaseInsensitiveMap<>();
         kvp.put("service", new String[] {"WMTS"});
         kvp.put("version", new String[] {"1.0.0"});
@@ -1384,7 +1374,6 @@ public void testGetCapWithTileJSONDifferentUrls() throws Exception {
 
         service = new WMTSService(sb, tld, null, mock(RuntimeStats.class));
 
-        @SuppressWarnings("unchecked")
         Map<String, String[]> kvp = new CaseInsensitiveMap<>();
         kvp.put("service", new String[] {"WMTS"});
         kvp.put("version", new String[] {"1.0.0"});