fix model check for invalidity

Author: BenPinet

src/geode/inspector/criterion/manifold/brep_meshes_manifold.cpp

@@ -239,13 +239,34 @@ namespace geode
                         BRepNonManifoldEdge{
                             edge.first.vertices(), edge.second },
                         message );
+                    continue;
                 }
                 const auto& surface = model().surface( edge.second[0] );
                 const auto& mesh = surface.mesh();
                 const auto is_on_free_border =
                     vertices_on_free_border( surface, mesh, model() );
-                if( !is_on_free_border[edge.first.vertices()[0]]
-                    || !is_on_free_border[edge.first.vertices()[1]] )
+                geode::index_t first_edge_vertex;
+                geode::index_t second_edge_vertex;
+                for( const auto& cmv : model().component_mesh_vertices(
+                         edge.first.vertices()[0] ) )
+                {
+                    if( cmv.component_id.id() == surface.id() )
+                    {
+                        first_edge_vertex = cmv.vertex;
+                        break;
+                    }
+                }
+                for( const auto& cmv : model().component_mesh_vertices(
+                         edge.first.vertices()[1] ) )
+                {
+                    if( cmv.component_id.id() == surface.id() )
+                    {
+                        second_edge_vertex = cmv.vertex;
+                        break;
+                    }
+                }
+                if( !is_on_free_border[first_edge_vertex]
+                    || !is_on_free_border[second_edge_vertex] )
                 {
                     continue;
                 }

src/geode/inspector/criterion/manifold/surface_edge_manifold.cpp

@@ -52,8 +52,7 @@ namespace
                 };
                 if( !polygons_around_edges
                          .try_emplace( polygon_edge_vertex_cycle,
-                             std::pair< geode::local_index_t, bool >{
-                                 1, false } )
+                             std::make_pair( 1, false ) )
                          .second )
                 {
                     polygons_around_edges[polygon_edge_vertex_cycle].first += 1;

tests/inspector/test-brep.cpp

@@ -317,9 +317,9 @@ void check_model_a1( bool string )
 
     const auto nb_component_meshes_issues =
         launch_component_meshes_validity_checks( result.meshes, string );
-    OPENGEODE_EXCEPTION( nb_component_meshes_issues == 13494,
+    OPENGEODE_EXCEPTION( nb_component_meshes_issues == 13503,
         "[Test] model_A1 has ", nb_component_meshes_issues,
-        " meshes problems instead of 13494." );
+        " meshes problems instead of 13503." );
 }
 
 void check_model_a1_valid( bool string )
@@ -340,9 +340,9 @@ void check_model_a1_valid( bool string )
 
     const auto nb_component_meshes_issues =
         launch_component_meshes_validity_checks( result.meshes, string );
-    OPENGEODE_EXCEPTION( nb_component_meshes_issues == 13494,
+    OPENGEODE_EXCEPTION( nb_component_meshes_issues == 13503,
         "[Test] model_A1_valid has ", nb_component_meshes_issues,
-        " meshes problems instead of 13494." );
+        " meshes problems instead of 13503." );
 }
 
 void check_model_mss( bool string )
@@ -396,7 +396,6 @@ int main()
         check_model_a1_valid( false );
         check_model_mss( false );
         check_model_D( false );
-
         geode::Logger::info( "TEST SUCCESS" );
         return 0;
     }