Skip to content

Commit 0700415

Browse files
authored
Merge pull request #153 from Geode-solutions/fix/brep_non_manifold_facets_not_output_in_string_function
fix(BRepMeshesManifoldInspectionResult): Fixed string function to out…
2 parents f4efd80 + 6b85237 commit 0700415

File tree

1 file changed

+10
-11
lines changed

1 file changed

+10
-11
lines changed

src/geode/inspector/criterion/manifold/brep_meshes_manifold.cpp

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,10 @@ namespace geode
7373
{
7474
absl::StrAppend( &message, brep_non_manifold_edges.string() );
7575
}
76+
if( brep_non_manifold_facets.nb_issues() != 0 )
77+
{
78+
absl::StrAppend( &message, brep_non_manifold_facets.string() );
79+
}
7680
if( !message.empty() )
7781
{
7882
return message;
@@ -254,8 +258,8 @@ namespace geode
254258
absl::StrAppend( &message, polygon_vertex, " " );
255259
}
256260
absl::StrAppend( &message,
257-
" is not manifold: it belongs to an internal "
258-
"surface with only one facet" );
261+
" is not manifold: it belongs to internal surface ",
262+
surface.id().string(), " with only one facet" );
259263
issues.add_issue(
260264
BRepNonManifoldFacet{ facet_vertices, { surface.id() } },
261265
message );
@@ -266,18 +270,13 @@ namespace geode
266270
bool several_cmvs_on_one_vertex(
267271
absl::Span< const index_t > unique_vertices ) const
268272
{
273+
std::vector< uuid > surfaces;
269274
for( const auto unique_vertex : unique_vertices )
270275
{
271-
std::vector< uuid > components;
272-
for( const auto& cmv :
273-
model().component_mesh_vertices( unique_vertex ) )
276+
if( model().component_mesh_vertices( unique_vertex ).size()
277+
> 1 )
274278
{
275-
if( absl::c_find( components, cmv.component_id.id() )
276-
!= components.end() )
277-
{
278-
return true;
279-
}
280-
components.push_back( cmv.component_id.id() );
279+
return true;
281280
}
282281
}
283282
return false;

0 commit comments

Comments
 (0)