Merge pull request #110 from Geode-solutions/fix/async

fix(Async): add parallel_invoke

Author: MelchiorSchuh

bindings/python/requirements.txt

@@ -2,7 +2,7 @@
 # This file is autogenerated by pip-compile with Python 3.10
 # by the following command:
 #
-#    pip-compile bindings/python/requirements.in
+#    pip-compile --pre bindings/python/requirements.in
 #
-opengeode-core==15.*,>=15.4.8
+opengeode-core==15.*,>=15.5.1
     # via -r bindings/python/requirements.in

src/geode/inspector/CMakeLists.txt

@@ -135,6 +135,7 @@ add_geode_library(
     PUBLIC_DEPENDENCIES
         OpenGeode::basic
     PRIVATE_DEPENDENCIES
+        Async++
         OpenGeode::geometry
         OpenGeode::mesh
         OpenGeode::model

src/geode/inspector/brep_inspector.cpp

@@ -23,6 +23,8 @@
 
 #include <geode/inspector/brep_inspector.hpp>
 
+#include <async++.h>
+
 #include <geode/model/representation/core/brep.hpp>
 
 namespace geode
@@ -47,8 +49,13 @@ namespace geode
     BRepInspectionResult BRepInspector::inspect_brep() const
     {
         BRepInspectionResult result;
-        result.meshes = inspect_brep_meshes();
-        result.topology = inspect_brep_topology();
+        async::parallel_invoke(
+            [&result, this] {
+                result.meshes = inspect_brep_meshes();
+            },
+            [&result, this] {
+                result.topology = inspect_brep_topology();
+            } );
         return result;
     }
 

src/geode/inspector/criterion/adjacency/brep_meshes_adjacency.cpp

@@ -23,6 +23,8 @@
 
 #include <geode/inspector/criterion/adjacency/brep_meshes_adjacency.hpp>
 
+#include <async++.h>
+
 #include <geode/basic/logger.hpp>
 #include <geode/basic/pimpl_impl.hpp>
 
@@ -89,16 +91,21 @@ namespace geode
     {
     }
 
-    BRepComponentMeshesAdjacency::~BRepComponentMeshesAdjacency() {}
+    BRepComponentMeshesAdjacency::~BRepComponentMeshesAdjacency() = default;
 
     BRepMeshesAdjacencyInspectionResult
         BRepComponentMeshesAdjacency::inspect_brep_meshes_adjacencies() const
     {
         BRepMeshesAdjacencyInspectionResult result;
-        impl_->add_surfaces_edges_with_wrong_adjacencies(
-            result.surfaces_edges_with_wrong_adjacencies );
-        impl_->add_blocks_facets_with_wrong_adjacencies(
-            result.blocks_facets_with_wrong_adjacencies );
+        async::parallel_invoke(
+            [&result, this] {
+                impl_->add_surfaces_edges_with_wrong_adjacencies(
+                    result.surfaces_edges_with_wrong_adjacencies );
+            },
+            [&result, this] {
+                impl_->add_blocks_facets_with_wrong_adjacencies(
+                    result.blocks_facets_with_wrong_adjacencies );
+            } );
         return result;
     }
 } // namespace geode

src/geode/inspector/criterion/adjacency/section_meshes_adjacency.cpp

@@ -63,7 +63,8 @@ namespace geode
     {
     }
 
-    SectionComponentMeshesAdjacency::~SectionComponentMeshesAdjacency() {}
+    SectionComponentMeshesAdjacency::~SectionComponentMeshesAdjacency() =
+        default;
 
     SectionMeshesAdjacencyInspectionResult
         SectionComponentMeshesAdjacency::inspect_section_meshes_adjacencies()

src/geode/inspector/criterion/adjacency/solid_adjacency.cpp

@@ -123,9 +123,7 @@ namespace geode
     }
 
     template < index_t dimension >
-    SolidMeshAdjacency< dimension >::~SolidMeshAdjacency()
-    {
-    }
+    SolidMeshAdjacency< dimension >::~SolidMeshAdjacency() = default;
 
     template < index_t dimension >
     bool SolidMeshAdjacency< dimension >::mesh_has_wrong_adjacencies() const

src/geode/inspector/criterion/adjacency/surface_adjacency.cpp

@@ -122,9 +122,7 @@ namespace geode
     }
 
     template < index_t dimension >
-    SurfaceMeshAdjacency< dimension >::~SurfaceMeshAdjacency()
-    {
-    }
+    SurfaceMeshAdjacency< dimension >::~SurfaceMeshAdjacency() = default;
 
     template < index_t dimension >
     bool SurfaceMeshAdjacency< dimension >::mesh_has_wrong_adjacencies() const

src/geode/inspector/criterion/brep_meshes_inspector.cpp

@@ -23,6 +23,8 @@
 
 #include <geode/inspector/criterion/brep_meshes_inspector.hpp>
 
+#include <async++.h>
+
 namespace geode
 {
     std::string BRepMeshesInspectionResult::string() const
@@ -52,13 +54,28 @@ namespace geode
     BRepMeshesInspectionResult BRepMeshesInspector::inspect_brep_meshes() const
     {
         BRepMeshesInspectionResult result;
-        result.unique_vertices_colocation = inspect_unique_vertices();
-        result.meshes_colocation = inspect_meshes_point_colocations();
-        result.meshes_adjacencies = inspect_brep_meshes_adjacencies();
-        result.meshes_degenerations = inspect_elements_degeneration();
-        result.meshes_intersections = inspect_intersections();
-        result.meshes_non_manifolds = inspect_brep_manifold();
-        result.meshes_negative_elements = inspect_negative_elements();
+        async::parallel_invoke(
+            [&result, this] {
+                result.unique_vertices_colocation = inspect_unique_vertices();
+            },
+            [&result, this] {
+                result.meshes_colocation = inspect_meshes_point_colocations();
+            },
+            [&result, this] {
+                result.meshes_adjacencies = inspect_brep_meshes_adjacencies();
+            },
+            [&result, this] {
+                result.meshes_degenerations = inspect_elements_degeneration();
+            },
+            [&result, this] {
+                result.meshes_intersections = inspect_intersections();
+            },
+            [&result, this] {
+                result.meshes_non_manifolds = inspect_brep_manifold();
+            },
+            [&result, this] {
+                result.meshes_negative_elements = inspect_negative_elements();
+            } );
         return result;
     }
 } // namespace geode

src/geode/inspector/criterion/colocation/component_meshes_colocation.cpp

@@ -265,9 +265,7 @@ namespace geode
     }
 
     template < typename Model >
-    ComponentMeshesColocation< Model >::~ComponentMeshesColocation()
-    {
-    }
+    ComponentMeshesColocation< Model >::~ComponentMeshesColocation() = default;
 
     template < typename Model >
     MeshesColocationInspectionResult

src/geode/inspector/criterion/colocation/edgedcurve_colocation.cpp

@@ -51,9 +51,7 @@ namespace geode
     }
 
     template < index_t dimension >
-    EdgedCurveColocation< dimension >::~EdgedCurveColocation()
-    {
-    }
+    EdgedCurveColocation< dimension >::~EdgedCurveColocation() = default;
 
     template < index_t dimension >
     bool EdgedCurveColocation< dimension >::mesh_has_colocated_points() const