fix(AABBTree): missing mutex in operators

Author: BotellaA

src/geode/inspector/criterion/intersections/model_intersections.cpp

@@ -50,10 +50,12 @@ namespace
         bool operator()(
             geode::index_t first_component, geode::index_t second_component )
         {
+            std::lock_guard< std::mutex > lock( mutex );
             component_pairs.emplace_back( first_component, second_component );
             return false;
         }
 
+        std::mutex mutex;
         std::vector< std::pair< geode::index_t, geode::index_t > >
             component_pairs;
     };

src/geode/inspector/criterion/intersections/surface_curve_intersections.cpp

@@ -65,6 +65,7 @@ namespace
 
         void emplace( geode::index_t triangle_id, geode::index_t edge_id )
         {
+            std::lock_guard< std::mutex > lock( mutex_ );
             intersecting_elements_.emplace_back( triangle_id, edge_id );
         }
 
@@ -73,6 +74,7 @@ namespace
         const geode::EdgedCurve< dimension >& curve_;
         std::vector< std::pair< geode::index_t, geode::index_t > >
             intersecting_elements_;
+        std::mutex mutex_;
     };
 
     template < geode::index_t dimension >

src/geode/inspector/criterion/intersections/surface_intersections.cpp

@@ -75,6 +75,7 @@ namespace
     protected:
         void emplace( geode::index_t p1_id, geode::index_t p2_id )
         {
+            std::lock_guard< std::mutex > lock( mutex_ );
             intersecting_polygons_.emplace_back( p1_id, p2_id );
         }
 
@@ -88,6 +89,7 @@ namespace
         bool stop_at_first_intersection_;
         std::vector< std::pair< geode::index_t, geode::index_t > >
             intersecting_polygons_;
+        std::mutex mutex_;
     };
 } // namespace
 

tests/inspector/test-surface-intersections.cpp

@@ -56,10 +56,18 @@ void check_intersections2D()
         "[Test] 2D Surface should have 3 intersecting elements pair." );
     bool right_intersections{ true };
     const auto &triangles_inter = inspection.issues();
-    if( triangles_inter.size() != 3 || triangles_inter[0].first != 2
-        || triangles_inter[0].second != 0 || triangles_inter[1].first != 2
-        || triangles_inter[1].second != 1 || triangles_inter[2].first != 0
-        || triangles_inter[2].second != 1 )
+    if( absl::c_find( triangles_inter, std::make_pair( 2u, 0u ) )
+        == triangles_inter.end() )
+    {
+        right_intersections = false;
+    }
+    if( absl::c_find( triangles_inter, std::make_pair( 2u, 1u ) )
+        == triangles_inter.end() )
+    {
+        right_intersections = false;
+    }
+    if( absl::c_find( triangles_inter, std::make_pair( 0u, 1u ) )
+        == triangles_inter.end() )
     {
         right_intersections = false;
     }
@@ -100,9 +108,13 @@ void check_intersections3D()
         inspection.nb_issues(), "." );
     bool right_intersections{ true };
     const auto &triangles_inter = inspection.issues();
-    if( triangles_inter.size() != 2 || triangles_inter[0].first != 0
-        || triangles_inter[0].second != 4 || triangles_inter[1].first != 2
-        || triangles_inter[1].second != 4 )
+    if( absl::c_find( triangles_inter, std::make_pair( 0u, 4u ) )
+        == triangles_inter.end() )
+    {
+        right_intersections = false;
+    }
+    if( absl::c_find( triangles_inter, std::make_pair( 2u, 4u ) )
+        == triangles_inter.end() )
     {
         right_intersections = false;
     }