feat(Inspector): Refactored and finished the topology inspector, allowing inspection of the topology of corners, lines, surfaces and surfaces

* feat(Inspector): new class to inspect the topology of a BRep unique vertices.

* feat(Inspector): Refactored and finished the topology inspector, allowing inspection of the topology of corners, lines, surfaces and surfaces

Author: MelchiorSchuh

include/geode/inspector/topology/brep_vertices_topology.h renamed to include/geode/inspector/topology/brep_topology.h

@@ -37,22 +37,24 @@ namespace geode
     /*!
      * Class for inspecting the topology of a BRep model corners
      */
-    class opengeode_inspector_inspector_api BRepVerticesTopology
+    class opengeode_inspector_inspector_api BRepTopologyInspector
     {
-        OPENGEODE_DISABLE_COPY( BRepVerticesTopology );
+        OPENGEODE_DISABLE_COPY( BRepTopologyInspector );
 
     public:
-        BRepVerticesTopology( const BRep& brep );
-        ~BRepVerticesTopology();
+        BRepTopologyInspector( const BRep& brep );
+        ~BRepTopologyInspector();
 
         /*!
-         * Checks if the brep has topologically valid unique vertices, i.e. has
-         * vertices which verify:
-         * Each unique_vertex can only be associated to one corner.
-         * Each corner can only be internal to one object (surface or block).
-         * Each corner is a boundary of every line it is associated to.
+         * Checks if the brep is topologically valid through the unique
+         * vertices.
          */
-        bool brep_vertices_topology_is_valid() const;
+        bool brep_topology_is_valid() const;
+
+        bool brep_components_are_linked_to_a_unique_vertex() const;
+
+        std::vector< index_t >
+            invalid_components_topology_unique_vertices() const;
 
         std::vector< index_t > multiple_corners_unique_vertices() const;
 
@@ -63,6 +65,33 @@ namespace geode
 
         std::vector< index_t > line_corners_without_boundary_status() const;
 
+        std::vector< index_t >
+            part_of_not_boundary_nor_internal_line_unique_vertices() const;
+
+        std::vector< index_t >
+            part_of_line_with_invalid_internal_topology_unique_vertices() const;
+
+        std::vector< index_t >
+            part_of_invalid_unique_line_unique_vertices() const;
+
+        std::vector< index_t >
+            part_of_lines_but_not_corner_unique_vertices() const;
+
+        std::vector< index_t >
+            part_of_not_boundary_nor_internal_surface_unique_vertices() const;
+
+        std::vector< index_t >
+            part_of_surface_with_invalid_internal_topology_unique_vertices()
+                const;
+
+        std::vector< index_t >
+            part_of_invalid_unique_surface_unique_vertices() const;
+
+        std::vector< index_t >
+            part_of_invalid_multiple_surfaces_unique_vertices() const;
+
+        std::vector< index_t > part_of_invalid_blocks_unique_vertices() const;
+
     private:
         IMPLEMENTATION_MEMBER( impl_ );
     };

include/geode/inspector/topology/private/brep_blocks_topology_impl.h

@@ -0,0 +1,61 @@
+/*
+ * Copyright (c) 2019 - 2022 Geode-solutions
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ * SOFTWARE.
+ *
+ */
+
+#pragma once
+
+#include <geode/inspector/common.h>
+
+namespace geode
+{
+    class BRep;
+} // namespace geode
+
+namespace geode
+{
+    namespace detail
+    {
+        /*!
+         * Class for inspecting the topology of a BRep model blocks through
+         * their unique vertices
+         */
+        class BRepBlocksTopologyImpl
+        {
+        public:
+            BRepBlocksTopologyImpl( const BRep& brep );
+
+            /*!
+             * Checks if the brep unique vertices are parts of valid blocks,
+             * i.e. verify:
+             * If the vertex is part of multiple blocks, either it is part of
+             * exactly 2 blocks (and at least one surface which is boundary to
+             * the 2 blocks), or it is part of more than to blocks (and it is
+             * either a corner, or not a corner but part of only one line).
+             */
+            bool brep_vertex_blocks_topology_is_valid(
+                index_t unique_vertex_index ) const;
+
+        private:
+            const BRep& brep_;
+        };
+    } // namespace detail
+} // namespace geode

include/geode/inspector/topology/private/brep_corners_topology_impl.h

@@ -0,0 +1,69 @@
+/*
+ * Copyright (c) 2019 - 2022 Geode-solutions
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ * SOFTWARE.
+ *
+ */
+
+#pragma once
+
+#include <geode/inspector/common.h>
+
+namespace geode
+{
+    class BRep;
+} // namespace geode
+
+namespace geode
+{
+    namespace detail
+    {
+        class BRepCornersTopologyImpl
+        {
+        public:
+            BRepCornersTopologyImpl( const BRep& brep );
+
+            /*!
+             * Checks if the brep unique vertices are valid corners, i.e.
+             * corners that verify:
+             * Each unique_vertex can only be associated to one corner.
+             * Each corner can only be internal to one object (surface or
+             * block).
+             * Each corner is a boundary of every line it is associated to.
+             */
+            bool brep_corner_topology_is_valid(
+                index_t unique_vertex_index ) const;
+
+            bool unique_vertex_has_multiple_corners(
+                index_t unique_vertex_index ) const;
+
+            bool corner_has_multiple_embeddings(
+                index_t unique_vertex_index ) const;
+
+            bool corner_is_not_internal_nor_boundary(
+                index_t unique_vertex_index ) const;
+
+            bool corner_is_part_of_line_but_not_boundary(
+                index_t unique_vertex_index ) const;
+
+        private:
+            const BRep& brep_;
+        };
+    } // namespace detail
+} // namespace geode

include/geode/inspector/topology/private/brep_lines_topology_impl.h

@@ -0,0 +1,76 @@
+/*
+ * Copyright (c) 2019 - 2022 Geode-solutions
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ * SOFTWARE.
+ *
+ */
+
+#pragma once
+
+#include <geode/inspector/common.h>
+
+namespace geode
+{
+    class BRep;
+} // namespace geode
+
+namespace geode
+{
+    namespace detail
+    {
+        /*!
+         * Class for inspecting the topology of a BRep model lines through their
+         * unique vertices
+         */
+        class BRepLinesTopologyImpl
+        {
+        public:
+            BRepLinesTopologyImpl( const BRep& brep );
+
+            /*!
+             * Checks if the brep unique vertices are parts of valid lines, i.e.
+             * verify:
+             * Each line is either internal or boundary.
+             * Each internal line is internal to only one object and is not
+             * boundary.
+             * If the vertex is part of only one line, the line is either
+             * internal to a surface, internal to a block, or a boundary of
+             * multiple surfaces.
+             * If the vertex is part of multiple lines, it is also a corner.
+             */
+            bool brep_vertex_lines_topology_is_valid(
+                index_t unique_vertex_index ) const;
+
+            bool vertex_is_part_of_not_boundary_nor_internal_line(
+                const index_t unique_vertex_index ) const;
+
+            bool vertex_is_part_of_line_with_invalid_internal_topology(
+                const index_t unique_vertex_index ) const;
+
+            bool vertex_is_part_of_invalid_unique_line(
+                index_t unique_vertex_index ) const;
+
+            bool vertex_has_lines_but_is_not_corner(
+                index_t unique_vertex_index ) const;
+
+        private:
+            const BRep& brep_;
+        };
+    } // namespace detail
+} // namespace geode

include/geode/inspector/topology/private/brep_surfaces_topology_impl.h

@@ -0,0 +1,81 @@
+/*
+ * Copyright (c) 2019 - 2022 Geode-solutions
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ * SOFTWARE.
+ *
+ */
+
+#pragma once
+
+#include <geode/inspector/common.h>
+
+namespace geode
+{
+    class BRep;
+} // namespace geode
+
+namespace geode
+{
+    namespace detail
+    {
+        /*!
+         * Class for inspecting the topology of a BRep model surfaces through
+         * their unique vertices
+         */
+        class BRepSurfacesTopologyImpl
+        {
+        public:
+            BRepSurfacesTopologyImpl( const BRep& brep );
+
+            /*!
+             * Checks if the brep unique vertices are parts of valid surfaces,
+             * i.e. verify:
+             * Each surface is either internal or boundary.
+             * Each internal surface is internal to only one object and is not
+             * boundary.
+             * If the vertex is part of only one surface, the vertex is part of
+             * no more than 2 blocks, and the surface is either internal to a
+             * block (and the vertex is in one and only one block) or a boundary
+             * of all the blocks the vertex is in.
+             * If the vertex is part of multiple surfaces, it is either part of
+             * only one line (and no corner, and the line is boundary to all the
+             * surfaces) or multiple lines (and all the lines are either
+             * internal or boundary to at least 2 of the surfaces the vertex is
+             * in).
+             */
+            bool brep_vertex_surfaces_topology_is_valid(
+                index_t unique_vertex_index ) const;
+
+            bool vertex_is_part_of_not_boundary_nor_internal_surface(
+                const index_t unique_vertex_index ) const;
+
+            bool vertex_is_part_of_surface_with_invalid_internal_topology(
+                const index_t unique_vertex_index ) const;
+
+            bool vertex_is_part_of_invalid_unique_surface(
+                index_t unique_vertex_index ) const;
+
+            bool vertex_is_part_of_invalid_multiple_surfaces(
+                index_t unique_vertex_index ) const;
+
+        private:
+            const BRep& brep_;
+        };
+    } // namespace detail
+} // namespace geode

src/geode/inspector/CMakeLists.txt

@@ -35,7 +35,11 @@ add_geode_library(
         "criterion/manifold/surface_vertex_manifold.cpp"
         "criterion/manifold/surface_edge_manifold.cpp"
         "criterion/private/colocation_impl.cpp"
-        "topology/brep_vertices_topology.cpp"
+        "topology/brep_topology.cpp"
+        "topology/private/brep_corners_topology_impl.cpp"
+        "topology/private/brep_lines_topology_impl.cpp"
+        "topology/private/brep_surfaces_topology_impl.cpp"
+        "topology/private/brep_blocks_topology_impl.cpp"
     PUBLIC_HEADERS
         "common.h"
         "criterion/degeneration/edgedcurve_degeneration.h"
@@ -48,10 +52,14 @@ add_geode_library(
         "criterion/adjacency/surface_adjacency.h"
         "criterion/manifold/surface_vertex_manifold.h"
         "criterion/manifold/surface_edge_manifold.h"
-        "topology/brep_vertices_topology.h"
+        "topology/brep_topology.h"
     PRIVATE_HEADERS
         "criterion/private/degeneration_impl.h"
         "criterion/private/colocation_impl.h"
+        "topology/private/brep_corners_topology_impl.h"
+        "topology/private/brep_lines_topology_impl.h"
+        "topology/private/brep_surfaces_topology_impl.h"
+        "topology/private/brep_blocks_topology_impl.h"
     PUBLIC_DEPENDENCIES
         OpenGeode::basic
     PRIVATE_DEPENDENCIES