Merge pull request #107 from Geode-solutions/fix/nodiscard

fix(OpenGeode): update to new warnings

Author: MelchiorSchuh

bindings/python/requirements.txt

@@ -2,7 +2,7 @@
 # This file is autogenerated by pip-compile with Python 3.10
 # by the following command:
 #
-#    pip-compile bindings/python/requirements.in
+#    pip-compile --pre bindings/python/requirements.in
 #
 opengeode-core==15.*,>=15.4.1
     # via -r bindings/python/requirements.in

include/geode/inspector/brep_inspector.hpp

@@ -40,9 +40,9 @@ namespace geode
         BRepMeshesInspectionResult meshes;
         BRepTopologyInspectionResult topology;
 
-        std::string string() const;
+        [[nodiscard]] std::string string() const;
 
-        std::string inspection_type() const;
+        [[nodiscard]] std::string inspection_type() const;
     };
     /*!
      * Class for inspecting a BRep model
@@ -58,6 +58,6 @@ namespace geode
     public:
         explicit BRepInspector( const BRep& brep );
 
-        BRepInspectionResult inspect_brep() const;
+        [[nodiscard]] BRepInspectionResult inspect_brep() const;
     };
 } // namespace geode

include/geode/inspector/criterion/adjacency/brep_meshes_adjacency.hpp

@@ -52,9 +52,9 @@ namespace geode
                 "BRep Block mesh with wrong adjacencies on polyhedron facets"
             };
 
-        std::string string() const;
+        [[nodiscard]] std::string string() const;
 
-        std::string inspection_type() const;
+        [[nodiscard]] std::string inspection_type() const;
     };
 
     /*!
@@ -70,7 +70,7 @@ namespace geode
 
         ~BRepComponentMeshesAdjacency();
 
-        BRepMeshesAdjacencyInspectionResult
+        [[nodiscard]] BRepMeshesAdjacencyInspectionResult
             inspect_brep_meshes_adjacencies() const;
 
     private:

include/geode/inspector/criterion/adjacency/section_meshes_adjacency.hpp

@@ -48,9 +48,9 @@ namespace geode
                 "Section Surface mesh with wrong adjacencies on polygon edges"
             };
 
-        std::string string() const;
+        [[nodiscard]] std::string string() const;
 
-        std::string inspection_type() const;
+        [[nodiscard]] std::string inspection_type() const;
     };
     /*!
      * Class for inspecting the adjacency of the surface edges in the Component
@@ -65,7 +65,7 @@ namespace geode
 
         ~SectionComponentMeshesAdjacency();
 
-        SectionMeshesAdjacencyInspectionResult
+        [[nodiscard]] SectionMeshesAdjacencyInspectionResult
             inspect_section_meshes_adjacencies() const;
 
     private:

include/geode/inspector/criterion/adjacency/solid_adjacency.hpp

@@ -49,9 +49,9 @@ namespace geode
 
         ~SolidMeshAdjacency();
 
-        bool mesh_has_wrong_adjacencies() const;
+        [[nodiscard]] bool mesh_has_wrong_adjacencies() const;
 
-        InspectionIssues< PolyhedronFacet >
+        [[nodiscard]] InspectionIssues< PolyhedronFacet >
             polyhedron_facets_with_wrong_adjacency() const;
 
     private:

include/geode/inspector/criterion/adjacency/surface_adjacency.hpp

@@ -49,9 +49,9 @@ namespace geode
 
         ~SurfaceMeshAdjacency();
 
-        bool mesh_has_wrong_adjacencies() const;
+        [[nodiscard]] bool mesh_has_wrong_adjacencies() const;
 
-        InspectionIssues< PolygonEdge >
+        [[nodiscard]] InspectionIssues< PolygonEdge >
             polygon_edges_with_wrong_adjacency() const;
 
     private:

include/geode/inspector/criterion/brep_meshes_inspector.hpp

@@ -44,9 +44,9 @@ namespace geode
         BRepMeshesManifoldInspectionResult meshes_non_manifolds;
         BRepMeshesNegativeElementsInspectionResult meshes_negative_elements;
 
-        std::string string() const;
+        [[nodiscard]] std::string string() const;
 
-        std::string inspection_type() const;
+        [[nodiscard]] std::string inspection_type() const;
     };
 
     /*!
@@ -67,6 +67,6 @@ namespace geode
     public:
         explicit BRepMeshesInspector( const BRep& brep );
 
-        BRepMeshesInspectionResult inspect_brep_meshes() const;
+        [[nodiscard]] BRepMeshesInspectionResult inspect_brep_meshes() const;
     };
 } // namespace geode

include/geode/inspector/criterion/colocation/component_meshes_colocation.hpp

@@ -44,9 +44,9 @@ namespace geode
             "Model component meshes with colocated points"
         };
 
-        std::string string() const;
+        [[nodiscard]] std::string string() const;
 
-        std::string inspection_type() const;
+        [[nodiscard]] std::string inspection_type() const;
     };
 
     /*!
@@ -63,7 +63,7 @@ namespace geode
 
         ~ComponentMeshesColocation();
 
-        MeshesColocationInspectionResult
+        [[nodiscard]] MeshesColocationInspectionResult
             inspect_meshes_point_colocations() const;
 
     private:

include/geode/inspector/criterion/colocation/edgedcurve_colocation.hpp

@@ -48,9 +48,9 @@ namespace geode
 
         ~EdgedCurveColocation();
 
-        bool mesh_has_colocated_points() const;
+        [[nodiscard]] bool mesh_has_colocated_points() const;
 
-        InspectionIssues< std::vector< index_t > >
+        [[nodiscard]] InspectionIssues< std::vector< index_t > >
             colocated_points_groups() const;
 
     private:

include/geode/inspector/criterion/colocation/pointset_colocation.hpp

@@ -48,9 +48,9 @@ namespace geode
 
         ~PointSetColocation();
 
-        bool mesh_has_colocated_points() const;
+        [[nodiscard]] bool mesh_has_colocated_points() const;
 
-        InspectionIssues< std::vector< index_t > >
+        [[nodiscard]] InspectionIssues< std::vector< index_t > >
             colocated_points_groups() const;
 
     private: