MSS review

Author: francoisbonneau

include/geode/inspector/criterion/colocation/component_meshes_colocation.hpp

@@ -41,7 +41,7 @@ namespace geode
     struct opengeode_inspector_inspector_api MeshesColocationInspectionResult
     {
         InspectionIssuesMap< std::vector< index_t > > colocated_points_groups{
-            "colocated point"
+            "colocated points"
         };
 
         [[nodiscard]] index_t nb_issues() const;

include/geode/inspector/criterion/colocation/unique_vertices_colocation.hpp

@@ -39,9 +39,9 @@ namespace geode
     struct opengeode_inspector_inspector_api UniqueVerticesInspectionResult
     {
         InspectionIssues< std::vector< index_t > >
-            colocated_unique_vertices_groups{ "colocated unique vertex" };
+            colocated_unique_vertices_groups{ "colocated unique vertices" };
         InspectionIssues< index_t > unique_vertices_linked_to_different_points{
-            "unique vertex refering multiple position"
+            "unique vertex refering multiple positions"
         };
 
         [[nodiscard]] index_t nb_issues() const;

include/geode/inspector/criterion/degeneration/brep_meshes_degeneration.hpp

@@ -41,12 +41,12 @@ namespace geode
     struct
         opengeode_inspector_inspector_api BRepMeshesDegenerationInspectionResult
     {
-        InspectionIssuesMap< index_t > degenerated_edges{ "degenerated edge" };
+        InspectionIssuesMap< index_t > degenerated_edges{ "degenerated edges" };
         InspectionIssuesMap< index_t > degenerated_polygons{
-            "degenerated polygon"
+            "degenerated polygons"
         };
         InspectionIssuesMap< index_t > degenerated_polyhedra{
-            "degenerated polyhedron"
+            "degenerated polyhedra"
         };
 
         [[nodiscard]] index_t nb_issues() const;

include/geode/inspector/criterion/manifold/brep_meshes_manifold.hpp

@@ -58,7 +58,7 @@ namespace geode
     struct opengeode_inspector_inspector_api BRepMeshesManifoldInspectionResult
     {
         InspectionIssuesMap< index_t > meshes_non_manifold_vertices{
-            "non manifold mesh vertex"
+            "non manifold mesh vertices"
         };
 
         InspectionIssuesMap< std::array< index_t, 2 > >

src/geode/inspector/criterion/degeneration/edgedcurve_degeneration.cpp

@@ -54,7 +54,7 @@ namespace geode
         InspectionIssues< index_t > small_edges( double threshold ) const
         {
             InspectionIssues< index_t > degenerated_edges_index{
-                "Degenerated Edges."
+                "degenerated Edges."
             };
             for( const auto edge_id : Range{ mesh_.nb_edges() } )
             {

src/geode/inspector/criterion/internal/degeneration_impl.cpp

@@ -72,7 +72,7 @@ namespace geode
         {
             enable_edges_on_mesh();
             InspectionIssues< index_t > degenerated_edges_index{
-                "Degenerated edges"
+                "degenerated edges"
             };
             for( const auto edge_index : Range{ mesh_.edges().nb_edges() } )
             {

src/geode/inspector/criterion/intersections/model_intersections.cpp

@@ -521,7 +521,7 @@ namespace geode
                 const auto& surface2 =
                     model_.surface( polygon_pair.second.component_id.id() );
                 intersection_issues.add_issue( polygon_pair,
-                    absl::StrCat( surface1.name(), " (",
+                    absl::StrCat( "Surfaces ", surface1.name(), " (",
                         polygon_pair.first.component_id.id().string(), ") and ",
                         surface2.name(), " (",
                         polygon_pair.second.component_id.id().string(),
@@ -544,7 +544,7 @@ namespace geode
                 intersection_issues.add_issue( polygon_pair,
                     absl::StrCat( "Surface ", surface.name(), " (",
                         polygon_pair.first.component_id.id().string(),
-                        ") have a self intersection on polygons ",
+                        ") has a self intersection on polygons ",
                         polygon_pair.first.element_id, "and ",
                         polygon_pair.second.element_id ) );
             }

src/geode/inspector/criterion/manifold/solid_edge_manifold.cpp

@@ -68,8 +68,8 @@ namespace
             {
                 const Edge polyhedron_edge{ polyhedron_edge_vertices };
                 if( !polyhedra_around_edges
-                        .try_emplace( polyhedron_edge, 1, polyhedron_id )
-                        .second )
+                         .try_emplace( polyhedron_edge, 1, polyhedron_id )
+                         .second )
                 {
                     polyhedra_around_edges[polyhedron_edge].push_back(
                         polyhedron_id );
@@ -145,9 +145,9 @@ namespace geode
                         {
                             non_manifold_edges.add_issue(
                                 polyhedron_edge_vertices,
-                                absl::StrCat( "Non manifold edge between "
-                                              "vertices with index ",
-                                    polyhedron_edge_vertices[0], " and index ",
+                                absl::StrCat(
+                                    "Non manifold edge between vertices ",
+                                    polyhedron_edge_vertices[0], " and ",
                                     polyhedron_edge_vertices[1] ) );
                         }
                     }

src/geode/inspector/criterion/manifold/solid_vertex_manifold.cpp

@@ -110,8 +110,7 @@ namespace geode
                         mesh_.polyhedra_around_vertex( vertex_id ) ) )
                 {
                     non_manifold_vertices.add_issue( vertex_id,
-                        absl::StrCat( "vertex with index ", vertex_id,
-                            ", at position [",
+                        absl::StrCat( "vertex ", vertex_id, ", at position [",
                             mesh_.point( vertex_id ).string(), "]" ) );
                 }
             }

src/geode/inspector/criterion/manifold/surface_edge_manifold.cpp

@@ -51,9 +51,9 @@ namespace
                         { polygon_id, polygon_edge_id } )
                 };
                 if( !polygons_around_edges
-                        .try_emplace( polygon_edge_vertex_cycle,
-                            std::make_pair( 1, false ) )
-                        .second )
+                         .try_emplace( polygon_edge_vertex_cycle,
+                             std::make_pair( 1, false ) )
+                         .second )
                 {
                     polygons_around_edges[polygon_edge_vertex_cycle].first += 1;
                 }
@@ -106,8 +106,8 @@ namespace geode
                 if( on_border && nb_incident_polygons != 1 )
                 {
                     non_manifold_edges.add_issue( edge.first.vertices(),
-                        absl::StrCat( "edge between vertices with index ",
-                            edge.first.vertices()[0], " and index ",
+                        absl::StrCat( "edge between vertices ",
+                            edge.first.vertices()[0], " and ",
                             edge.first.vertices()[1],
                             " is not manifold (detected as on border)." ) );
                 }