feat(Topology): Added checks to see if unique vertices are linked to existing cmvs, and if these links are bijective.

Author: MelchiorSchuh

bindings/python/src/inspector/topology/brep_topology.hpp

@@ -155,12 +155,10 @@ namespace geode
             .def( pybind11::init< const BRep& >() )
             .def( "brep_topology_is_valid",
                 &BRepTopologyInspector::brep_topology_is_valid )
-            .def( "brep_meshed_components_are_linked_to_unique_vertices",
+            .def( "brep_unique_vertices_are_bijectively_linked_to_an_existing_"
+                  "component_vertex",
                 &BRepTopologyInspector::
-                    brep_meshed_components_are_linked_to_unique_vertices )
-            .def( "brep_unique_vertices_are_linked_to_a_component_vertex",
-                &BRepTopologyInspector::
-                    brep_unique_vertices_are_linked_to_a_component_vertex )
+                    brep_unique_vertices_are_bijectively_linked_to_an_existing_component_vertex )
             .def( "inspect_brep_topology",
                 &BRepTopologyInspector::inspect_brep_topology );
     }

bindings/python/src/inspector/topology/section_topology.hpp

@@ -124,12 +124,10 @@ namespace geode
             .def( pybind11::init< const Section& >() )
             .def( "section_topology_is_valid",
                 &SectionTopologyInspector::section_topology_is_valid )
-            .def( "section_meshed_components_are_linked_to_unique_vertices",
+            .def( "section_unique_vertices_are_bijectively_linked_to_an_"
+                  "existing_component_vertex",
                 &SectionTopologyInspector::
-                    section_meshed_components_are_linked_to_unique_vertices )
-            .def( "section_unique_vertices_are_linked_to_a_component_vertex",
-                &SectionTopologyInspector::
-                    section_unique_vertices_are_linked_to_a_component_vertex )
+                    section_unique_vertices_are_bijectively_linked_to_an_existing_component_vertex )
             .def( "inspect_section_topology",
                 &SectionTopologyInspector::inspect_section_topology );
     }

include/geode/inspector/topology/brep_blocks_topology.hpp

@@ -35,6 +35,8 @@
 
 namespace geode
 {
+    FORWARD_DECLARATION_DIMENSION_CLASS( Block );
+    ALIAS_3D( Block );
     struct ComponentMeshVertex;
     class BRep;
 } // namespace geode
@@ -82,6 +84,11 @@ namespace geode
         [[nodiscard]] bool brep_blocks_topology_is_valid(
             index_t unique_vertex_index ) const;
 
+        [[nodiscard]] bool block_is_meshed( const Block3D& block ) const;
+
+        [[nodiscard]] bool block_vertices_are_associated_to_unique_vertices(
+            const Block3D& block ) const;
+
         [[nodiscard]] std::optional< std::string >
             unique_vertex_is_part_of_two_blocks_and_no_boundary_surface(
                 index_t unique_vertex_index ) const;

include/geode/inspector/topology/brep_corners_topology.hpp

@@ -33,6 +33,8 @@
 
 namespace geode
 {
+    FORWARD_DECLARATION_DIMENSION_CLASS( Corner );
+    ALIAS_3D( Corner );
     class BRep;
 } // namespace geode
 
@@ -88,6 +90,11 @@ namespace geode
         [[nodiscard]] bool brep_corner_topology_is_valid(
             index_t unique_vertex_index ) const;
 
+        [[nodiscard]] bool corner_is_meshed( const Corner3D& corner ) const;
+
+        [[nodiscard]] bool corner_vertices_are_associated_to_unique_vertices(
+            const Corner3D& corner ) const;
+
         [[nodiscard]] std::optional< std::string >
             unique_vertex_has_multiple_corners(
                 index_t unique_vertex_index ) const;

include/geode/inspector/topology/brep_lines_topology.hpp

@@ -32,6 +32,8 @@
 
 namespace geode
 {
+    FORWARD_DECLARATION_DIMENSION_CLASS( Line );
+    ALIAS_3D( Line );
     struct ComponentMeshVertex;
     class BRep;
 } // namespace geode
@@ -95,6 +97,11 @@ namespace geode
         [[nodiscard]] bool brep_lines_topology_is_valid(
             index_t unique_vertex_index ) const;
 
+        [[nodiscard]] bool line_is_meshed( const Line3D& line ) const;
+
+        [[nodiscard]] bool line_vertices_are_associated_to_unique_vertices(
+            const Line3D& line ) const;
+
         [[nodiscard]] std::optional< std::string >
             vertex_is_part_of_not_internal_nor_boundary_line(
                 index_t unique_vertex_index ) const;

include/geode/inspector/topology/brep_surfaces_topology.hpp

@@ -31,6 +31,8 @@
 
 namespace geode
 {
+    FORWARD_DECLARATION_DIMENSION_CLASS( Surface );
+    ALIAS_3D( Surface );
     class BRep;
 } // namespace geode
 
@@ -105,6 +107,11 @@ namespace geode
         [[nodiscard]] bool brep_surfaces_topology_is_valid(
             index_t unique_vertex_index ) const;
 
+        [[nodiscard]] bool surface_is_meshed( const Surface3D& surface ) const;
+
+        [[nodiscard]] bool surface_vertices_are_associated_to_unique_vertices(
+            const Surface3D& surface ) const;
+
         [[nodiscard]] std::optional< std::string >
             vertex_is_part_of_not_internal_nor_boundary_surface(
                 index_t unique_vertex_index ) const;

include/geode/inspector/topology/brep_topology.hpp

@@ -48,13 +48,22 @@ namespace geode
         InspectionIssues< index_t > unique_vertices_not_linked_to_any_component{
             "Unique vertices not linked to any component"
         };
+        InspectionIssues< index_t > unique_vertices_linked_to_inexistant_cmv{
+            "Unique vertices linked to inexistant ComponentMeshVertex"
+        };
+        InspectionIssues< index_t >
+            unique_vertices_nonbijectively_linked_to_cmv{
+                "Unique vertices with links to ComponentMeshVertex that are "
+                "not bijective"
+            };
 
         [[nodiscard]] index_t nb_issues() const;
 
         [[nodiscard]] std::string string() const;
 
         [[nodiscard]] std::string inspection_type() const;
     };
+
     /*!
      * Class for inspecting the topology of a BRep model corners
      */
@@ -78,10 +87,8 @@ namespace geode
         [[nodiscard]] bool brep_topology_is_valid() const;
 
         [[nodiscard]] bool
-            brep_meshed_components_are_linked_to_unique_vertices() const;
-
-        [[nodiscard]] bool
-            brep_unique_vertices_are_linked_to_a_component_vertex() const;
+            brep_unique_vertices_are_bijectively_linked_to_an_existing_component_vertex()
+                const;
 
         [[nodiscard]] BRepTopologyInspectionResult
             inspect_brep_topology() const;

include/geode/inspector/topology/internal/topology_helpers.hpp

@@ -68,15 +68,44 @@ namespace geode
             return component_uuids;
         }
 
+        template < typename Model, typename Mesh >
+        bool model_component_vertices_are_associated_to_unique_vertices(
+            const Model& model,
+            const ComponentID& component_id,
+            const Mesh& component_mesh )
+        {
+            for( const auto component_vertex :
+                Range{ component_mesh.nb_vertices() } )
+            {
+                if( model.unique_vertex( { component_id, component_vertex } )
+                    == NO_ID )
+                {
+                    return false;
+                }
+            }
+            return true;
+        }
+
+        template < typename Model, typename Mesh >
         [[nodiscard]] InspectionIssues< index_t >
-            brep_component_vertices_not_associated_to_unique_vertices(
-                const BRep& brep,
-                const ComponentID& component_id,
-                const VertexSet& component_mesh );
-        [[nodiscard]] InspectionIssues< index_t >
-            section_component_vertices_are_associated_to_unique_vertices(
-                const Section& section,
+            model_component_vertices_not_associated_to_unique_vertices(
+                const Model& model,
                 const ComponentID& component_id,
-                const VertexSet& component_mesh );
+                const Mesh& component_mesh )
+        {
+            InspectionIssues< index_t > result;
+            for( const auto vertex_id : Range{ component_mesh.nb_vertices() } )
+            {
+                ComponentMeshVertex component_mesh_vertex{ component_id,
+                    vertex_id };
+                if( model.unique_vertex( component_mesh_vertex ) == NO_ID )
+                {
+                    result.add_issue( vertex_id,
+                        absl::StrCat( "Vertex '", vertex_id,
+                            "' is not linked to a unique vertex." ) );
+                }
+            }
+            return result;
+        }
     } // namespace internal
 } // namespace geode

include/geode/inspector/topology/section_corners_topology.hpp

@@ -32,6 +32,8 @@
 
 namespace geode
 {
+    FORWARD_DECLARATION_DIMENSION_CLASS( Corner );
+    ALIAS_2D( Corner );
     class Section;
 } // namespace geode
 
@@ -88,6 +90,11 @@ namespace geode
         [[nodiscard]] bool section_corner_topology_is_valid(
             index_t unique_vertex_index ) const;
 
+        [[nodiscard]] bool corner_is_meshed( const Corner2D& corner ) const;
+
+        [[nodiscard]] bool corner_vertices_are_associated_to_unique_vertices(
+            const Corner2D& corner ) const;
+
         [[nodiscard]] std::optional< std::string >
             unique_vertex_has_multiple_corners(
                 index_t unique_vertex_index ) const;

include/geode/inspector/topology/section_lines_topology.hpp

@@ -30,6 +30,8 @@
 
 namespace geode
 {
+    FORWARD_DECLARATION_DIMENSION_CLASS( Line );
+    ALIAS_2D( Line );
     class Section;
 } // namespace geode
 
@@ -95,6 +97,11 @@ namespace geode
         [[nodiscard]] bool section_lines_topology_is_valid(
             index_t unique_vertex_index ) const;
 
+        [[nodiscard]] bool line_is_meshed( const Line2D& line ) const;
+
+        [[nodiscard]] bool line_vertices_are_associated_to_unique_vertices(
+            const Line2D& line ) const;
+
         [[nodiscard]] std::optional< std::string >
             vertex_is_part_of_not_internal_nor_boundary_line(
                 const index_t unique_vertex_index ) const;