fix(SegFault): avoid segfault and trigger warning if there are problems due to unique_vertices

Author: panquez

src/geode/inspector/criterion/internal/component_meshes_adjacency.cpp

@@ -43,6 +43,9 @@ namespace
     {
         const auto edge_unique_vertices =
             geode::edge_unique_vertices( model, surface, polygon_edge );
+        OPENGEODE_EXCEPTION( edge_unique_vertices[0] != geode::NO_ID
+                                 && edge_unique_vertices[1] != geode::NO_ID,
+            "[ComponentMeshesAdjacency] Missing unique_vertices" );
         return !geode::detail::line_component_mesh_edges(
             model, edge_unique_vertices )
                     .empty();
@@ -79,10 +82,22 @@ namespace geode
                     LRange{ mesh.nb_polygon_edges( polygon_id ) } )
                 {
                     const PolygonEdge polygon_edge{ polygon_id, edge_id };
-                    if( mesh.is_edge_on_border( polygon_edge )
-                        && !polygon_edge_is_on_a_line(
-                            model_, surface, polygon_edge ) )
+                    try
                     {
+                        if( mesh.is_edge_on_border( polygon_edge )
+                            && !polygon_edge_is_on_a_line(
+                                model_, surface, polygon_edge ) )
+                        {
+                            issues.add_issue( polygon_edge,
+                                absl::StrCat( "Local edge ", edge_id,
+                                    " of polygon ", polygon_id,
+                                    " has no adjacencies but is not part of a "
+                                    "model Line." ) );
+                        }
+                    }
+                    catch( const OpenGeodeException& e )
+                    {
+                        Logger::warn( e.what() );
                         issues.add_issue( polygon_edge,
                             absl::StrCat( "Local edge ", edge_id,
                                 " of polygon ", polygon_id,

tests/data/test.shp

@@ -170,5 +170,6 @@ add_geode_test(
         OpenGeode::geometry
         OpenGeode::mesh
         OpenGeode::model
+        OpenGeode-GeosciencesIO::model
         ${PROJECT_NAME}::inspector
 )

tests/data/test.shx

@@ -30,6 +30,8 @@
 #include <geode/model/representation/core/section.hpp>
 #include <geode/model/representation/io/section_input.hpp>
 
+#include <geode/geosciences_io/model/common.hpp>
+
 #include <geode/inspector/section_inspector.hpp>
 
 geode::index_t corners_topological_validity(
@@ -276,12 +278,26 @@ void check_section( bool string )
         nb_component_meshes_issues, " meshes problems instead of 0." );
 }
 
+void check_section_test()
+{
+    const auto model_section =
+        geode::load_section( absl::StrCat( geode::DATA_PATH, "test.shp" ) );
+    geode::SectionInspector section_inspector{ model_section };
+    auto result = section_inspector.inspect_section();
+
+    geode::Logger::info( "vertical_lines section topology is ",
+        section_inspector.section_topology_is_valid() ? "valid." : "invalid." );
+}
+
 int main()
 {
     try
     {
         geode::InspectorInspectorLibrary::initialize();
+        geode::GeosciencesIOModelLibrary::initialize();
+        geode::Logger::set_level( geode::Logger::LEVEL::trace );
         check_section( false );
+        check_section_test();
 
         geode::Logger::info( "TEST SUCCESS" );
         return 0;