review changes

Author: benoit2776

include/geode/inspector/criterion/degeneration/brep_meshes_degeneration.hpp

@@ -75,10 +75,10 @@ namespace geode
             inspect_elements_degeneration() const;
 
         [[nodiscard]] BRepMeshesDegenerationInspectionResult
-            inspect_polygons_degeneration( double threshold ) const;
+            inspect_edges_degeneration( double threshold ) const;
 
         [[nodiscard]] BRepMeshesDegenerationInspectionResult
-            inspect_edges_degeneration( double threshold ) const;
+            inspect_polygons_degeneration( double threshold ) const;
 
         [[nodiscard]] BRepMeshesDegenerationInspectionResult
             inspect_polyhedra_degeneration( double threshold ) const;

include/geode/inspector/criterion/internal/degeneration_impl.hpp

@@ -47,7 +47,7 @@ namespace geode
             [[nodiscard]] InspectionIssues< index_t > degenerated_edges() const;
 
         private:
-            [[nodiscard]] bool is_edge_smaller_than_threshold(
+            [[nodiscard]] bool edge_is_smaller_than_threshold(
                 index_t edge_index, double threshold ) const;
 
             [[nodiscard]] bool edge_is_degenerated( index_t edge_index ) const;

src/geode/inspector/criterion/degeneration/brep_meshes_degeneration.cpp

@@ -77,24 +77,24 @@ namespace geode
         }
 
         void add_solid_small_elements(
-            InspectionIssuesMap< index_t >& degenerated_edges_map,
-            InspectionIssuesMap< index_t >& degenerated_polyhedra_map,
+            InspectionIssuesMap< index_t >& small_edges_map,
+            InspectionIssuesMap< index_t >& small_polyhedra_map,
             double threshold ) const
         {
             for( const auto& block : model().blocks() )
             {
                 const geode::SolidMeshDegeneration3D inspector{ block.mesh() };
-                auto degenerated_edges = inspector.small_edges( threshold );
-                degenerated_edges.set_description( absl::StrCat(
-                    "Block ", block.id().string(), " degenerated edges" ) );
-                degenerated_edges_map.add_issues_to_map(
-                    block.id(), std::move( degenerated_edges ) );
-                auto degenerated_polyhedra =
+                auto small_edges = inspector.small_edges( threshold );
+                small_edges.set_description( absl::StrCat(
+                    "Block ", block.id().string(), " small edges" ) );
+                small_edges_map.add_issues_to_map(
+                    block.id(), std::move( small_edges ) );
+                auto small_polyhedra =
                     inspector.small_height_polyhedra( threshold );
-                degenerated_polyhedra.set_description( absl::StrCat(
-                    "Block ", block.id().string(), " degenerated polyhedra" ) );
-                degenerated_polyhedra_map.add_issues_to_map(
-                    block.id(), std::move( degenerated_polyhedra ) );
+                small_polyhedra.set_description( absl::StrCat( "Block ",
+                    block.id().string(), " small height polyhedra" ) );
+                small_polyhedra_map.add_issues_to_map(
+                    block.id(), std::move( small_polyhedra ) );
             }
         }
 

src/geode/inspector/criterion/internal/component_meshes_degeneration.cpp

@@ -48,7 +48,7 @@ namespace geode
 
         template < typename Model >
         void ComponentMeshesDegeneration< Model >::add_small_edges(
-            InspectionIssuesMap< index_t >& components_degenerated_edges,
+            InspectionIssuesMap< index_t >& components_small_edges,
             double threshold ) const
         {
             for( const auto& line : model_.lines() )
@@ -58,8 +58,8 @@ namespace geode
                 };
                 auto issues = inspector.small_edges( threshold );
                 issues.set_description( absl::StrCat(
-                    "Line ", line.id().string(), " degenerated edges" ) );
-                components_degenerated_edges.add_issues_to_map(
+                    "Line ", line.id().string(), " small edges" ) );
+                components_small_edges.add_issues_to_map(
                     line.id(), std::move( issues ) );
             }
             for( const auto& surface : model_.surfaces() )
@@ -69,8 +69,8 @@ namespace geode
                 };
                 auto issues = inspector.small_edges( threshold );
                 issues.set_description( absl::StrCat(
-                    "Surface ", surface.id().string(), " degenerated edges" ) );
-                components_degenerated_edges.add_issues_to_map(
+                    "Surface ", surface.id().string(), " small edges" ) );
+                components_small_edges.add_issues_to_map(
                     surface.id(), std::move( issues ) );
             }
         }
@@ -84,7 +84,7 @@ namespace geode
 
         template < typename Model >
         void ComponentMeshesDegeneration< Model >::add_small_height_polygons(
-            InspectionIssuesMap< index_t >& components_degenerated_polygons,
+            InspectionIssuesMap< index_t >& components_small_polygons,
             double threshold ) const
         {
             for( const auto& surface : model_.surfaces() )
@@ -93,9 +93,9 @@ namespace geode
                     surface.mesh()
                 };
                 auto issues = inspector.small_height_polygons( threshold );
-                issues.set_description( absl::StrCat( "Surface ",
-                    surface.id().string(), " degenerated polygons" ) );
-                components_degenerated_polygons.add_issues_to_map(
+                issues.set_description( absl::StrCat(
+                    "Surface ", surface.id().string(), " small polygons" ) );
+                components_small_polygons.add_issues_to_map(
                     surface.id(), std::move( issues ) );
             }
         }

src/geode/inspector/criterion/internal/degeneration_impl.cpp

@@ -79,7 +79,7 @@ namespace geode
             };
             for( const auto edge_index : Range{ mesh_.edges().nb_edges() } )
             {
-                if( is_edge_smaller_than_threshold( edge_index, threshold ) )
+                if( edge_is_smaller_than_threshold( edge_index, threshold ) )
                 {
                     const auto edge_vertices =
                         mesh_.edges().edge_vertices( edge_index );
@@ -102,7 +102,7 @@ namespace geode
         }
 
         template < class MeshType >
-        bool DegenerationImpl< MeshType >::is_edge_smaller_than_threshold(
+        bool DegenerationImpl< MeshType >::edge_is_smaller_than_threshold(
             index_t edge_index, double threshold ) const
         {
             const auto edge_vertices =
@@ -116,7 +116,7 @@ namespace geode
         bool DegenerationImpl< MeshType >::edge_is_degenerated(
             index_t edge_index ) const
         {
-            return is_edge_smaller_than_threshold( edge_index, GLOBAL_EPSILON );
+            return edge_is_smaller_than_threshold( edge_index, GLOBAL_EPSILON );
         }
 
         template < class MeshType >