PA review

francoisbonneau · francoisbonneau · commit 574e90d56672 · 2025-11-03T10:04:04.000+01:00
diff --git a/include/geode/inspector/topology/brep_blocks_topology.hpp b/include/geode/inspector/topology/brep_blocks_topology.hpp
@@ -46,10 +46,10 @@ namespace geode
     struct opengeode_inspector_inspector_api BRepBlocksTopologyInspectionResult
     {
         InspectionIssues< uuid > some_blocks_not_meshed{
-            "blocks without mesh (UUIDs listed)"
+            "blocks without mesh (uuid listed)"
         };
         InspectionIssues< uuid > wrong_block_boundary_surface{
-            "surfaces incorrectly bounding blocks (UUIDs listed)"
+            "surfaces incorrectly bounding blocks (uuids listed)"
         };
         InspectionIssuesMap< index_t > blocks_not_linked_to_a_unique_vertex{
             "blocks containing mesh vertices not linked to unique vertices"
@@ -77,7 +77,7 @@ namespace geode
             "blocks with non-closed boundary surfaces"
         };
         InspectionIssues< index_t > model_boundaries_dont_form_a_closed_surface{
-            "model boundaries don't form a closed surface (UUIDs listed)"
+            "model boundaries don't form a closed surface (uuids listed)"
         };
         InspectionIssues< index_t >
             unique_vertex_linked_to_multiple_invalid_surfaces{
diff --git a/include/geode/inspector/topology/brep_corners_topology.hpp b/include/geode/inspector/topology/brep_corners_topology.hpp
@@ -43,7 +43,7 @@ namespace geode
     struct opengeode_inspector_inspector_api BRepCornersTopologyInspectionResult
     {
         InspectionIssues< uuid > corners_not_meshed{
-            "corners without mesh (UUIDs listed)"
+            "corners without mesh (uuids listed)"
         };
         InspectionIssuesMap< index_t > corners_not_linked_to_a_unique_vertex{
             "corners containing mesh vertices not linked to unique vertices"
diff --git a/include/geode/inspector/topology/brep_lines_topology.hpp b/include/geode/inspector/topology/brep_lines_topology.hpp
@@ -43,7 +43,7 @@ namespace geode
     struct opengeode_inspector_inspector_api BRepLinesTopologyInspectionResult
     {
         InspectionIssues< uuid > lines_not_meshed{
-            "lines without mesh (UUIDs listed)"
+            "lines without mesh (uuids listed)"
         };
         InspectionIssues< index_t >
             unique_vertices_linked_to_line_with_wrong_relationship_to_surface{
diff --git a/include/geode/inspector/topology/brep_surfaces_topology.hpp b/include/geode/inspector/topology/brep_surfaces_topology.hpp
@@ -42,7 +42,7 @@ namespace geode
         opengeode_inspector_inspector_api BRepSurfacesTopologyInspectionResult
     {
         InspectionIssues< uuid > surfaces_not_meshed{
-            "surface without mesh (UUIDs listed)"
+            "surface without mesh (uuids listed)"
         };
         InspectionIssuesMap< index_t > surfaces_not_linked_to_a_unique_vertex{
             "surfaces containing mesh vertices not linked to unique vertices"
diff --git a/include/geode/inspector/topology/section_corners_topology.hpp b/include/geode/inspector/topology/section_corners_topology.hpp
@@ -43,7 +43,7 @@ namespace geode
         opengeode_inspector_inspector_api SectionCornersTopologyInspectionResult
     {
         InspectionIssues< uuid > corners_not_meshed{
-            "corners without mesh (UUIDs listed)"
+            "corners without mesh (uuids listed)"
         };
         InspectionIssuesMap< index_t > corners_not_linked_to_a_unique_vertex{
             "corners containing mesh vertices not linked to unique vertices"
diff --git a/include/geode/inspector/topology/section_lines_topology.hpp b/include/geode/inspector/topology/section_lines_topology.hpp
@@ -41,7 +41,7 @@ namespace geode
         opengeode_inspector_inspector_api SectionLinesTopologyInspectionResult
     {
         InspectionIssues< uuid > lines_not_meshed{
-            "lines without mesh (UUIDs listed)"
+            "lines without mesh (uuids listed)"
         };
         InspectionIssuesMap< index_t > lines_not_linked_to_a_unique_vertex{
             "lines with mesh vertices not linked to a unique vertex"
diff --git a/include/geode/inspector/topology/section_surfaces_topology.hpp b/include/geode/inspector/topology/section_surfaces_topology.hpp
@@ -42,7 +42,7 @@ namespace geode
         opengeode_inspector_inspector_api SectionSurfacesTopologyInspectionResult
     {
         InspectionIssues< uuid > surfaces_not_meshed{
-            "surface without mesh (UUIDs listed)"
+            "surface without mesh (uuids listed)"
         };
         InspectionIssuesMap< index_t > surfaces_not_linked_to_a_unique_vertex{
             "surfaces containing mesh vertices not linked to unique vertices"
diff --git a/src/geode/inspector/criterion/colocation/component_meshes_colocation.cpp b/src/geode/inspector/criterion/colocation/component_meshes_colocation.cpp
@@ -146,7 +146,7 @@ namespace
             if( !colocated_pts.empty() )
             {
                 geode::InspectionIssues< std::vector< geode::index_t > >
-                    surface_issues{ absl::StrCat( "Surface ", surface.name(),
+                    surface_issues{ absl::StrCat( "surface ", surface.name(),
                         " colocated vertices - uuid ",
                         surface.id().string() ) };
                 const auto& surface_mesh = surface.mesh();
@@ -196,7 +196,7 @@ namespace
             if( !colocated_pts.empty() )
             {
                 geode::InspectionIssues< std::vector< geode::index_t > >
-                    block_issues{ absl::StrCat( "Block ", block.name(),
+                    block_issues{ absl::StrCat( "block ", block.name(),
                         " colocated vertices - uuid ", block.id().string() ) };
                 const auto& block_mesh = block.mesh();
                 for( const auto& colocated_points_group : colocated_pts )
diff --git a/src/geode/inspector/criterion/degeneration/edgedcurve_degeneration.cpp b/src/geode/inspector/criterion/degeneration/edgedcurve_degeneration.cpp
@@ -61,7 +61,7 @@ namespace geode
                 if( mesh_.edge_length( edge_id ) <= threshold )
                 {
                     degenerated_edges_index.add_issue( edge_id,
-                        absl::StrCat( "Edge ", edge_id, ", at position [",
+                        absl::StrCat( "edge ", edge_id, ", at position [",
                             mesh_.edge_barycenter( edge_id ).string(), "]" ) );
                 }
             }
diff --git a/src/geode/inspector/criterion/internal/component_meshes_degeneration.cpp b/src/geode/inspector/criterion/internal/component_meshes_degeneration.cpp
@@ -102,7 +102,7 @@ namespace geode
                         const geode::SurfaceMeshDegeneration< Model::dim >
                             inspector{ surface.mesh() };
                         auto issues = inspector.small_edges( threshold );
-                        issues.set_description( absl::StrCat( "Surface ",
+                        issues.set_description( absl::StrCat( "surface ",
                             surface.name(), " small facet edges - uuid ",
                             surface.id().string() ) );
                         return std::make_pair(
@@ -141,7 +141,7 @@ namespace geode
                     const geode::SurfaceMeshDegeneration< Model::dim >
                         inspector{ surface.mesh() };
                     auto issues = inspector.small_height_polygons( threshold );
-                    issues.set_description( absl::StrCat( "Surface ",
+                    issues.set_description( absl::StrCat( "surface ",
                         surface.name(), " small height polygons - uuid ",
                         surface.id().string() ) );
                     return std::make_pair( surface.id(), std::move( issues ) );
diff --git a/src/geode/inspector/criterion/intersections/model_intersections.cpp b/src/geode/inspector/criterion/intersections/model_intersections.cpp
@@ -522,7 +522,7 @@ namespace geode
                     model_.surface( polygon_pair.second.component_id.id() );
                 intersection_issues.add_issue( polygon_pair,
                     absl::StrCat( surface1.name(), " and ", surface2.name(),
-                        " intersect each other on polygons ",
+                        " intersect on polygons ",
                         polygon_pair.first.element_id, " and ",
                         polygon_pair.second.element_id, " - uuids ",
                         polygon_pair.first.component_id.id().string(), " and ",
diff --git a/src/geode/inspector/criterion/negative_elements/brep_meshes_negative_elements.cpp b/src/geode/inspector/criterion/negative_elements/brep_meshes_negative_elements.cpp
@@ -69,7 +69,7 @@ namespace geode
                 };
                 auto negative_elements = inspector.negative_polyhedra();
                 negative_elements.set_description(
-                    absl::StrCat( "Block ", block.name(),
+                    absl::StrCat( "block ", block.name(),
                         " negative polyhedra - uuid ", block.id().string() ) );
                 result.negative_polyhedra.add_issues_to_map(
                     block.id(), std::move( negative_elements ) );
diff --git a/src/geode/inspector/criterion/negative_elements/solid_negative_elements.cpp b/src/geode/inspector/criterion/negative_elements/solid_negative_elements.cpp
@@ -56,7 +56,7 @@ namespace geode
         InspectionIssues< index_t > negative_polyhedra() const
         {
             InspectionIssues< index_t > wrong_polyhedra{
-                "Negative Volume Polyhedra"
+                "negative volume polyhedra"
             };
             for( const auto polyhedron_id : Range{ mesh_.nb_polyhedra() } )
             {
diff --git a/src/geode/inspector/criterion/negative_elements/surface_negative_elements.cpp b/src/geode/inspector/criterion/negative_elements/surface_negative_elements.cpp
@@ -57,7 +57,7 @@ namespace geode
         InspectionIssues< index_t > negative_polygons() const
         {
             InspectionIssues< index_t > wrong_polygons{
-                "Negative Area Polygons"
+                "Negative area polygons"
             };
             for( const auto polygon_id : Range{ mesh_.nb_polygons() } )
             {

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ namespace geode`
`43`	`43`	`struct opengeode_inspector_inspector_api BRepCornersTopologyInspectionResult`
`44`	`44`	`{`
`45`	`45`	`InspectionIssues< uuid > corners_not_meshed{`
`46`		`- "corners without mesh (UUIDs listed)"`
	`46`	`+ "corners without mesh (uuids listed)"`
`47`	`47`	`};`
`48`	`48`	`InspectionIssuesMap< index_t > corners_not_linked_to_a_unique_vertex{`
`49`	`49`	`"corners containing mesh vertices not linked to unique vertices"`
Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ namespace geode`
`42`	`42`	`opengeode_inspector_inspector_api BRepSurfacesTopologyInspectionResult`
`43`	`43`	`{`
`44`	`44`	`InspectionIssues< uuid > surfaces_not_meshed{`
`45`		`- "surface without mesh (UUIDs listed)"`
	`45`	`+ "surface without mesh (uuids listed)"`
`46`	`46`	`};`
`47`	`47`	`InspectionIssuesMap< index_t > surfaces_not_linked_to_a_unique_vertex{`
`48`	`48`	`"surfaces containing mesh vertices not linked to unique vertices"`
Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ namespace geode`
`41`	`41`	`opengeode_inspector_inspector_api SectionLinesTopologyInspectionResult`
`42`	`42`	`{`
`43`	`43`	`InspectionIssues< uuid > lines_not_meshed{`
`44`		`- "lines without mesh (UUIDs listed)"`
	`44`	`+ "lines without mesh (uuids listed)"`
`45`	`45`	`};`
`46`	`46`	`InspectionIssuesMap< index_t > lines_not_linked_to_a_unique_vertex{`
`47`	`47`	`"lines with mesh vertices not linked to a unique vertex"`
Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@ namespace geode`
`61`	`61`	`if( mesh_.edge_length( edge_id ) <= threshold )`
`62`	`62`	`{`
`63`	`63`	`degenerated_edges_index.add_issue( edge_id,`
`64`		`- absl::StrCat( "Edge ", edge_id, ", at position [",`
	`64`	`+ absl::StrCat( "edge ", edge_id, ", at position [",`
`65`	`65`	`mesh_.edge_barycenter( edge_id ).string(), "]" ) );`
`66`	`66`	`}`
`67`	`67`	`}`