fix(Degeneration): use OpenGeode meshes defintion or degeneration

Author: panquez

src/geode/inspector/criterion/degeneration/brep_meshes_degeneration.cpp

@@ -58,7 +58,7 @@ namespace geode
 
     std::string BRepMeshesDegenerationInspectionResult::inspection_type() const
     {
-        return "Adjacencies inspection";
+        return "Degeneration inspection";
     }
 
     class BRepComponentMeshesDegeneration::Impl

src/geode/inspector/criterion/degeneration/edgedcurve_degeneration.cpp

@@ -41,9 +41,9 @@ namespace geode
 
         bool is_mesh_degenerated() const
         {
-            for( const auto edge_index : Range{ mesh_.nb_edges() } )
+            for( const auto edge_id : Range{ mesh_.nb_edges() } )
             {
-                if( mesh_.edge_length( edge_index ) < global_epsilon )
+                if( mesh_.is_edge_degenerated( edge_id ) )
                 {
                     return true;
                 }
@@ -56,15 +56,15 @@ namespace geode
             InspectionIssues< index_t > degenerated_edges_index{
                 "Degenerated Edges of EdgeCurve " + mesh_.id().string() + "."
             };
-            for( const auto edge_index : Range{ mesh_.nb_edges() } )
+            for( const auto edge_id : Range{ mesh_.nb_edges() } )
             {
-                if( mesh_.edge_length( edge_index ) < global_epsilon )
+                if( mesh_.is_edge_degenerated( edge_id ) )
                 {
-                    degenerated_edges_index.add_issue( edge_index,
-                        absl::StrCat( "Edge with index ", edge_index,
-                            ", at position [",
-                            mesh_.edge_barycenter( edge_index ).string(),
-                            "], is degenerated." ) );
+                    degenerated_edges_index.add_issue(
+                        edge_id, absl::StrCat( "Edge with index ", edge_id,
+                                     ", at position [",
+                                     mesh_.edge_barycenter( edge_id ).string(),
+                                     "], is degenerated." ) );
                 }
             }
             return degenerated_edges_index;

src/geode/inspector/criterion/degeneration/section_meshes_degeneration.cpp

@@ -55,7 +55,7 @@ namespace geode
     std::string
         SectionMeshesDegenerationInspectionResult::inspection_type() const
     {
-        return "Adjacencies inspection";
+        return "Degeneration inspection";
     }
 
     class SectionComponentMeshesDegeneration::Impl

src/geode/inspector/criterion/degeneration/solid_degeneration.cpp

@@ -55,7 +55,7 @@ namespace geode
             for( const auto polyhedron_id :
                 Range{ this->mesh().nb_polyhedra() } )
             {
-                if( polyhedron_is_degenerated( polyhedron_id ) )
+                if( this->mesh().is_polyhedron_degenerated( polyhedron_id ) )
                 {
                     return true;
                 }
@@ -71,7 +71,7 @@ namespace geode
             for( const auto polyhedron_id :
                 Range{ this->mesh().nb_polyhedra() } )
             {
-                if( polyhedron_is_degenerated( polyhedron_id ) )
+                if( this->mesh().is_polyhedron_degenerated( polyhedron_id ) )
                 {
                     wrong_polyhedra.add_issue( polyhedron_id,
                         absl::StrCat( "Polyhedron ", polyhedron_id,
@@ -81,17 +81,6 @@ namespace geode
             }
             return wrong_polyhedra;
         }
-
-    private:
-        bool polyhedron_is_degenerated( index_t polyhedron_id ) const
-        {
-            const auto& mesh = this->mesh();
-            if( mesh.polyhedron_volume( polyhedron_id ) > global_epsilon )
-            {
-                return false;
-            }
-            return true;
-        }
     };
 
     template < index_t dimension >

src/geode/inspector/criterion/degeneration/surface_degeneration.cpp

@@ -54,7 +54,7 @@ namespace geode
             }
             for( const auto polygon_id : Range{ this->mesh().nb_polygons() } )
             {
-                if( polygon_is_degenerated( polygon_id ) )
+                if( this->mesh().is_polygon_degenerated( polygon_id ) )
                 {
                     return true;
                 }
@@ -69,7 +69,7 @@ namespace geode
             };
             for( const auto polygon_id : Range{ this->mesh().nb_polygons() } )
             {
-                if( polygon_is_degenerated( polygon_id ) )
+                if( this->mesh().is_polygon_degenerated( polygon_id ) )
                 {
                     wrong_polygons.add_issue( polygon_id,
                         absl::StrCat( "Polygon ", polygon_id, " of Surface ",
@@ -78,17 +78,6 @@ namespace geode
             }
             return wrong_polygons;
         }
-
-    private:
-        bool polygon_is_degenerated( index_t polygon_id ) const
-        {
-            const auto& mesh = this->mesh();
-            if( mesh.polygon_area( polygon_id ) > global_epsilon )
-            {
-                return false;
-            }
-            return true;
-        }
     };
 
     template < index_t dimension >