Skip to content

Commit 6908399

Browse files
committed
fix(BRepTopology): Fixed tests in case of mesh vertices not linked to unique vertices.
1 parent 1b588a5 commit 6908399

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

src/geode/inspector/topology/brep_lines_topology.cpp

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -461,7 +461,6 @@ namespace geode
461461
line.id(), absl::StrCat( line.id().string(),
462462
" is a line without mesh." ) );
463463
}
464-
465464
auto line_result = internal::
466465
model_component_vertices_not_associated_to_unique_vertices(
467466
brep_, line.component_id(), line.mesh() );
@@ -471,6 +470,9 @@ namespace geode
471470
absl::StrCat( "Line ", line.id().string() ) );
472471
result.lines_not_linked_to_a_unique_vertex.add_issues_to_map(
473472
line.id(), std::move( line_result ) );
473+
/// Next test may result in SegFaults if component vertices are
474+
/// not associated to unique vertices
475+
continue;
474476
}
475477
InspectionIssues< index_t > line_edges_with_wrong_cme{ absl::StrCat(
476478
"Line ", line.id().string() ) };

src/geode/inspector/topology/brep_surfaces_topology.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -388,6 +388,9 @@ namespace geode
388388
absl::StrCat( "Surface ", surface.id().string() ) );
389389
result.surfaces_not_linked_to_a_unique_vertex.add_issues_to_map(
390390
surface.id(), std::move( surface_result ) );
391+
/// Next test may result in SegFaults if component vertices are
392+
/// not associated to unique vertices
393+
continue;
391394
}
392395
if( !meshed_blocks )
393396
{

0 commit comments

Comments
 (0)