Merge pull request #95 from Geode-solutions/fix/default_message_if_inspection_is_not_done

fix(MeshesInspectors): Added default messages in InspectionResult str…

Author: panquez

bindings/python/requirements.txt

@@ -2,7 +2,7 @@
 # This file is autogenerated by pip-compile with Python 3.10
 # by the following command:
 #
-#    pip-compile bindings/python/requirements.in
+#    pip-compile --pre bindings/python/requirements.in
 #
-opengeode-core==14.*,>=14.19.1
+opengeode-core==14.*,>=14.19.2
     # via -r bindings/python/requirements.in

bindings/python/src/inspector/surface_inspector.h

@@ -64,7 +64,9 @@ namespace geode
                 return inspector.inspect_surface();
             } );
 
-        module.def( "inspect_triangulated_surface",
+        const auto inspect_function_name2 =
+            absl::StrCat( "inspect_triangulated_surface", dimension, "D" );
+        module.def( inspect_function_name2.c_str(),
             []( const TriangulatedSurface& surface ) {
                 TriangulatedSurfaceInspector inspector{ surface };
                 return inspector.inspect_surface();

include/geode/inspector/edgedcurve_inspector.h

@@ -32,8 +32,12 @@ namespace geode
 {
     struct opengeode_inspector_inspector_api EdgedCurveInspectionResult
     {
-        InspectionIssues< std::vector< index_t > > colocated_points_groups;
-        InspectionIssues< index_t > degenerated_edges;
+        InspectionIssues< std::vector< index_t > > colocated_points_groups{
+            "Colocation of vertices not tested"
+        };
+        InspectionIssues< index_t > degenerated_edges{
+            "Degeneration of edges not tested"
+        };
 
         std::string string() const;
 

include/geode/inspector/pointset_inspector.h

@@ -31,7 +31,9 @@ namespace geode
 {
     struct opengeode_inspector_inspector_api PointSetInspectionResult
     {
-        InspectionIssues< std::vector< index_t > > colocated_points_groups;
+        InspectionIssues< std::vector< index_t > > colocated_points_groups{
+            "Colocation of vertices not tested"
+        };
 
         std::string string() const;
 

include/geode/inspector/solid_inspector.h

@@ -37,13 +37,27 @@ namespace geode
     struct opengeode_inspector_inspector_api SolidInspectionResult
     {
         InspectionIssues< PolyhedronFacet >
-            polyhedron_facets_with_wrong_adjacency;
-        InspectionIssues< std::vector< index_t > > colocated_points_groups;
-        InspectionIssues< index_t > degenerated_edges;
-        InspectionIssues< index_t > degenerated_polyhedra;
-        InspectionIssues< index_t > non_manifold_vertices;
-        InspectionIssues< std::array< index_t, 2 > > non_manifold_edges;
-        InspectionIssues< PolyhedronFacetVertices > non_manifold_facets;
+            polyhedron_facets_with_wrong_adjacency{
+                "Adjacencies of facets not tested"
+            };
+        InspectionIssues< std::vector< index_t > > colocated_points_groups{
+            "Colocation of vertices not tested"
+        };
+        InspectionIssues< index_t > degenerated_edges{
+            "Degeneration of edges not tested"
+        };
+        InspectionIssues< index_t > degenerated_polyhedra{
+            "Degeneration of polyhedra not tested"
+        };
+        InspectionIssues< index_t > non_manifold_vertices{
+            "Manifold of vertices not tested"
+        };
+        InspectionIssues< std::array< index_t, 2 > > non_manifold_edges{
+            "Manifold of edges not tested"
+        };
+        InspectionIssues< PolyhedronFacetVertices > non_manifold_facets{
+            "Manifold of facets not tested"
+        };
 
         std::string string() const;
 

include/geode/inspector/surface_inspector.h

@@ -36,13 +36,27 @@ namespace geode
 {
     struct opengeode_inspector_inspector_api SurfaceInspectionResult
     {
-        InspectionIssues< PolygonEdge > polygon_edges_with_wrong_adjacency;
-        InspectionIssues< std::vector< index_t > > colocated_points_groups;
-        InspectionIssues< index_t > degenerated_edges;
-        InspectionIssues< index_t > degenerated_polygons;
-        InspectionIssues< std::array< index_t, 2 > > non_manifold_edges;
-        InspectionIssues< index_t > non_manifold_vertices;
-        InspectionIssues< std::pair< index_t, index_t > > intersecting_elements;
+        InspectionIssues< PolygonEdge > polygon_edges_with_wrong_adjacency{
+            "Adjacencies between polygon edges not tested"
+        };
+        InspectionIssues< std::vector< index_t > > colocated_points_groups{
+            "Colocation of vertices not tested"
+        };
+        InspectionIssues< index_t > degenerated_edges{
+            "Degeneration of edges not tested"
+        };
+        InspectionIssues< index_t > degenerated_polygons{
+            "Degeneration of polygons not tested"
+        };
+        InspectionIssues< std::array< index_t, 2 > > non_manifold_edges{
+            "Manifold of edges not tested"
+        };
+        InspectionIssues< index_t > non_manifold_vertices{
+            "Manifold of vertices not tested"
+        };
+        InspectionIssues< std::pair< index_t, index_t > > intersecting_elements{
+            "Intersection between mesh elements not tested"
+        };
 
         std::string string() const;