Skip to content

Commit aae4233

Browse files
committed
Updated messages to make sure return to line is done.
1 parent 014e793 commit aae4233

25 files changed

+88
-120
lines changed

include/geode/inspector/information.hpp

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,13 +72,14 @@ namespace geode
7272
{
7373
if( issues_.empty() )
7474
{
75-
return absl::StrCat( description_, " -> No Issues :)" );
75+
return absl::StrCat( description_, " -> No Issues :) \n" );
7676
}
7777
auto message = absl::StrCat( description_ );
7878
for( const auto& issue : messages_ )
7979
{
8080
absl::StrAppend( &message, "\n -> ", issue );
8181
}
82+
absl::StrAppend( &message, "\n" );
8283
return message;
8384
}
8485

@@ -136,13 +137,14 @@ namespace geode
136137
{
137138
if( issues_map_.empty() )
138139
{
139-
return absl::StrCat( description_, " -> No Issues :)" );
140+
return absl::StrCat( description_, " -> No Issues :) \n" );
140141
}
141142
auto message = absl::StrCat( description_ );
142143
for( const auto& issues : issues_map_ )
143144
{
144145
absl::StrAppend( &message, "\n -> ", issues.second.string() );
145146
}
147+
absl::StrAppend( &message, "\n" );
146148
return message;
147149
}
148150

src/geode/inspector/brep_inspector.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ namespace geode
3636

3737
std::string BRepInspectionResult::string() const
3838
{
39-
return absl::StrCat( meshes.string(), "\n", topology.string(), "\n" );
39+
return absl::StrCat( meshes.string(), topology.string() );
4040
}
4141

4242
std::string BRepInspectionResult::inspection_type() const

src/geode/inspector/criterion/adjacency/brep_meshes_adjacency.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,13 +50,13 @@ namespace geode
5050
std::string message;
5151
if( surfaces_edges_with_wrong_adjacencies.nb_issues() != 0 )
5252
{
53-
absl::StrAppend( &message,
54-
surfaces_edges_with_wrong_adjacencies.string(), "\n" );
53+
absl::StrAppend(
54+
&message, surfaces_edges_with_wrong_adjacencies.string() );
5555
}
5656
if( blocks_facets_with_wrong_adjacencies.nb_issues() != 0 )
5757
{
5858
absl::StrAppend(
59-
&message, blocks_facets_with_wrong_adjacencies.string(), "\n" );
59+
&message, blocks_facets_with_wrong_adjacencies.string() );
6060
}
6161
if( !message.empty() )
6262
{

src/geode/inspector/criterion/adjacency/section_meshes_adjacency.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,7 @@ namespace geode
5151
{
5252
if( surfaces_edges_with_wrong_adjacencies.nb_issues() != 0 )
5353
{
54-
return absl::StrCat(
55-
surfaces_edges_with_wrong_adjacencies.string(), "\n" );
54+
return surfaces_edges_with_wrong_adjacencies.string();
5655
}
5756
return "No adjacency issues in model component meshes \n";
5857
}

src/geode/inspector/criterion/colocation/component_meshes_colocation.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,7 @@ namespace geode
236236
{
237237
if( colocated_points_groups.nb_issues() != 0 )
238238
{
239-
return absl::StrCat( colocated_points_groups.string(), "\n" );
239+
return colocated_points_groups.string();
240240
}
241241
return "No issues of colocation in model component meshes \n";
242242
}

src/geode/inspector/criterion/colocation/unique_vertices_colocation.cpp

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -155,12 +155,8 @@ namespace geode
155155

156156
std::string UniqueVerticesInspectionResult::string() const
157157
{
158-
std::string message;
159-
absl::StrAppend(
160-
&message, colocated_unique_vertices_groups.string(), "\n" );
161-
absl::StrAppend( &message,
162-
unique_vertices_linked_to_different_points.string(), "\n" );
163-
return message;
158+
return absl::StrCat( colocated_unique_vertices_groups.string(),
159+
unique_vertices_linked_to_different_points.string() );
164160
}
165161

166162
std::string UniqueVerticesInspectionResult::inspection_type() const

src/geode/inspector/criterion/degeneration/brep_meshes_degeneration.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,15 +45,15 @@ namespace geode
4545
std::string message;
4646
if( degenerated_edges.nb_issues() != 0 )
4747
{
48-
absl::StrAppend( &message, degenerated_edges.string(), "\n" );
48+
absl::StrAppend( &message, degenerated_edges.string() );
4949
}
5050
if( degenerated_polygons.nb_issues() != 0 )
5151
{
52-
absl::StrAppend( &message, degenerated_polygons.string(), "\n" );
52+
absl::StrAppend( &message, degenerated_polygons.string() );
5353
}
5454
if( degenerated_polyhedra.nb_issues() != 0 )
5555
{
56-
absl::StrAppend( &message, degenerated_polyhedra.string(), "\n" );
56+
absl::StrAppend( &message, degenerated_polyhedra.string() );
5757
}
5858
if( message.empty() )
5959
{

src/geode/inspector/criterion/degeneration/section_meshes_degeneration.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,11 +42,11 @@ namespace geode
4242
std::string message;
4343
if( degenerated_edges.nb_issues() != 0 )
4444
{
45-
absl::StrAppend( &message, degenerated_edges.string(), "\n" );
45+
absl::StrAppend( &message, degenerated_edges.string() );
4646
}
4747
if( degenerated_polygons.nb_issues() != 0 )
4848
{
49-
absl::StrAppend( &message, degenerated_polygons.string(), "\n" );
49+
absl::StrAppend( &message, degenerated_polygons.string() );
5050
}
5151
if( !message.empty() )
5252
{

src/geode/inspector/criterion/intersections/model_intersections.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -455,7 +455,7 @@ namespace geode
455455

456456
std::string ElementsIntersectionsInspectionResult::string() const
457457
{
458-
return absl::StrCat( elements_intersections.string(), "\n" );
458+
return elements_intersections.string();
459459
}
460460

461461
std::string ElementsIntersectionsInspectionResult::inspection_type() const

src/geode/inspector/criterion/manifold/brep_meshes_manifold.cpp

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -59,22 +59,19 @@ namespace geode
5959
std::string message;
6060
if( meshes_non_manifold_vertices.nb_issues() != 0 )
6161
{
62-
absl::StrAppend(
63-
&message, meshes_non_manifold_vertices.string(), "\n" );
62+
absl::StrAppend( &message, meshes_non_manifold_vertices.string() );
6463
}
6564
if( meshes_non_manifold_edges.nb_issues() != 0 )
6665
{
67-
absl::StrAppend(
68-
&message, meshes_non_manifold_edges.string(), "\n" );
66+
absl::StrAppend( &message, meshes_non_manifold_edges.string() );
6967
}
7068
if( meshes_non_manifold_facets.nb_issues() != 0 )
7169
{
72-
absl::StrAppend(
73-
&message, meshes_non_manifold_facets.string(), "\n" );
70+
absl::StrAppend( &message, meshes_non_manifold_facets.string() );
7471
}
7572
if( brep_non_manifold_edges.nb_issues() != 0 )
7673
{
77-
absl::StrAppend( &message, brep_non_manifold_edges.string(), "\n" );
74+
absl::StrAppend( &message, brep_non_manifold_edges.string() );
7875
}
7976
if( !message.empty() )
8077
{

0 commit comments

Comments
 (0)