Skip to content

Commit bb18afc

Browse files
authored
Merge pull request #100 from Geode-solutions/fix/replace-absl-string-view-with-std
fix(StringView): use std::string_view
2 parents 53cecab + 09e905d commit bb18afc

File tree

2 files changed

+6
-11
lines changed

2 files changed

+6
-11
lines changed

bindings/python/src/inspector/inspector.cpp

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -79,11 +79,6 @@ namespace pybind11
7979
{
8080
};
8181

82-
template <>
83-
struct type_caster< absl::string_view >
84-
: string_caster< absl::string_view, true >
85-
{
86-
};
8782
} // namespace detail
8883
} // namespace pybind11
8984

include/geode/inspector/information.h

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -40,14 +40,14 @@ namespace geode
4040
class InspectionIssues
4141
{
4242
public:
43-
explicit InspectionIssues( absl::string_view issue_description )
43+
explicit InspectionIssues( std::string_view issue_description )
4444
: description_{ issue_description }
4545
{
4646
}
4747

4848
InspectionIssues() = default;
4949

50-
void set_description( absl::string_view issue_description )
50+
void set_description( std::string_view issue_description )
5151
{
5252
description_ = to_string( issue_description );
5353
}
@@ -63,7 +63,7 @@ namespace geode
6363
messages_.emplace_back( std::move( message ) );
6464
}
6565

66-
absl::string_view description() const
66+
std::string_view description() const
6767
{
6868
return description_;
6969
}
@@ -100,19 +100,19 @@ namespace geode
100100
class InspectionIssuesMap
101101
{
102102
public:
103-
explicit InspectionIssuesMap( absl::string_view issue_description )
103+
explicit InspectionIssuesMap( std::string_view issue_description )
104104
: description_{ issue_description }
105105
{
106106
}
107107

108108
InspectionIssuesMap() = default;
109109

110-
void set_description( absl::string_view issue_description )
110+
void set_description( std::string_view issue_description )
111111
{
112112
description_ = to_string( issue_description );
113113
}
114114

115-
absl::string_view description() const
115+
std::string_view description() const
116116
{
117117
return description_;
118118
}

0 commit comments

Comments
 (0)