fix(Logger): add more details about non manifold edges

panquez · panquez · commit c06827b6b9d3 · 2025-03-07T17:33:13.000+01:00
diff --git a/src/geode/inspector/criterion/manifold/surface_edge_manifold.cpp b/src/geode/inspector/criterion/manifold/surface_edge_manifold.cpp
@@ -51,9 +51,9 @@ namespace
                         { polygon_id, polygon_edge_id } )
                 };
                 if( !polygons_around_edges
-                         .try_emplace( polygon_edge_vertex_cycle,
-                             std::make_pair( 1, false ) )
-                         .second )
+                        .try_emplace( polygon_edge_vertex_cycle,
+                            std::make_pair( 1, false ) )
+                        .second )
                 {
                     polygons_around_edges[polygon_edge_vertex_cycle].first += 1;
                 }
@@ -82,11 +82,12 @@ namespace geode
         {
             for( const auto& edge : edge_to_polygons_around( mesh_ ) )
             {
-                if( edge.second.second && edge.second.first != 1 )
+                const auto [nb_incident_polygons, on_border] = edge.second;
+                if( on_border && nb_incident_polygons != 1 )
                 {
                     return false;
                 }
-                if( !edge.second.second && edge.second.first != 2 )
+                if( !on_border && nb_incident_polygons != 2 )
                 {
                     return false;
                 }
@@ -101,19 +102,22 @@ namespace geode
             };
             for( const auto& edge : edge_to_polygons_around( mesh_ ) )
             {
-                if( edge.second.second && edge.second.first != 1 )
+                const auto [nb_incident_polygons, on_border] = edge.second;
+                if( on_border && nb_incident_polygons != 1 )
                 {
                     non_manifold_edges.add_issue( edge.first.vertices(),
                         absl::StrCat( "Edge between vertices with index ",
                             edge.first.vertices()[0], " and index ",
-                            edge.first.vertices()[1], " is not manifold." ) );
+                            edge.first.vertices()[1],
+                            " is not manifold (detected as on border)." ) );
                 }
-                if( !edge.second.second && edge.second.first != 2 )
+                if( !on_border && nb_incident_polygons != 2 )
                 {
                     non_manifold_edges.add_issue( edge.first.vertices(),
                         absl::StrCat( "Edge between vertices with index ",
                             edge.first.vertices()[0], " and index ",
-                            edge.first.vertices()[1], " is not manifold." ) );
+                            edge.first.vertices()[1],
+                            " is not manifold (detected as not on border)." ) );
                 }
             }
             return non_manifold_edges;

Original file line number	Diff line number	Diff line change
`@@ -51,9 +51,9 @@ namespace`
`51`	`51`	`{ polygon_id, polygon_edge_id } )`
`52`	`52`	`};`
`53`	`53`	`if( !polygons_around_edges`
`54`		`- .try_emplace( polygon_edge_vertex_cycle,`
`55`		`- std::make_pair( 1, false ) )`
`56`		`- .second )`
	`54`	`+ .try_emplace( polygon_edge_vertex_cycle,`
	`55`	`+ std::make_pair( 1, false ) )`
	`56`	`+ .second )`
`57`	`57`	`{`
`58`	`58`	`polygons_around_edges[polygon_edge_vertex_cycle].first += 1;`
`59`	`59`	`}`
`@@ -82,11 +82,12 @@ namespace geode`
`82`	`82`	`{`
`83`	`83`	`for( const auto& edge : edge_to_polygons_around( mesh_ ) )`
`84`	`84`	`{`
`85`		`- if( edge.second.second && edge.second.first != 1 )`
	`85`	`+ const auto [nb_incident_polygons, on_border] = edge.second;`
	`86`	`+ if( on_border && nb_incident_polygons != 1 )`
`86`	`87`	`{`
`87`	`88`	`return false;`
`88`	`89`	`}`
`89`		`- if( !edge.second.second && edge.second.first != 2 )`
	`90`	`+ if( !on_border && nb_incident_polygons != 2 )`
`90`	`91`	`{`
`91`	`92`	`return false;`
`92`	`93`	`}`
`@@ -101,19 +102,22 @@ namespace geode`
`101`	`102`	`};`
`102`	`103`	`for( const auto& edge : edge_to_polygons_around( mesh_ ) )`
`103`	`104`	`{`
`104`		`- if( edge.second.second && edge.second.first != 1 )`
	`105`	`+ const auto [nb_incident_polygons, on_border] = edge.second;`
	`106`	`+ if( on_border && nb_incident_polygons != 1 )`
`105`	`107`	`{`
`106`	`108`	`non_manifold_edges.add_issue( edge.first.vertices(),`
`107`	`109`	`absl::StrCat( "Edge between vertices with index ",`
`108`	`110`	`edge.first.vertices()[0], " and index ",`
`109`		`- edge.first.vertices()[1], " is not manifold." ) );`
	`111`	`+ edge.first.vertices()[1],`
	`112`	`+ " is not manifold (detected as on border)." ) );`
`110`	`113`	`}`
`111`		`- if( !edge.second.second && edge.second.first != 2 )`
	`114`	`+ if( !on_border && nb_incident_polygons != 2 )`
`112`	`115`	`{`
`113`	`116`	`non_manifold_edges.add_issue( edge.first.vertices(),`
`114`	`117`	`absl::StrCat( "Edge between vertices with index ",`
`115`	`118`	`edge.first.vertices()[0], " and index ",`
`116`		`- edge.first.vertices()[1], " is not manifold." ) );`
	`119`	`+ edge.first.vertices()[1],`
	`120`	`+ " is not manifold (detected as not on border)." ) );`
`117`	`121`	`}`
`118`	`122`	`}`
`119`	`123`	`return non_manifold_edges;`