review changes

Author: benoit2776

include/geode/inspector/topology/brep_blocks_topology.hpp

@@ -47,7 +47,7 @@ namespace geode
             "uuids of Blocks without mesh."
         };
         InspectionIssues< uuid > wrong_block_boundary_surface{
-            "uuid of boundary surface that is actually not a boundary one."
+            "uuids of surfaces boundary to a block when they should not."
         };
         InspectionIssuesMap< index_t > blocks_not_linked_to_a_unique_vertex{
             "Blocks with mesh vertices not linked to a unique vertex"

src/geode/inspector/topology/brep_blocks_topology.cpp

@@ -56,7 +56,7 @@ namespace
         return block_boundary_uuids;
     }
 
-    bool is_line_incident_to_other_block_boundary_surface(
+    bool is_line_incident_to_another_block_boundary_surface(
         const geode::Line3D& line,
         const geode::BRep& brep,
         absl::Span< const geode::uuid > block_boundary_uuids,
@@ -77,30 +77,21 @@ namespace
         return false;
     }
 
-    std::vector< geode::uuid > inspect_boundary_surfaces(
-        const geode::BRep& brep )
+    bool surface_should_not_be_boundary_to_block( const geode::uuid& bsurf_uuid,
+        const geode::BRep& brep,
+        const std::vector< geode::uuid >& block_boundary_uuids )
     {
-        std::vector< geode::uuid > wrong_boundary_surfaces;
-        for( const auto& block : brep.blocks() )
+        const auto& surface = brep.surface( bsurf_uuid );
+        for( const auto& line : brep.boundaries( surface ) )
         {
-            const auto block_boundary_uuids =
-                block_boundary_surfaces( brep, block );
-            for( const auto& bsurf_uuid : block_boundary_uuids )
+            if( is_line_incident_to_another_block_boundary_surface(
+                    line, brep, block_boundary_uuids, bsurf_uuid ) )
             {
-                const auto& surface = brep.surface( bsurf_uuid );
-                for( const auto& line : brep.boundaries( surface ) )
-                {
-                    if( is_line_incident_to_other_block_boundary_surface(
-                            line, brep, block_boundary_uuids, bsurf_uuid ) )
-                    {
-                        continue;
-                    }
-                    wrong_boundary_surfaces.push_back( bsurf_uuid );
-                    break;
-                }
+                continue;
             }
+            return true;
         }
-        return wrong_boundary_surfaces;
+        return false;
     }
 
     template < typename Condition >
@@ -435,12 +426,24 @@ namespace geode
                     .add_issue( unique_vertex_id, problem_message.value() );
             }
         }
-        for( const auto& wrong_bsurf : inspect_boundary_surfaces( brep_ ) )
+        for( const auto& block : brep_.blocks() )
         {
-            result.wrong_block_boundary_surface.add_issue( wrong_bsurf,
-                absl::StrCat( "Boundary surface ", wrong_bsurf.string(),
-                    " contains a line not incident to "
-                    "any other block boundary surface." ) );
+            const auto block_boundary_uuids =
+                block_boundary_surfaces( brep_, block );
+            for( const auto& bsurf_uuid : block_boundary_uuids )
+            {
+                if( surface_should_not_be_boundary_to_block(
+                        bsurf_uuid, brep_, block_boundary_uuids ) )
+                {
+                    result.wrong_block_boundary_surface.add_issue( bsurf_uuid,
+                        absl::StrCat( "Surface ", bsurf_uuid.string(),
+                            " should not be boundary of Block ",
+                            block.id().string(),
+                            " : it has a boundary line not incident to any "
+                            "other block "
+                            "boundary surface." ) );
+                }
+            }
         }
         return result;
     }