python tests segfault because of object lifetime

Author: MelchiorSchuh

bindings/python/src/inspector/criterion/degeneration/solid_degeneration.hpp

@@ -39,8 +39,10 @@ namespace geode
             .def( pybind11::init< const SolidMesh& >() )
             .def( "is_mesh_degenerated",
                 &SolidMeshDegeneration::is_mesh_degenerated )
-            .def( "degenerated_edges",
-                &SolidMeshDegeneration::degenerated_edges );
+            .def(
+                "degenerated_edges", &SolidMeshDegeneration::degenerated_edges )
+            .def( "degenerated_polyhedra",
+                &SolidMeshDegeneration::degenerated_polyhedra );
     }
     void define_solid_degeneration( pybind11::module& module )
     {

bindings/python/src/inspector/criterion/degeneration/surface_degeneration.hpp

@@ -40,7 +40,9 @@ namespace geode
             .def( "is_mesh_degenerated",
                 &SurfaceMeshDegeneration::is_mesh_degenerated )
             .def( "degenerated_edges",
-                &SurfaceMeshDegeneration::degenerated_edges );
+                &SurfaceMeshDegeneration::degenerated_edges )
+            .def( "degenerated_polygons",
+                &SurfaceMeshDegeneration::degenerated_polygons );
     }
     void define_surface_degeneration( pybind11::module& module )
     {

bindings/python/tests/test-py-solid-degeneration.py

@@ -50,6 +50,7 @@ def check_non_degeneration():
     if not degeneration_inspector.degenerated_edges().nb_issues() == 0:
         raise ValueError(
             "[Test] Solid has more degenerated edges than it should.")
+    del degeneration_inspector
 
 def check_degeneration_by_colocalisation():
     solid = geode.TetrahedralSolid3D.create()
@@ -73,6 +74,7 @@ def check_degeneration_by_colocalisation():
         raise ValueError("[Test] Solid has wrong number of degenerated edges.")
     if not degeneration_inspector.degenerated_edges().issues()[0] == solid.edges().edge_from_vertices([1, 4]):
         raise ValueError("[Test] Solid has wrong degenerated edges.")
+    del degeneration_inspector
 
 
 def check_degeneration_by_point_multiple_presence():
@@ -97,6 +99,7 @@ def check_degeneration_by_point_multiple_presence():
             "[Test] Solid has the wrong number of degenerated edges.")
     if not degeneration_inspector.degenerated_edges().issues()[0] == solid.edges().edge_from_vertices([1, 1]):
         raise ValueError("[Test] Solid shows the wrong degenerated edges.")
+    del degeneration_inspector
 
 
 if __name__ == '__main__':

bindings/python/tests/test-py-surface-degeneration.py

@@ -49,6 +49,7 @@ def check_non_degeneration2D():
     if not degeneration_inspector.degenerated_edges().nb_issues() == 0:
         raise ValueError(
             "[Test] Surface has more degenerated edges than it should.")
+    del degeneration_inspector
 
 def check_degeneration_by_colocalisation2D():
     surface = geode.TriangulatedSurface2D.create()
@@ -72,6 +73,7 @@ def check_degeneration_by_colocalisation2D():
     surface.enable_edges()
     if not degeneration_inspector.degenerated_edges().issues()[0] == surface.edges().edge_from_vertices([1, 3]):
         raise ValueError("[Test] Surface has wrong degenerated edges.")
+    del degeneration_inspector
 
 
 def check_degeneration_by_point_multiple_presence2D():
@@ -95,6 +97,7 @@ def check_degeneration_by_point_multiple_presence2D():
     surface.enable_edges()
     if not degeneration_inspector.degenerated_edges().issues()[0] == surface.edges().edge_from_vertices([1, 1]):
         raise ValueError("[Test] Surface shows the wrong degenerated edges.")
+    del degeneration_inspector
 
 
 def check_non_degeneration3D():
@@ -116,6 +119,7 @@ def check_non_degeneration3D():
     if not degeneration_inspector.degenerated_edges().nb_issues() == 0:
         raise ValueError(
             "[Test] (3D) Surface has more degenerated edges than it should.")
+    del degeneration_inspector
 
 def check_degeneration_by_colocalisation3D():
     surface = geode.TriangulatedSurface3D.create()
@@ -140,6 +144,7 @@ def check_degeneration_by_colocalisation3D():
     surface.enable_edges()
     if not degeneration_inspector.degenerated_edges().issues()[0] == surface.edges().edge_from_vertices([1, 3]):
         raise ValueError("[Test] (3D) Surface has wrong degenerated edges.")
+    del degeneration_inspector
 
 
 def check_degeneration_by_point_multiple_presence3D():
@@ -164,6 +169,7 @@ def check_degeneration_by_point_multiple_presence3D():
     if not degeneration_inspector.degenerated_edges().issues()[0] == surface.edges().edge_from_vertices([1, 1]):
         raise ValueError(
             "[Test] (3D) Surface shows the wrong degenerated edges.")
+    del degeneration_inspector
 
 
 if __name__ == '__main__':