more refactoring

francoisbonneau · francoisbonneau · commit fec0ac46592b · 2025-10-28T17:09:55.000+01:00
diff --git a/include/geode/inspector/criterion/adjacency/brep_meshes_adjacency.hpp b/include/geode/inspector/criterion/adjacency/brep_meshes_adjacency.hpp
@@ -45,11 +45,11 @@ namespace geode
     {
         InspectionIssuesMap< PolygonEdge >
             surfaces_edges_with_wrong_adjacencies{
-                "BRep Surface mesh with polygon edges adjacencies issues"
+                "surface polygon edges adjacencies issues"
             };
         InspectionIssuesMap< PolyhedronFacet >
             blocks_facets_with_wrong_adjacencies{
-                "BRep Block mesh with polyhedron facets adjacencies issues"
+                "block polyhedron facets adjacencies issues"
             };
 
         [[nodiscard]] index_t nb_issues() const;
diff --git a/include/geode/inspector/criterion/adjacency/section_meshes_adjacency.hpp b/include/geode/inspector/criterion/adjacency/section_meshes_adjacency.hpp
@@ -45,7 +45,7 @@ namespace geode
     {
         InspectionIssuesMap< PolygonEdge >
             surfaces_edges_with_wrong_adjacencies{
-                "Section Surface mesh polygon edges adjacencies issues"
+                "surface polygon edges adjacencies issues"
             };
 
         [[nodiscard]] index_t nb_issues() const;
diff --git a/include/geode/inspector/criterion/colocation/component_meshes_colocation.hpp b/include/geode/inspector/criterion/colocation/component_meshes_colocation.hpp
@@ -41,7 +41,7 @@ namespace geode
     struct opengeode_inspector_inspector_api MeshesColocationInspectionResult
     {
         InspectionIssuesMap< std::vector< index_t > > colocated_points_groups{
-            "Model component meshes with colocated points"
+            "meshes with colocated points"
         };
 
         [[nodiscard]] index_t nb_issues() const;
diff --git a/include/geode/inspector/criterion/colocation/unique_vertices_colocation.hpp b/include/geode/inspector/criterion/colocation/unique_vertices_colocation.hpp
@@ -39,9 +39,9 @@ namespace geode
     struct opengeode_inspector_inspector_api UniqueVerticesInspectionResult
     {
         InspectionIssues< std::vector< index_t > >
-            colocated_unique_vertices_groups{ "colocated unique vertices." };
+            colocated_unique_vertices_groups{ "colocated unique vertices" };
         InspectionIssues< index_t > unique_vertices_linked_to_different_points{
-            "unique vertices linked to mesh vertices at differing positions."
+            "unique vertices linked to several positions"
         };
 
         [[nodiscard]] index_t nb_issues() const;
diff --git a/include/geode/inspector/criterion/degeneration/brep_meshes_degeneration.hpp b/include/geode/inspector/criterion/degeneration/brep_meshes_degeneration.hpp
@@ -42,13 +42,13 @@ namespace geode
         opengeode_inspector_inspector_api BRepMeshesDegenerationInspectionResult
     {
         InspectionIssuesMap< index_t > degenerated_edges{
-            "BRep component meshes with degenerated edges"
+            "meshes with degenerated edges"
         };
         InspectionIssuesMap< index_t > degenerated_polygons{
-            "BRep component meshes with degenerated polygons"
+            "meshes with degenerated polygons"
         };
         InspectionIssuesMap< index_t > degenerated_polyhedra{
-            "BRep component meshes with degenerated polyhedra"
+            "meshes with degenerated polyhedra"
         };
 
         [[nodiscard]] index_t nb_issues() const;
diff --git a/include/geode/inspector/criterion/degeneration/section_meshes_degeneration.hpp b/include/geode/inspector/criterion/degeneration/section_meshes_degeneration.hpp
@@ -42,10 +42,10 @@ namespace geode
         opengeode_inspector_inspector_api SectionMeshesDegenerationInspectionResult
     {
         InspectionIssuesMap< index_t > degenerated_edges{
-            "Section component meshes with degenerated edges"
+            "meshes with degenerated edges"
         };
         InspectionIssuesMap< index_t > degenerated_polygons{
-            "Section component meshes with degenerated polygons"
+            "meshes with degenerated polygons"
         };
 
         [[nodiscard]] index_t nb_issues() const;
diff --git a/include/geode/inspector/criterion/intersections/model_intersections.hpp b/include/geode/inspector/criterion/intersections/model_intersections.hpp
@@ -43,7 +43,7 @@ namespace geode
     {
         InspectionIssues<
             std::pair< ComponentMeshElement, ComponentMeshElement > >
-            elements_intersections{ "Surface intersections." };
+            elements_intersections{ "surface intersections" };
 
         [[nodiscard]] index_t nb_issues() const;
 
diff --git a/include/geode/inspector/criterion/manifold/brep_meshes_manifold.hpp b/include/geode/inspector/criterion/manifold/brep_meshes_manifold.hpp
@@ -58,22 +58,18 @@ namespace geode
     struct opengeode_inspector_inspector_api BRepMeshesManifoldInspectionResult
     {
         InspectionIssuesMap< index_t > meshes_non_manifold_vertices{
-            "BRep component meshes with non manifold vertices"
+            "meshes with non manifold vertices"
         };
         InspectionIssuesMap< std::array< index_t, 2 > >
-            meshes_non_manifold_edges{
-                "BRep component meshes with non manifold edges"
-            };
+            meshes_non_manifold_edges{ "meshes with non manifold edges" };
         InspectionIssuesMap< PolyhedronFacetVertices >
-            meshes_non_manifold_facets{
-                "BRep component meshes with non manifold facets"
-            };
+            meshes_non_manifold_facets{ "meshes with non manifold facets" };
         InspectionIssues< BRepNonManifoldEdge > brep_non_manifold_edges{
-            "BRep non manifold edges"
+            "non manifold edges"
         };
 
         InspectionIssues< BRepNonManifoldFacet > brep_non_manifold_facets{
-            "BRep non manifold facets"
+            "non manifold facets"
         };
 
         [[nodiscard]] index_t nb_issues() const;
diff --git a/include/geode/inspector/criterion/manifold/section_meshes_manifold.hpp b/include/geode/inspector/criterion/manifold/section_meshes_manifold.hpp
@@ -39,12 +39,10 @@ namespace geode
         opengeode_inspector_inspector_api SectionMeshesManifoldInspectionResult
     {
         InspectionIssuesMap< index_t > meshes_non_manifold_vertices{
-            "Section component meshes with non manifold vertices"
+            "meshes with non manifold vertices"
         };
         InspectionIssuesMap< std::array< index_t, 2 > >
-            meshes_non_manifold_edges{
-                "Section component meshes with non manifold edges"
-            };
+            meshes_non_manifold_edges{ "meshes with non manifold edges" };
 
         [[nodiscard]] index_t nb_issues() const;
 
diff --git a/include/geode/inspector/criterion/negative_elements/brep_meshes_negative_elements.hpp b/include/geode/inspector/criterion/negative_elements/brep_meshes_negative_elements.hpp
@@ -42,7 +42,7 @@ namespace geode
         opengeode_inspector_inspector_api BRepMeshesNegativeElementsInspectionResult
     {
         InspectionIssuesMap< index_t > negative_polyhedra{
-            "BRep block meshes with negative polyhedra"
+            "block with negative polyhedra"
         };
 
         [[nodiscard]] index_t nb_issues() const;
diff --git a/include/geode/inspector/criterion/negative_elements/section_meshes_negative_elements.hpp b/include/geode/inspector/criterion/negative_elements/section_meshes_negative_elements.hpp
@@ -42,7 +42,7 @@ namespace geode
         opengeode_inspector_inspector_api SectionMeshesNegativeElementsInspectionResult
     {
         InspectionIssuesMap< index_t > negative_polygons{
-            "Section surface meshes with negative polygons"
+            "surface with negative polygons"
         };
 
         [[nodiscard]] index_t nb_issues() const;
diff --git a/include/geode/inspector/edgedcurve_inspector.hpp b/include/geode/inspector/edgedcurve_inspector.hpp
@@ -33,10 +33,10 @@ namespace geode
     struct opengeode_inspector_inspector_api EdgedCurveInspectionResult
     {
         InspectionIssues< std::vector< index_t > > colocated_points_groups{
-            "Vertices colocalization not tested"
+            "Colocalization of vertices not tested"
         };
         InspectionIssues< index_t > degenerated_edges{
-            "Edges degeneration not tested"
+            "Degeneration of edges not tested"
         };
 
         [[nodiscard]] index_t nb_issues() const;
diff --git a/include/geode/inspector/information.hpp b/include/geode/inspector/information.hpp
@@ -78,7 +78,7 @@ namespace geode
                 absl::StrCat( issues_.size(), " issues with ", description_ );
             for( const auto& issue : messages_ )
             {
-                absl::StrAppend( &message, ":\n\t", issue );
+                absl::StrAppend( &message, "\n\t", issue );
             }
             absl::StrAppend( &message, "\n" );
             return message;
@@ -144,7 +144,7 @@ namespace geode
                 issues_map_.size(), " issues with ", description_ );
             for( const auto& issues : issues_map_ )
             {
-                absl::StrAppend( &message, ":\n\t", issues.second.string() );
+                absl::StrAppend( &message, "\n\t", issues.second.string() );
             }
             absl::StrAppend( &message, "\n" );
             return message;
diff --git a/include/geode/inspector/pointset_inspector.hpp b/include/geode/inspector/pointset_inspector.hpp
@@ -32,7 +32,7 @@ namespace geode
     struct opengeode_inspector_inspector_api PointSetInspectionResult
     {
         InspectionIssues< std::vector< index_t > > colocated_points_groups{
-            "Colocation of vertices not tested"
+            "Colocalization of vertices not tested"
         };
 
         [[nodiscard]] index_t nb_issues() const;
diff --git a/include/geode/inspector/solid_inspector.hpp b/include/geode/inspector/solid_inspector.hpp
@@ -42,7 +42,7 @@ namespace geode
                 "Adjacencies of facets not tested"
             };
         InspectionIssues< std::vector< index_t > > colocated_points_groups{
-            "Colocation of vertices not tested"
+            "Colocalization of vertices not tested"
         };
         InspectionIssues< index_t > degenerated_edges{
             "Degeneration of edges not tested"
diff --git a/include/geode/inspector/surface_inspector.hpp b/include/geode/inspector/surface_inspector.hpp
@@ -37,10 +37,10 @@ namespace geode
     struct opengeode_inspector_inspector_api SurfaceInspectionResult
     {
         InspectionIssues< PolygonEdge > polygon_edges_with_wrong_adjacency{
-            "Adjacencies between polygon edges not tested"
+            "Adjacencies between polygon and edges not tested"
         };
         InspectionIssues< std::vector< index_t > > colocated_points_groups{
-            "Colocation of vertices not tested"
+            "Colocalization of vertices not tested"
         };
         InspectionIssues< index_t > degenerated_edges{
             "Degeneration of edges not tested"
diff --git a/include/geode/inspector/topology/brep_blocks_topology.hpp b/include/geode/inspector/topology/brep_blocks_topology.hpp
@@ -46,42 +46,42 @@ namespace geode
     struct opengeode_inspector_inspector_api BRepBlocksTopologyInspectionResult
     {
         InspectionIssues< uuid > some_blocks_not_meshed{
-            "blocks without mesh (UUIDs listed)."
+            "blocks without mesh (UUIDs listed)"
         };
         InspectionIssues< uuid > wrong_block_boundary_surface{
-            "surfaces incorrectly bounding blocks (UUIDs listed)."
+            "surfaces incorrectly bounding blocks (UUIDs listed)"
         };
         InspectionIssuesMap< index_t > blocks_not_linked_to_a_unique_vertex{
-            "blocks containing mesh vertices not linked to unique vertices."
+            "blocks containing mesh vertices not linked to unique vertices"
         };
         InspectionIssues< index_t >
             unique_vertices_part_of_two_blocks_and_no_boundary_surface{
                 "unique vertices shared by two blocks without a boundary "
-                "surface or incident block line."
+                "surface or incident block line"
             };
         InspectionIssues< index_t >
             unique_vertices_with_incorrect_block_cmvs_count{
                 "unique vertices in a block with incorrect "
-                "ComponentMeshVertices count."
+                "ComponentMeshVertices count"
             };
         InspectionIssues< index_t >
             unique_vertices_linked_to_surface_with_wrong_relationship_to_blocks{
                 "unique vertices linked to surfaces with neither boundary nor "
-                "internal status."
+                "internal status"
             };
         InspectionIssues< index_t >
             unique_vertices_linked_to_a_single_and_invalid_surface{
-                "unique vertices linked to a single surface that is invalid."
+                "unique vertices linked to a single surface that is invalid"
             };
         InspectionIssues< uuid > blocks_with_not_closed_boundary_surfaces{
-            "blocks with non-closed boundary surfaces."
+            "blocks with non-closed boundary surfaces"
         };
         InspectionIssues< index_t > model_boundaries_dont_form_a_closed_surface{
-            "model boundaries don't form a closed surface (UUIDs listed)."
+            "model boundaries don't form a closed surface (UUIDs listed)"
         };
         InspectionIssues< index_t >
             unique_vertex_linked_to_multiple_invalid_surfaces{
-                "unique vertices linked to multiple surfaces in an invalid way."
+                "unique vertices linked to multiple surfaces in an invalid way"
             };
 
         [[nodiscard]] index_t nb_issues() const;
diff --git a/include/geode/inspector/topology/brep_corners_topology.hpp b/include/geode/inspector/topology/brep_corners_topology.hpp
@@ -43,23 +43,23 @@ namespace geode
     struct opengeode_inspector_inspector_api BRepCornersTopologyInspectionResult
     {
         InspectionIssues< uuid > corners_not_meshed{
-            "corners without mesh (UUIDs listed)."
+            "corners without mesh (UUIDs listed)"
         };
         InspectionIssuesMap< index_t > corners_not_linked_to_a_unique_vertex{
-            "corners containing mesh vertices not linked to unique vertices."
+            "corners containing mesh vertices not linked to unique vertices"
         };
         InspectionIssues< index_t > unique_vertices_linked_to_multiple_corners{
-            "unique vertices shared by several corners."
+            "unique vertices shared by several corners"
         };
         InspectionIssues< index_t >
             unique_vertices_linked_to_not_internal_nor_boundary_corner{
                 "unique vertices linked to a corner with neither "
-                "boundary nor internal status."
+                "boundary nor internal status"
             };
         InspectionIssues< index_t >
             unique_vertices_liked_to_not_boundary_line_corner{
                 "unique vertices linked to a line corner without boundary "
-                "status."
+                "status"
             };
 
         [[nodiscard]] index_t nb_issues() const;
diff --git a/include/geode/inspector/topology/brep_lines_topology.hpp b/include/geode/inspector/topology/brep_lines_topology.hpp
@@ -43,32 +43,32 @@ namespace geode
     struct opengeode_inspector_inspector_api BRepLinesTopologyInspectionResult
     {
         InspectionIssues< uuid > lines_not_meshed{
-            "lines without mesh (UUIDs listed)."
+            "lines without mesh (UUIDs listed)"
         };
         InspectionIssues< index_t >
             unique_vertices_linked_to_line_with_wrong_relationship_to_surface{
                 "unique vertices linked to a line with an incorrect "
-                "relationship to a surface."
+                "relationship to a surface"
             };
         InspectionIssuesMap< index_t > lines_not_linked_to_a_unique_vertex{
             "lines with mesh vertices not linked to a unique vertex"
         };
         InspectionIssues< index_t >
             unique_vertices_linked_to_a_line_with_invalid_embeddings{
                 "unique vertices linked to a line with invalid internal "
-                "topology."
+                "topology"
             };
         InspectionIssues< index_t >
             unique_vertices_linked_to_a_single_and_invalid_line{
-                "unique vertices linked to a single invalid line."
+                "unique vertices linked to a single invalid line"
             };
         InspectionIssues< index_t >
             unique_vertices_linked_to_several_lines_but_not_linked_to_a_corner{
-                "unique vertices linked to multiple lines but not to a corner."
+                "unique vertices linked to multiple lines but not to a corner"
             };
         InspectionIssuesMap< index_t >
             line_edges_with_wrong_component_edges_around{
-                "line edges with incorrect surrounding component edges."
+                "line edges with incorrect surrounding component edges"
             };
 
         [[nodiscard]] index_t nb_issues() const;
diff --git a/include/geode/inspector/topology/brep_surfaces_topology.hpp b/include/geode/inspector/topology/brep_surfaces_topology.hpp
@@ -42,27 +42,27 @@ namespace geode
         opengeode_inspector_inspector_api BRepSurfacesTopologyInspectionResult
     {
         InspectionIssues< uuid > surfaces_not_meshed{
-            "surface without mesh (UUIDs listed)."
+            "surface without mesh (UUIDs listed)"
         };
         InspectionIssuesMap< index_t > surfaces_not_linked_to_a_unique_vertex{
             "surfaces containing mesh vertices not linked to unique vertices"
         };
         InspectionIssues< index_t >
             unique_vertices_linked_to_a_surface_with_invalid_embbedings{
                 "unique vertices linked to a surface with invalid "
-                "internal topology."
+                "internal topology"
             };
         InspectionIssues< index_t >
             unique_vertices_linked_to_several_and_invalid_surfaces{
-                "unique vertices improperly linked to several surfaces."
+                "unique vertices improperly linked to several surfaces"
             };
         InspectionIssues< index_t >
             unique_vertices_linked_to_a_line_but_is_not_on_a_surface_border{
-                "unique vertices linked to a line but not to a surface border."
+                "unique vertices linked to a line but not to a surface border"
             };
         InspectionIssuesMap< index_t >
             surface_polygons_with_wrong_component_facets_around{
-                "Surface polygons with invalid surrounding facets."
+                "Surface polygons with invalid surrounding facets"
             };
 
         [[nodiscard]] index_t nb_issues() const;
diff --git a/include/geode/inspector/topology/brep_topology.hpp b/include/geode/inspector/topology/brep_topology.hpp
@@ -46,15 +46,15 @@ namespace geode
         BRepSurfacesTopologyInspectionResult surfaces;
         BRepBlocksTopologyInspectionResult blocks;
         InspectionIssues< index_t > unique_vertices_not_linked_to_any_component{
-            "unique vertices with no component links."
+            "unique vertices with no component links"
         };
         InspectionIssues< index_t > unique_vertices_linked_to_inexistant_cmv{
             "unique vertices linked to inexistant ComponentMeshVertex"
         };
         InspectionIssues< index_t >
             unique_vertices_nonbijectively_linked_to_cmv{
                 "unique vertices with non-bijective links to "
-                "ComponentMeshVertex."
+                "ComponentMeshVertex"
             };
 
         [[nodiscard]] index_t nb_issues() const;
diff --git a/include/geode/inspector/topology/section_corners_topology.hpp b/include/geode/inspector/topology/section_corners_topology.hpp
diff --git a/include/geode/inspector/topology/section_lines_topology.hpp b/include/geode/inspector/topology/section_lines_topology.hpp
diff --git a/include/geode/inspector/topology/section_surfaces_topology.hpp b/include/geode/inspector/topology/section_surfaces_topology.hpp
diff --git a/include/geode/inspector/topology/section_topology.hpp b/include/geode/inspector/topology/section_topology.hpp

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ namespace geode`
`45`	`45`	`{`
`46`	`46`	`InspectionIssuesMap< PolygonEdge >`
`47`	`47`	`surfaces_edges_with_wrong_adjacencies{`
`48`		`- "Section Surface mesh polygon edges adjacencies issues"`
	`48`	`+ "surface polygon edges adjacencies issues"`
`49`	`49`	`};`
`50`	`50`
`51`	`51`	`[[nodiscard]] index_t nb_issues() const;`
Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ namespace geode`
`41`	`41`	`struct opengeode_inspector_inspector_api MeshesColocationInspectionResult`
`42`	`42`	`{`
`43`	`43`	`InspectionIssuesMap< std::vector< index_t > > colocated_points_groups{`
`44`		`- "Model component meshes with colocated points"`
	`44`	`+ "meshes with colocated points"`
`45`	`45`	`};`
`46`	`46`
`47`	`47`	`[[nodiscard]] index_t nb_issues() const;`
Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ namespace geode`
`43`	`43`	`{`
`44`	`44`	`InspectionIssues<`
`45`	`45`	`std::pair< ComponentMeshElement, ComponentMeshElement > >`
`46`		`- elements_intersections{ "Surface intersections." };`
	`46`	`+ elements_intersections{ "surface intersections" };`
`47`	`47`
`48`	`48`	`[[nodiscard]] index_t nb_issues() const;`
`49`	`49`
Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ namespace geode`
`42`	`42`	`opengeode_inspector_inspector_api BRepMeshesNegativeElementsInspectionResult`
`43`	`43`	`{`
`44`	`44`	`InspectionIssuesMap< index_t > negative_polyhedra{`
`45`		`- "BRep block meshes with negative polyhedra"`
	`45`	`+ "block with negative polyhedra"`
`46`	`46`	`};`
`47`	`47`
`48`	`48`	`[[nodiscard]] index_t nb_issues() const;`