Merge pull request #1043 from Geode-solutions/fix/grid-to-hex

fix(Mesh): add helper to convert grid into hybrid solid full of hexah…

Author: MelchiorSchuh

include/geode/mesh/helpers/convert_solid_mesh.hpp

@@ -50,6 +50,9 @@ namespace geode
     [[nodiscard]] std::unique_ptr< TetrahedralSolid3D > opengeode_mesh_api
         convert_grid_into_tetrahedral_solid( const Grid3D& grid );
 
+    [[nodiscard]] std::unique_ptr< HybridSolid3D >
+        opengeode_mesh_api convert_grid_into_hybrid_solid( const Grid3D& grid );
+
     [[nodiscard]] std::unique_ptr< TetrahedralSolid3D > opengeode_mesh_api
         convert_grid_into_densified_tetrahedral_solid( const Grid3D& grid,
             absl::Span< const geode::index_t > cells_to_densify );

src/geode/mesh/helpers/convert_solid_mesh.cpp

@@ -29,6 +29,7 @@
 
 #include <geode/mesh/builder/hybrid_solid_builder.hpp>
 #include <geode/mesh/builder/tetrahedral_solid_builder.hpp>
+#include <geode/mesh/core/detail/geode_elements.hpp>
 #include <geode/mesh/core/hybrid_solid.hpp>
 #include <geode/mesh/core/light_regular_grid.hpp>
 #include <geode/mesh/core/regular_grid_solid.hpp>
@@ -39,6 +40,19 @@
 
 namespace
 {
+    std::array< geode::index_t, 8 > grid_cell_vertices(
+        const geode::Grid3D& grid,
+        const geode::Grid3D::CellIndices& cell_indices )
+    {
+        std::array< geode::index_t, 8 > cell_vertices;
+        const auto vertex_indices = grid.cell_vertices( cell_indices );
+        for( const auto v : geode::LIndices{ cell_vertices } )
+        {
+            cell_vertices[v] = grid.vertex_index( vertex_indices[v] );
+        }
+        return cell_vertices;
+    }
+
     bool all_polyhedra_are_simplex( const geode::SolidMesh3D& solid )
     {
         for( const auto p : geode::Range{ solid.nb_polyhedra() } )
@@ -104,6 +118,36 @@ namespace
         return tetras;
     }
 
+    std::array< geode::index_t, 6 > create_pyramid_pattern(
+        geode::HybridSolidBuilder3D& builder,
+        const geode::Grid3D& grid,
+        const geode::Grid3D::CellIndices& cell_indices,
+        geode::index_t additional_vertex_id )
+    {
+        std::array< geode::index_t, 6 > pyramids;
+        const auto cell_vertices = grid.cell_vertices( cell_indices );
+        std::array< geode::index_t, 8 > cell_mesh_vertices;
+        for( const auto v : geode::LIndices{ cell_mesh_vertices } )
+        {
+            const auto cell_vertex_id = grid.vertex_index( cell_vertices[v] );
+            cell_mesh_vertices[v] = cell_vertex_id;
+        }
+        for( const auto p : geode::LIndices{ pyramids } )
+        {
+            pyramids[p] = builder.create_pyramid(
+                { cell_mesh_vertices
+                        [geode::detail::HEXAHEDRON_FACET_VERTICES[p][0]],
+                    cell_mesh_vertices
+                        [geode::detail::HEXAHEDRON_FACET_VERTICES[p][1]],
+                    cell_mesh_vertices
+                        [geode::detail::HEXAHEDRON_FACET_VERTICES[p][2]],
+                    cell_mesh_vertices
+                        [geode::detail::HEXAHEDRON_FACET_VERTICES[p][3]],
+                    additional_vertex_id } );
+        }
+        return pyramids;
+    }
+
     std::array< geode::index_t, 6 > create_tetrahedra_from_pIpI_pattern(
         geode::TetrahedralSolidBuilder3D& builder,
         const geode::Grid3D& grid,
@@ -191,8 +235,55 @@ namespace
             grid.cell_attribute_manager(), old2new_mapping );
     }
 
-    void create_vertices_from_grid( const geode::TetrahedralSolid3D& tet_solid,
-        geode::TetrahedralSolidBuilder3D& builder,
+    void create_hexahedra_from_grid_cells( const geode::HybridSolid3D& solid,
+        geode::HybridSolidBuilder3D& builder,
+        const geode::Grid3D& grid,
+        absl::Span< const geode::index_t > cells_to_densify )
+    {
+        std::vector< bool > to_densify( grid.nb_cells(), false );
+        for( const auto& cell_id : cells_to_densify )
+        {
+            to_densify[cell_id] = true;
+        }
+        geode::GenericMapping< geode::index_t > old2new_mapping;
+        for( const auto k : geode::Range{ grid.nb_cells_in_direction( 2 ) } )
+        {
+            for( const auto j :
+                geode::Range{ grid.nb_cells_in_direction( 1 ) } )
+            {
+                for( const auto i :
+                    geode::Range{ grid.nb_cells_in_direction( 0 ) } )
+                {
+                    const auto cell_id = grid.cell_index( { i, j, k } );
+                    if( to_densify[cell_id] )
+                    {
+                        continue;
+                    }
+                    const auto hex_id = builder.create_hexahedron(
+                        grid_cell_vertices( grid, { i, j, k } ) );
+                    old2new_mapping.map( cell_id, hex_id );
+                }
+            }
+        }
+        for( const auto cell_index : geode::Indices{ cells_to_densify } )
+        {
+            const auto cell_indices =
+                grid.cell_indices( cells_to_densify[cell_index] );
+            const auto additional_vertex_id =
+                grid.nb_grid_vertices() + cell_index;
+            for( const auto tetra_id : create_pyramid_pattern(
+                     builder, grid, cell_indices, additional_vertex_id ) )
+            {
+                old2new_mapping.map( cells_to_densify[cell_index], tetra_id );
+            }
+        }
+        builder.compute_polyhedron_adjacencies();
+        solid.polyhedron_attribute_manager().import(
+            grid.cell_attribute_manager(), old2new_mapping );
+    }
+
+    void create_vertices_from_grid( const geode::SolidMesh3D& solid,
+        geode::SolidMeshBuilder3D& builder,
         const geode::Grid3D& grid,
         absl::Span< const geode::index_t > cells_to_densify )
     {
@@ -203,7 +294,7 @@ namespace
             builder.set_point( vertex_id,
                 grid.grid_point( grid.vertex_indices( vertex_id ) ) );
         }
-        auto& solid_attribute_manager = tet_solid.vertex_attribute_manager();
+        auto& solid_attribute_manager = solid.vertex_attribute_manager();
         geode::internal::copy_attributes(
             grid.grid_vertex_attribute_manager(), solid_attribute_manager );
         geode::index_t counter{ grid.nb_grid_vertices() };
@@ -240,6 +331,18 @@ namespace
         return tet_solid;
     }
 
+    std::unique_ptr< geode::HybridSolid3D > create_hybrid_solid_from_grid(
+        const geode::Grid3D& grid,
+        absl::Span< const geode::index_t > cells_to_densify )
+    {
+        auto solid = geode::HybridSolid3D::create();
+        auto builder = geode::HybridSolidBuilder3D::create( *solid );
+        create_vertices_from_grid( *solid, *builder, grid, cells_to_densify );
+        create_hexahedra_from_grid_cells(
+            *solid, *builder, grid, cells_to_densify );
+        return solid;
+    }
+
     bool all_polyhedra_are_hybrid( const geode::SolidMesh3D& solid )
     {
         for( const auto p : geode::Range{ solid.nb_polyhedra() } )
@@ -473,6 +576,12 @@ namespace geode
         return create_tetrahedral_solid_from_grid( grid, {} );
     }
 
+    std::unique_ptr< HybridSolid3D > convert_grid_into_hybrid_solid(
+        const Grid3D& grid )
+    {
+        return create_hybrid_solid_from_grid( grid, {} );
+    }
+
     std::unique_ptr< TetrahedralSolid3D >
         convert_grid_into_densified_tetrahedral_solid( const Grid3D& grid,
             absl::Span< const geode::index_t > cells_to_densify )

tests/mesh/test-convert-solid.cpp

@@ -42,7 +42,7 @@
 
 // NOLINTBEGIN(*-magic-numbers)
 
-void test_tetrahedral_solid()
+void test_grid_to_solids()
 {
     geode::OpenGeodeMeshLibrary::initialize();
     auto mesh_grid = geode::RegularGrid3D::create();
@@ -53,6 +53,8 @@ void test_tetrahedral_solid()
         geode::convert_solid_mesh_into_tetrahedral_solid( *mesh_grid );
     const auto tet_solid_from_mesh_grid_2 =
         geode::convert_grid_into_tetrahedral_solid( *mesh_grid );
+    const auto hybrid_solid_from_mesh_grid =
+        geode::convert_grid_into_hybrid_solid( *mesh_grid );
     const geode::LightRegularGrid3D light_grid{
         geode::Point3D{ { 1, 1.5, 1.1 } }, { 5, 5, 5 }, { 5, 5, 5 }
     };
@@ -72,6 +74,10 @@ void test_tetrahedral_solid()
         tet_solid_from_mesh_grid_2->nb_vertices() == nb_vertices,
         "[Test] Number of vertices in TetrahedralSolid3D from RegularGrid3D as "
         "grid is not correct." );
+    OPENGEODE_EXCEPTION(
+        hybrid_solid_from_mesh_grid->nb_vertices() == nb_vertices,
+        "[Test] Number of vertices in HybridSolid3D from RegularGrid3D as "
+        "grid is not correct." );
     const geode::index_t nb_densified_vertices =
         nb_vertices + cells_to_densify.size();
     OPENGEODE_EXCEPTION( tet_solid_from_light_grid->nb_vertices()
@@ -88,10 +94,14 @@ void test_tetrahedral_solid()
         tet_solid_from_mesh_grid_2->nb_polyhedra() == nb_tetrahedra,
         "[Test] Number of tetrahedra in TetrahedralSolid3D from RegularGrid3D "
         "as grid is not correct." );
-    OPENGEODE_EXCEPTION( tet_solid_from_light_grid->nb_polyhedra()
-                             == nb_tetrahedra + 6 * cells_to_densify.size(),
-        "[Test] Number of tetrahedra in TetrahedralSolid3D from "
-        "LightRegularGrid is not correct" );
+    OPENGEODE_EXCEPTION(
+        tet_solid_from_mesh_grid_2->nb_polyhedra() == nb_tetrahedra,
+        "[Test] Number of tetrahedra in TetrahedralSolid3D from RegularGrid3D "
+        "as grid is not correct." );
+    OPENGEODE_EXCEPTION(
+        hybrid_solid_from_mesh_grid->nb_polyhedra() == mesh_grid->nb_cells(),
+        "[Test] Number of hexahedra in HybridSolid3D from "
+        "RegularGrid is not correct" );
     for( const auto polyhedron_id :
         geode::Range{ tet_solid_from_light_grid->nb_polyhedra() } )
     {
@@ -177,7 +187,7 @@ void test_hybrid_solid()
 
 void test()
 {
-    test_tetrahedral_solid();
+    test_grid_to_solids();
     test_hybrid_solid();
 }