Merge pull request #1069 from Geode-solutions/fix/only-fix-mappings

fix(Mappings): avoid several occurrences of the same mapping in Gener…

Author: MelchiorSchuh

include/geode/basic/mapping.hpp

@@ -186,14 +186,29 @@ namespace geode
     public:
         void map( const T1& in, const T2& out )
         {
+            if( this->has_mapping_input( in ) )
+            {
+                if( absl::c_contains( this->in2out_mapping().at( in ), out ) )
+                {
+                    return;
+                }
+            }
             this->in2out_mapping()[in].push_back( out );
             this->out2in_mapping()[out].push_back( in );
         }
 
         void unmap( const T1& in, const T2& out )
         {
+            if( !this->has_mapping_input( in ) )
+            {
+                return;
+            }
             auto& in_map = this->in2out_mapping().at( in );
             const auto itr = absl::c_find( in_map, out );
+            if( itr == in_map.end() )
+            {
+                return;
+            }
             in_map.erase( itr );
             if( this->in2out( in ).empty() )
             {

tests/basic/test-mappings.cpp

@@ -108,8 +108,8 @@ void test_generic_mappings()
     generic.map( 0, -8.0 );
     generic.map( 0, -8.0 );
     generic.map( 5, -8.0 );
-    OPENGEODE_EXCEPTION( generic.out2in( -8.0 ).size() == 5,
-        "[Test] Size of out2in for -8.0 should be 5" );
+    OPENGEODE_EXCEPTION( generic.out2in( -8.0 ).size() == 2,
+        "[Test] Size of out2in for -8.0 should be 2" );
     generic.erase_in( 0 );
     OPENGEODE_EXCEPTION( generic.out2in( -8.0 ).size() == 1,
         "[Test] Size of out2in for -8.0 should be 1" );