fix(Geometry): review changes.

Author: benoit2776

include/geode/geometry/dynamic_nn_search.hpp

@@ -37,7 +37,6 @@ namespace geode
     class DynamicNNSearch
     {
         OPENGEODE_DISABLE_COPY( DynamicNNSearch );
-        // OPENGEODE_TEMPLATE_ASSERT_2D_OR_3D( DynamicNNSearch );
 
     public:
         explicit DynamicNNSearch( std::vector< Point< dimension > > points );
@@ -47,6 +46,7 @@ namespace geode
         index_t nb_points() const;
 
         const Point< dimension >& point( index_t index ) const;
+        void add_point( const Point< dimension >& point );
 
         /*!
          * Get the neighbors closer than a given distance from the given point
@@ -58,8 +58,6 @@ namespace geode
         std::vector< index_t > radius_neighbors(
             const Point< dimension >& point, double threshold_distance ) const;
 
-        void add_point( const Point< dimension >& point );
-
     private:
         IMPLEMENTATION_MEMBER( impl_ );
     };

src/geode/geometry/dynamic_nn_search.cpp

@@ -23,14 +23,10 @@
 
 #include <geode/geometry/dynamic_nn_search.hpp>
 
-#include <numeric>
+#include <nanoflann.hpp>
 
 #include <absl/algorithm/container.h>
 
-#include <async++.h>
-
-#include <nanoflann.hpp>
-
 #include <geode/basic/logger.hpp>
 #include <geode/basic/pimpl_impl.hpp>
 
@@ -64,8 +60,7 @@ namespace geode
             nanoflann::RadiusResultSet< double, index_t > resultSet(
                 threshold_distance * threshold_distance, results );
             dynamic_nn_tree_.findNeighbors( resultSet, &copy( point )[0] );
-            std::sort(
-                results.begin(), results.end(), nanoflann::IndexDist_Sorter() );
+            absl::c_sort( results, nanoflann::IndexDist_Sorter() );
             std::vector< index_t > indices;
             indices.reserve( results.size() );
             for( const auto& result : results )
@@ -93,6 +88,7 @@ namespace geode
             }
             return result;
         }
+
         struct PointCloud
         {
             std::vector< Point< dimension > > points;
@@ -133,7 +129,7 @@ namespace geode
     template < index_t dimension >
     DynamicNNSearch< dimension >::DynamicNNSearch(
         std::vector< Point< dimension > > points )
-        : impl_( std::move( points ) )
+        : impl_{ std::move( points ) }
     {
     }
 

tests/geometry/CMakeLists.txt

@@ -61,33 +61,33 @@ add_geode_test(
         ${PROJECT_NAME}::geometry
 )
 add_geode_test(
-    SOURCE "test-intersection.cpp"
+    SOURCE "test-dynamic-nnsearch.cpp" 
     DEPENDENCIES
         ${PROJECT_NAME}::basic
         ${PROJECT_NAME}::geometry
-    ESSENTIAL
 )
 add_geode_test(
-    SOURCE "test-intersection-detection.cpp"
+    SOURCE "test-intersection.cpp"
     DEPENDENCIES
         ${PROJECT_NAME}::basic
         ${PROJECT_NAME}::geometry
     ESSENTIAL
 )
 add_geode_test(
-    SOURCE "test-mensuration.cpp"
+    SOURCE "test-intersection-detection.cpp"
     DEPENDENCIES
         ${PROJECT_NAME}::basic
         ${PROJECT_NAME}::geometry
+    ESSENTIAL
 )
 add_geode_test(
-    SOURCE "test-nnsearch.cpp" 
+    SOURCE "test-mensuration.cpp"
     DEPENDENCIES
         ${PROJECT_NAME}::basic
         ${PROJECT_NAME}::geometry
 )
 add_geode_test(
-    SOURCE "test-dynamic-nnsearch.cpp" 
+    SOURCE "test-nnsearch.cpp" 
     DEPENDENCIES
         ${PROJECT_NAME}::basic
         ${PROJECT_NAME}::geometry

tests/mesh/CMakeLists.txt

@@ -155,13 +155,6 @@ add_geode_test(
         ${PROJECT_NAME}::geometry
         ${PROJECT_NAME}::mesh
 )
-add_geode_test(
-    SOURCE "test-dynamic-nnsearch-point-set.cpp"
-    DEPENDENCIES
-        ${PROJECT_NAME}::basic
-        ${PROJECT_NAME}::geometry
-        ${PROJECT_NAME}::mesh
-)
 add_geode_test(
     SOURCE "test-point-set.cpp"
     DEPENDENCIES