Merge pull request #1038 from Geode-solutions/fix/better_gradient_computation_and-gradient_shape_functions

fix(gradient computation): Added functions to compute gradient giving…

Author: MelchiorSchuh

include/geode/mesh/helpers/generic_edged_curve_accessor.hpp

@@ -52,6 +52,11 @@ namespace geode
         {
         }
 
+        [[nodiscard]] index_t nb_vertices() const
+        {
+            return mesh_.nb_vertices();
+        }
+
         [[nodiscard]] index_t nb_elements() const
         {
             return mesh_.nb_edges();

include/geode/mesh/helpers/generic_solid_accessor.hpp

@@ -53,6 +53,11 @@ namespace geode
         {
         }
 
+        [[nodiscard]] index_t nb_vertices() const
+        {
+            return mesh_.nb_vertices();
+        }
+
         [[nodiscard]] index_t nb_elements() const
         {
             return mesh_.nb_polyhedra();
@@ -68,6 +73,18 @@ namespace geode
             return mesh_.nb_polyhedron_facets( polyhedron_id );
         }
 
+        [[nodiscard]] index_t element_index(
+            const ElementFacet& polyhedron_facet ) const
+        {
+            return polyhedron_facet.polyhedron_id;
+        }
+
+        [[nodiscard]] index_t facet_index(
+            const ElementFacet& polyhedron_facet ) const
+        {
+            return polyhedron_facet.facet_id;
+        }
+
         [[nodiscard]] index_t element_vertex(
             const ElementVertex& polyhedron_vertex ) const
         {
@@ -87,21 +104,21 @@ namespace geode
         }
 
         [[nodiscard]] ElementFacetVertices element_facet_vertices(
-            const ElementFacet& polyhedron_facet ) const
+            const ElementFacet& element_facet ) const
         {
-            return mesh_.polyhedron_facet_vertices( polyhedron_facet );
+            return mesh_.polyhedron_facet_vertices( element_facet );
         }
 
         [[nodiscard]] std::optional< index_t > element_adjacent(
-            const ElementFacet& polyhedron_facet ) const
+            const ElementFacet& element_facet ) const
         {
-            return mesh_.polyhedron_adjacent( polyhedron_facet );
+            return mesh_.polyhedron_adjacent( element_facet );
         }
 
         [[nodiscard]] std::optional< ElementFacet > element_adjacent_facet(
-            const ElementFacet& polyhedron_facet ) const
+            ElementFacet element_facet ) const
         {
-            return mesh_.polyhedron_adjacent_facet( polyhedron_facet );
+            return mesh_.polyhedron_adjacent_facet( element_facet );
         }
 
         [[nodiscard]] const uuid& id() const

include/geode/mesh/helpers/generic_surface_accessor.hpp

@@ -53,6 +53,11 @@ namespace geode
         {
         }
 
+        [[nodiscard]] index_t nb_vertices() const
+        {
+            return mesh_.nb_vertices();
+        }
+
         [[nodiscard]] index_t nb_elements() const
         {
             return mesh_.nb_polygons();
@@ -68,6 +73,18 @@ namespace geode
             return mesh_.nb_polygon_edges( polygon_id );
         }
 
+        [[nodiscard]] index_t element_index(
+            const ElementFacet& polygon_edge ) const
+        {
+            return polygon_edge.polygon_id;
+        }
+
+        [[nodiscard]] index_t facet_index(
+            const ElementFacet& polygon_edge ) const
+        {
+            return polygon_edge.edge_id;
+        }
+
         [[nodiscard]] index_t element_vertex(
             const ElementVertex& polygon_vertex ) const
         {
@@ -87,21 +104,21 @@ namespace geode
         }
 
         [[nodiscard]] ElementFacetVertices element_facet_vertices(
-            const ElementFacet& polygon_edge ) const
+            const ElementFacet& element_facet ) const
         {
-            return mesh_.polygon_edge_vertices( polygon_edge );
+            return mesh_.polygon_edge_vertices( element_facet );
         }
 
         [[nodiscard]] std::optional< index_t > element_adjacent(
-            const ElementFacet& polygon_edge ) const
+            const ElementFacet& element_facet ) const
         {
-            return mesh_.polygon_adjacent( polygon_edge );
+            return mesh_.polygon_adjacent( element_facet );
         }
 
         [[nodiscard]] std::optional< ElementFacet > element_adjacent_facet(
-            const ElementFacet& polygon_edge ) const
+            const ElementFacet& element_facet ) const
         {
-            return mesh_.polygon_adjacent_edge( polygon_edge );
+            return mesh_.polygon_adjacent_edge( element_facet );
         }
 
         [[nodiscard]] const uuid& id() const

include/geode/mesh/helpers/gradient_computation.hpp

@@ -43,4 +43,20 @@ namespace geode
     [[nodiscard]] std::string opengeode_mesh_api
         compute_solid_scalar_function_gradient(
             const SolidMesh3D& mesh, std::string_view scalar_function_name );
+
+    namespace internal
+    {
+        template < index_t dimension >
+        [[nodiscard]] std::tuple< std::string, std::vector< index_t > >
+            compute_surface_scalar_function_gradient(
+                const SurfaceMesh< dimension >& mesh,
+                std::string_view scalar_function_name,
+                absl::Span< const index_t > no_value_vertices );
+
+        [[nodiscard]] std::tuple< std::string, std::vector< index_t > >
+            opengeode_mesh_api compute_solid_scalar_function_gradient(
+                const SolidMesh3D& mesh,
+                std::string_view scalar_function_name,
+                absl::Span< const index_t > no_value_vertices );
+    } // namespace internal
 } // namespace geode

include/geode/mesh/helpers/internal/grid_shape_function.hpp

@@ -29,6 +29,7 @@
 namespace geode
 {
     FORWARD_DECLARATION_DIMENSION_CLASS( Point );
+    FORWARD_DECLARATION_DIMENSION_CLASS( Vector );
     FORWARD_DECLARATION_DIMENSION_CLASS( Grid );
 } // namespace geode
 
@@ -41,5 +42,12 @@ namespace geode
             const typename Grid< dimension >::CellIndices& cell_id,
             local_index_t node_id,
             const Point< dimension >& point_in_grid );
+
+        template < index_t dimension >
+        [[nodiscard]] double gradient_shape_function_value(
+            const typename Grid< dimension >::CellIndices& cell_id,
+            local_index_t node_id,
+            const Point< dimension >& point_in_grid,
+            local_index_t derivative_direction );
     } // namespace internal
 } // namespace geode