Merge branch 'next' of https://github.com/Geode-solutions/OpenGeode into fix_removing_apex_refine_in_remesh

Author: benoit2776

include/geode/basic/range.hpp

@@ -81,6 +81,18 @@ namespace geode
             : iter_( static_cast< Type >( begin ) ),
               last_( static_cast< Type >( end ) )
         {
+            if constexpr( std::is_arithmetic_v< Type > )
+            {
+                using T1U = std::make_unsigned_t< T1 >;
+                using T2U = std::make_unsigned_t< T2 >;
+                const auto beginU = static_cast< T1U >( begin );
+                const auto endU = static_cast< T2U >( end );
+                const auto max = std::numeric_limits< Type >::max();
+                OPENGEODE_EXCEPTION( beginU <= max,
+                    "[Range] Invalid range: ", begin, " > ", max );
+                OPENGEODE_EXCEPTION(
+                    endU <= max, "[Range] Invalid range: ", end, " > ", max );
+            }
         }
 
     private:
@@ -115,7 +127,8 @@ namespace geode
         }
 
         template < typename T >
-        constexpr explicit TRange( T end ) : TRange( 0, end )
+        constexpr explicit TRange( T end )
+            : TRange( static_cast< Type >( 0 ), end )
         {
         }
 
@@ -148,7 +161,9 @@ namespace geode
         }
 
         template < typename T >
-        constexpr explicit TReverseRange( T begin ) : TReverseRange( begin, 0 )
+        constexpr explicit TReverseRange( T begin )
+            : BaseRange< Type, DecrementOperator >(
+                  begin - 1, static_cast< Type >( -1 ) )
         {
         }
 
@@ -176,7 +191,8 @@ namespace geode
     public:
         template < typename Container >
         constexpr explicit TIndices( const Container& container )
-            : BaseRange< Type, IncrementOperator >( 0, container.size() )
+            : BaseRange< Type, IncrementOperator >(
+                  static_cast< Type >( 0 ), container.size() )
         {
         }
 

src/geode/mesh/helpers/rasterize.cpp

@@ -685,18 +685,18 @@ namespace
         void fill_values( const geode::Triangle2D& triangle )
         {
             const auto bbox = triangle.bounding_box();
-            const auto max_j = std::floor(
+            const auto max_j = static_cast< geode::index_t >( std::floor(
                 bbox.max().value( 0 ) / grid_.cell_length_in_direction( 1 )
-                - 0.5 );
-            const auto max_k = std::floor(
+                - 0.5 ) );
+            const auto max_k = static_cast< geode::index_t >( std::floor(
                 bbox.max().value( 1 ) / grid_.cell_length_in_direction( 2 )
-                - 0.5 );
-            const auto min_j = std::ceil(
+                - 0.5 ) );
+            const auto min_j = static_cast< geode::index_t >( std::ceil(
                 bbox.min().value( 0 ) / grid_.cell_length_in_direction( 1 )
-                - 0.5 );
-            const auto min_k = std::ceil(
+                - 0.5 ) );
+            const auto min_k = static_cast< geode::index_t >( std::ceil(
                 bbox.min().value( 1 ) / grid_.cell_length_in_direction( 2 )
-                - 0.5 );
+                - 0.5 ) );
             const auto max_i_grid = grid_.nb_cells_in_direction( 0 ) - 1;
             for( const auto j : geode::Range{ min_j, max_j + 1 } )
             {

tests/common.hpp.in

@@ -46,6 +46,7 @@ namespace geode
         try                                                                    \
         {                                                                      \
             geode::OpenGeodeBasicLibrary::initialize();                        \
+            geode::Logger::set_level( geode::Logger::LEVEL::trace );           \
             test();                                                            \
                                                                                \
             geode::Logger::info( "TEST SUCCESS" );                             \