fix

Author: BotellaA

include/geode/basic/detail/geode_input_impl.h

@@ -44,7 +44,7 @@ namespace geode
             if( object.name() == Identifier::DEFAULT_NAME )
             {
                 IdentifierBuilder{ object }.set_name(
-                    filename_without_extension( filename ) );
+                    filename_without_extension( filename ).string() );
             }
         }
 
@@ -55,7 +55,7 @@ namespace geode
             if( object->name() == Identifier::DEFAULT_NAME )
             {
                 IdentifierBuilder{ *object }.set_name(
-                    filename_without_extension( filename ) );
+                    filename_without_extension( filename ).string() );
             }
         }
 

include/geode/basic/detail/geode_output_impl.h

@@ -60,8 +60,11 @@ namespace geode
         {
             const Timer timer;
             auto output = geode_object_output_writer< Factory >( filename );
-            std::filesystem::create_directories(
-                filepath_without_filename( filename ) );
+            const auto directories = filepath_without_filename( filename );
+            if( !directories.empty() )
+            {
+                std::filesystem::create_directories( directories );
+            }
             auto result = output->write( object );
             Logger::info(
                 type, " saved in ", filename, " in ", timer.duration() );

include/geode/basic/filename.h

@@ -23,21 +23,23 @@
 
 #pragma once
 
+#include <filesystem>
+
 #include <geode/basic/common.h>
 
 namespace geode
 {
-    std::string opengeode_basic_api filename_with_extension(
-        std::string_view path );
+    std::filesystem::path opengeode_basic_api filename_with_extension(
+        const std::filesystem::path& path );
 
-    std::string opengeode_basic_api filename_without_extension(
-        std::string_view path );
+    std::filesystem::path opengeode_basic_api filename_without_extension(
+        const std::filesystem::path& path );
 
-    std::string opengeode_basic_api filepath_without_extension(
-        std::string_view path );
+    std::filesystem::path opengeode_basic_api filepath_without_extension(
+        const std::filesystem::path& path );
 
-    std::string opengeode_basic_api filepath_without_filename(
-        std::string_view path );
+    std::filesystem::path opengeode_basic_api filepath_without_filename(
+        const std::filesystem::path& path );
 
     std::string_view opengeode_basic_api extension_from_filename(
         std::string_view filename );

src/geode/basic/filename.cpp

@@ -28,28 +28,30 @@
 
 namespace geode
 {
-    std::string filename_with_extension( std::string_view path )
+    std::filesystem::path filename_with_extension(
+        const std::filesystem::path& path )
     {
-        const std::filesystem::path filepath{ to_string( path ) };
-        return filepath.filename().string();
+        return path.filename();
     }
 
-    std::string filename_without_extension( std::string_view path )
+    std::filesystem::path filename_without_extension(
+        const std::filesystem::path& path )
     {
-        const std::filesystem::path filepath{ to_string( path ) };
-        return filepath.filename().replace_extension( "" ).string();
+        return path.filename().replace_extension( "" ).string();
     }
 
-    std::string filepath_without_extension( std::string_view path )
+    std::filesystem::path filepath_without_extension(
+        const std::filesystem::path& path )
     {
-        std::filesystem::path filepath{ to_string( path ) };
-        return filepath.replace_extension( "" ).string();
+        auto filepath = path;
+        return filepath.replace_extension( "" );
     }
 
-    std::string filepath_without_filename( std::string_view path )
+    std::filesystem::path filepath_without_filename(
+        const std::filesystem::path& path )
     {
-        std::filesystem::path filepath{ to_string( path ) };
-        return filepath.replace_filename( "" ).string();
+        auto filepath = path;
+        return filepath.remove_filename();
     }
 
     std::string_view extension_from_filename( std::string_view filename )